Re: [Intel-gfx] [alsa-devel] USB Type-C monitor flashes once when play a video file after unplug and re-plug the monitor

On Mon, Jan 06, 2020 at 08:08:04AM +, lucien_...@compal.com wrote: > Hi Takashi > > We verified on Ubuntu 19.10 with kernel 5.4.0.0-050400-generic (please refer > to attachment), the result is positive which symptom doesn't happen anymore > once I played music or video sound output through

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Enable hotplug retry

On Wed, Jul 10, 2019 at 03:15:00PM -0700, José Roberto de Souza wrote: > Right now we are aware of two cases that needs another hotplug retry: > - Unpowered type-c dongles > - HDMI slow unplug > > Both have a complete explanation in the code to schedule another run > of the hotplug handler. > >

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915: Add support for retrying hotplug

On Wed, Jul 10, 2019 at 03:14:59PM -0700, José Roberto de Souza wrote: > From: Imre Deak > > There is some scenarios that we are aware that sink probe can fail, > so lets add the infrastructure to let hotplug() hook to request > another probe after some time. > > v2: Handle shared HPD pins

Re: [Intel-gfx] [PATCH 3/3] drm/i915/psr: Enable PSR1 on gen-9+ HW

On Thu, Sep 06, 2018 at 11:21:35PM -0700, Dhinakaran Pandiyan wrote: > We have new tests and fixes in place since the feature was last > disabled. > > Try again for gen-9+ hardware and enable only PSR1 as a first step. Since this patch explicitly disables PSR2 for all platforms maybe you can

[Intel-gfx] [PATCH] drm/i915/dp: Improve clock recovery loop limit comment

) but we should tolerate any that may trigger this corner case Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Cc: Marc Herbert Suggested-by: Marc Herbert Signed-off-by: Nathan Ciobanu diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index

Re: [Intel-gfx] [PATCH v6] drm/i915/dp: Limit link training clock recovery loop

On Fri, Jul 20, 2018 at 01:28:44PM -0700, Rodrigo Vivi wrote: > On Fri, Jul 20, 2018 at 01:15:59PM -0700, Nathan Ciobanu wrote: > > Limit the link training clock recovery loop to 10 attempts at > > LANEx_CR_DONE per DP 1.4 spec section 3.5.1.2.2 and 80 attempts for > > pre-DP

Re: [Intel-gfx] [PATCH v5 1/2] drm/i915/dp: Limit link training clock recovery loop

On Fri, Jul 20, 2018 at 12:22:15PM -0700, Rodrigo Vivi wrote: > On Thu, Jul 19, 2018 at 02:47:38PM -0700, Nathan Ciobanu wrote: > > Limit the link training clock recovery loop to 10 attempts at > > LANEx_CR_DONE per DP 1.4 spec section 3.5.1.2.2 and 80 attempts for > > pre-DP

[Intel-gfx] [PATCH v6] drm/i915/dp: Limit link training clock recovery loop

: Dhinakaran Pandiyan Cc: Rodrigo Vivi Cc: Marc Herbert Cc: Manasi Navare Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915/intel_dp_link_training.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915/dp: Refactor mav_vswing_tries variable

On Fri, Jul 20, 2018 at 01:19:02PM +0300, Ville Syrjälä wrote: > On Thu, Jul 19, 2018 at 02:48:07PM -0700, Nathan Ciobanu wrote: > > Changes the type and renames the max_vswing_tries variable > > which was declared as an integer but used as a boolean > > making i

[Intel-gfx] [PATCH v5] drm/i915/dp: Refactor max_vswing_tries variable

max_vswing to max_vswing_reached (Ville) Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Cc: Marc Herbert Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused "ret" variable.

On Thu, Jul 19, 2018 at 05:16:03PM -0700, Nathan Ciobanu wrote: > On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote: > > Just a small clean-up with no functional change, only > > removing a variable that is never actually used. > > > > Cc: Dhinakar

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused "ret" variable.

On Thu, Jul 19, 2018 at 04:42:17PM -0700, Rodrigo Vivi wrote: > Just a small clean-up with no functional change, only > removing a variable that is never actually used. > > Cc: Dhinakaran Pandiyan > Signed-off-by: Rodrigo Vivi Nice one :) Reviewed-by: > --- >

[Intel-gfx] [PATCH v5] drm/i915/dp: Refactor max_vswing_tries variable

Pandiyan Cc: Rodrigo Vivi Cc: Marc Herbert Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c

[Intel-gfx] [PATCH v5 2/2] drm/i915/dp: Refactor mav_vswing_tries variable

Vivi Cc: Marc Herbert Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915/intel_dp_link_training.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 7903de7a54c9

[Intel-gfx] [PATCH v5 1/2] drm/i915/dp: Limit link training clock recovery loop

: Manasi Navare Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915/intel_dp_link_training.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp_link_training.c b/drivers/gpu/drm/i915/intel_dp_link_training.c index 4da6e33c7fa1

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

On Thu, Jul 19, 2018 at 10:01:41AM -0700, Rodrigo Vivi wrote: > On Tue, Jul 17, 2018 at 06:05:51PM -0700, Nathan Ciobanu wrote: > > On Tue, Jul 17, 2018 at 03:21:17PM -0700, Dhinakaran Pandiyan wrote: > > > On Mon, 2018-07-16 at 16:51 -0700,

[Intel-gfx] [PATCH v4 2/2] drm/i915/dp: Remove unneeded mav_vswing_tries variable

max_vswing_tries variable was declared as an int but used as a bool and not even needed because we can just check the return of intel_dp_link_max_vswing_reached. Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Cc: Marc Herbert Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v4 1/2] drm/i915/dp: Limit link training clock recovery loop

message to use DP_DP14_MAX_CR_TRIES Changes in v4: - Updated the title to reflect the change - Updated the commit message - Added 80 attempts for pre-DP 1.4 devices Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Cc: Marc Herbert Cc: Manasi Navare Signed-off-by: Nathan Ciobanu --- drivers

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/mst: Do not retrain new links

ning started. > > Check for a positive value of active_mst_links and throw in a warning for > invalid active_mst_links as debug aid. > > Cc: Nathan Ciobanu > Cc: Rodrigo Vivi > Signed-off-by: Dhinakaran Pandiyan Tested-by: Nathan Ciobanu > --- > drivers/gpu/drm/i915/intel_d

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/mst: Continue state updates even if AUX writes fail.

v2: Fixed int v/s bool comparison > > Cc: Ville Syrjälä > Cc: Rodrigo Vivi > Cc: Nathan Ciobanu > Signed-off-by: Dhinakaran Pandiyan Reviewed-by: Nathan Ciobanu Tested-by: Nathan Ciobanu > --- > drivers/gpu/drm/i915/intel_dp_mst.c | 5 + > 1 file changed, 1 in

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

On Tue, Jul 17, 2018 at 03:21:17PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-07-16 at 16:51 -0700, Marc Herbert wrote: > > > > > > > > > > > I think the bug is with this infinite loop which is at the mercy > > > > of an external device > > > > and in my case I have this MST hub which

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

sing "increment from false to true": > > > > - if (max_vswing_tries == 1) > > + if (max_vswing_tries) > > > > - max_vswing_tries++; > > + max_vwing_tries = true; > > if we change to boolean it is better to really change the type > and remove "

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

On Mon, Jul 16, 2018 at 03:34:58PM -0700, Rodrigo Vivi wrote: > On Mon, Jul 16, 2018 at 11:14:45AM -0700, Nathan Ciobanu wrote: > > Limit the link training clock recovery loop to 10 failed attempts at > > LANEx_CR_DONE per DP 1.4 spec section 3.5.1.2.2. > > Thanks... so th

[Intel-gfx] [PATCH v3] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

: - updated commit message (DK, Manasi) - defined DP_DP14_MAX_CR_TRIES (Marc) - made the loop iterate for max 10 times (Rodrigo, Marc) Changes in v3: - changed error message to use DP_DP14_MAX_CR_TRIES Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915/intel_dp_link_training.c

[Intel-gfx] [PATCH v2] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

: - updated commit message (DK, Manasi) - defined DP_DP14_MAX_CR_TRIES (Marc) - made the loop iterate for max 10 times (Rodrigo, Marc) Signed-off-by: Nathan Ciobanu --- drivers/gpu/drm/i915/intel_dp_link_training.c | 6 -- include/drm/drm_dp_helper.h | 1 + 2

Re: [Intel-gfx] [PATCH] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

On Fri, Jul 13, 2018 at 03:18:32PM -0700, Manasi Navare wrote: > On Fri, Jul 13, 2018 at 03:23:41PM -0700, Dhinakaran Pandiyan wrote: > > On Fri, 2018-07-13 at 14:22 -0700, Rodrigo Vivi wrote: > > > On Fri, Jul 13, 2018 at 10:32:15AM -0700, Nathan Ciobanu wrote: > > >

Re: [Intel-gfx] [PATCH] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

On Fri, Jul 13, 2018 at 02:22:03PM -0700, Rodrigo Vivi wrote: > On Fri, Jul 13, 2018 at 10:32:15AM -0700, Nathan Ciobanu wrote: > > Limit the link training clock recovery loop to 10 failed attempts at > > LANEx_CR_DONE per DP 1.4 spec. > > Where exactly in the spec? I'll a

[Intel-gfx] [PATCH] drm/i915/dp: Give up link training clock recovery after 10 failed attempts

Limit the link training clock recovery loop to 10 failed attempts at LANEx_CR_DONE per DP 1.4 spec. Some USB-C MST hubs cause us to get stuck in this loop on hot-plugging indefinitely as drm_dp_clock_recovery_ok() never returns true and none of the other conditions occur. Signed-off-by: Nathan

Re: [Intel-gfx] [CI 1/6] drm/i915/psr: New power domain for AUX IO.

<ville.syrj...@linux.intel.com> > Suggested-by: Imre Deak <imre.d...@intel.com> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> > Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> Tested-by: Nathan Ciobanu <nathan.d.ciob...@linux

Re: [Intel-gfx] [PATCH] drm/i915/psr: Check for power state control capability.

pcd init movement lands. > > Cc: Nathan D Ciobanu <nathan.d.ciob...@intel.com> > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Tested-by: Nathan Ciobanu <nathan.d.ciob...@linux.intel.com&g

Re: [Intel-gfx] [PATCH v2] drm/dp/mst: fix kernel oops when turning off secondary monitor

I tested this patch in dinq on a KBL system and it fixed the bug. The system doesn't crash on disconnecting or powering off the second monitor in the DP-MST chain. I also replied to the Bugzilla issue. Tested-by: Nathan D Ciobanu On 12/05/2016 01:49 PM,

Re: [Intel-gfx] [PATCH v2] drm/dp/mst: fix kernel oops when turning off secondary monitor

I tested this on a KBL using 01-25-2017 dinq and it fixed the bug. Tested-by: Nathan D Ciobanu On 12/05/2016 01:49 PM, Pierre-Louis Bossart wrote: 100% reproducible issue found on SKL SkullCanyon NUC with two external DP daisy-chained monitors in DP/MST