Re: [Intel-gfx] [PATCH] drm/i915: HDCP: retry link integrity check on failure

2020-05-05 Thread Oliver Barta
On Tue, May 5, 2020 at 9:38 AM Ramalingam C wrote: > > On 2020-05-04 at 14:35:24 +0200, Oliver Barta wrote: > > From: Oliver Barta > > > > A single Ri mismatch doesn't automatically mean that the link integrity > > is broken. Update and check of Ri and Ri' are do

Re: [Intel-gfx] [PATCH] drm/i915: HDCP: retry link integrity check on failure

2020-05-05 Thread Oliver Barta
On Mon, May 4, 2020 at 10:24 PM Sean Paul wrote: > > On Mon, May 4, 2020 at 1:32 PM Oliver Barta wrote: > > > > From: Oliver Barta > > > > A single Ri mismatch doesn't automatically mean that the link integrity > > is broken. Update and check of Ri and Ri'

[Intel-gfx] [PATCH] drm/i915: HDCP: retry link integrity check on failure

2020-05-04 Thread Oliver Barta
From: Oliver Barta A single Ri mismatch doesn't automatically mean that the link integrity is broken. Update and check of Ri and Ri' are done asynchronously. In case an update happens just between the read of Ri' and the check against Ri there will be a mismatch even if the link integrity

[Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime check done during link check

2020-03-30 Thread Oliver Barta
From: Oliver Barta The check was always succeeding even in case of a mismatch due to the HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. Signed-off-by: Oliver Barta Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") --- [v2] rebased on top of late

Re: [Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check

2020-03-05 Thread Oliver Barta
On Tue, Mar 3, 2020 at 10:33 AM Ramalingam C wrote: > > On 2020-02-29 at 11:39:22 +0100, Oliver Barta wrote: > > From: Oliver Barta > > > > The check was always succeeding even in case of a mismatch due to the > > HDCP_STATUS_ENC bit being set. Make s

[Intel-gfx] [PATCH v2] drm/i915: HDCP: fix Ri prime and R0 checks during auth

2020-03-05 Thread Oliver Barta
From: Oliver Barta Including HDCP_STATUS_ENC bit in the checks is pointless. It is simply not set at this point. Signed-off-by: Oliver Barta Fixes: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation") --- [v2] rebased on top of latest changes drivers/gpu/drm/i9

[Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime and R0 checks during auth

2020-03-04 Thread Oliver Barta
From: Oliver Barta Including HDCP_STATUS_ENC bit in the checks is pointless. It is simply not set at this point. Signed-off-by: Oliver Barta Fixes: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation") --- drivers/gpu/drm/i915/display/intel_hdcp.c | 4 ++-- 1 file

[Intel-gfx] [PATCH] drm/i915: HDCP: fix Ri prime check done during link check

2020-03-02 Thread Oliver Barta
From: Oliver Barta The check was always succeeding even in case of a mismatch due to the HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. Signed-off-by: Oliver Barta Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") --- Submitted before as part of pa

[Intel-gfx] [PATCH v2 3/3] drm/i915: HDCP: retry link integrity check on failure

2020-02-28 Thread Oliver Barta
From: Oliver Barta A single Ri mismatch doesn't automatically mean that the link integrity is broken. Update and check of Ri and Ri' are done asynchronously. In case an update happens just between the read of Ri' and the check against Ri there will be a mismatch even if the link integrity

[Intel-gfx] [PATCH v2 2/3] drm/i915: HDCP: fix Ri prime and R0 checks during auth

2020-02-28 Thread Oliver Barta
From: Oliver Barta Including HDCP_STATUS_ENC bit in the checks is pointless. It is simply not set at this point. Signed-off-by: Oliver Barta Fixes: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation") --- [v2] Rebased patch series from master to drm-intel-next-que

[Intel-gfx] [PATCH v2 1/3] drm/i915: HDCP: fix Ri prime check done during link check

2020-02-28 Thread Oliver Barta
From: Oliver Barta The check was always succeeding even in case of a mismatch due to the HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. Signed-off-by: Oliver Barta Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") --- [v2] Rebased patch series from mas

[Intel-gfx] [PATCH 3/3] drm/i915: HDCP: retry link integrity check on failure

2020-02-26 Thread Oliver Barta
. A failure can also be caused by transmission errors on DDC. Signed-off-by: Oliver Barta --- drivers/gpu/drm/i915/display/intel_hdmi.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 2/3] drm/i915: HDCP: fix Ri prime and R0 checks during auth

2020-02-26 Thread Oliver Barta
Including HDCP_STATUS_ENC bit in the checks is pointless. It is simply not set at this point. Signed-off-by: Oliver Barta Fixes: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation") --- drivers/gpu/drm/i915/display/intel_hdcp.c | 4 ++-- 1 file changed, 2 insert

[Intel-gfx] [PATCH 1/3] drm/i915: HDCP: fix Ri prime check done during link check

2020-02-26 Thread Oliver Barta
The check was always succeeding even in case of a mismatch due to the HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. Signed-off-by: Oliver Barta Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") --- drivers/gpu/drm/i915/display/intel_hdmi.c | 3 ++- 1 fi