Re: [PATCH] treewide: Fix common grammar mistake "the the"

2024-04-11 Thread Randy Dunlap
scripts/coccinelle/misc/badty.cocci | 2 +- > tools/perf/Documentation/perf-diff.txt| 2 +- > 30 files changed, 32 insertions(+), 32 deletions(-) > Reviewed-by: Randy Dunlap Thanks. -- #Randy

Re: linux-next: Tree for Feb 26 (drivers/gpu/drm/xe)

2024-02-26 Thread Randy Dunlap
On 2/25/24 22:55, Stephen Rothwell wrote: > Hi all, > > Changes since 20240223: > on powerpc32 or i386: ../drivers/gpu/drm/xe/xe_ggtt.c: In function 'xe_ggtt_set_pte': ../drivers/gpu/drm/xe/xe_ggtt.c:78:9: error: implicit declaration of function 'writeq'; did you mean 'writel'?

Re: linux-next: Tree for Jan 29 (drm/xe/ and FB_IOMEM_HELPERS)

2024-01-29 Thread Randy Dunlap
On 1/28/24 19:30, Stephen Rothwell wrote: > Hi all, > > Changes since 20240125: > > New trees: i2c-host-fixes, i2c-host > on riscv 64-bit or powerpc 64-bit: WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n] Selected by [m]:

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-24 Thread Randy Dunlap
On 1/24/24 01:17, Jani Nikula wrote: > On Tue, 23 Jan 2024, Randy Dunlap wrote: >> On 1/22/24 18:29, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: there will be no linux-next release on Friday >>> >>> Changes since 20240122: >&

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-23 Thread Randy Dunlap
On 1/22/24 18:29, Stephen Rothwell wrote: > Hi all, > > News: there will be no linux-next release on Friday > > Changes since 20240122: > on ARM64, when DRM_I915 is not set DRM_XE=m DEBUG_FS is not set ../drivers/gpu/drm/i915/display/intel_display_debugfs.c:1091:6: error: redefinition of

[PATCH v2.1 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas

Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:25, Andi Shyti wrote: > Hi Randy, > > ... > >> /** >> * struct intel_gsc - graphics security controller >> * >> - * @gem_obj: scratch memory GSC operations >> - * @intf : gsc interface >> + * @intf : gsc interface >> + * @intf.adev : MEI aux. device for this

Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:40, Andi Shyti wrote: > Hi Randy, > > [...] > >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> @@ -105,61 +105,67 @@ struct intel_guc { >> */ > > > struct { } interrupts is missing here. > >> struct { >>

[PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
: Excess struct member 'work' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'shift' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'last_stat_jiffies' description in 'intel_guc' 18 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula

[PATCH v2 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
' i915_perf_types.h:341: warning: Excess struct member 'tail' description in 'i915_perf_stream' 3 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-de

[PATCH v2 1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. i915_gem_context_types.h:420: warning: Excess struct member 'lock' description in 'i915_gem_context' Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc

[PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas

Re: [PATCH 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-26 Thread Randy Dunlap
On 12/26/23 09:05, Rodrigo Vivi wrote: > On Wed, Dec 20, 2023 at 07:20:29PM -0800, Randy Dunlap wrote: >> Document nested struct members with full names as described in >> Documentation/doc-guide/kernel-doc.rst. >> >> i915_perf_types.h:341: warning: Excess struct me

[PATCH 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
' i915_perf_types.h:341: warning: Excess struct member 'tail' description in 'i915_perf_stream' 3 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-de

[PATCH 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
: Excess struct member 'work' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'shift' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'last_stat_jiffies' description in 'intel_guc' 18 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula

[PATCH 1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. i915_gem_context_types.h:420: warning: Excess struct member 'lock' description in 'i915_gem_context' Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc

[PATCH 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-20 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas

[PATCH] drm/i915/uapi: fix typos/spellos and punctuation

2023-12-12 Thread Randy Dunlap
Use "its" for possessive form instead of "it's". Hyphenate multi-word adjectives. Correct some spelling. End one line of code with ';' instead of ','. The before and after object files are identical. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodr

[Intel-gfx] [PATCH v2] drm/i915/uapi: fix doc typos

2023-10-08 Thread Randy Dunlap
Correct typo of "its". Add commas for clarity. Capitalize L3. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: Ville Syrjälä

Re: [Intel-gfx] [PATCH] drm/i915/uapi: fix doc typos

2023-10-02 Thread Randy Dunlap
Hi-- On 10/1/23 23:47, Ville Syrjälä wrote: > On Sun, Oct 01, 2023 at 06:08:24PM -0700, Randy Dunlap wrote: >> Correct typo of "its". >> Add a comma for clarity. >> >> Signed-off-by: Randy Dunlap >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >>

[Intel-gfx] [PATCH] drm/i915/uapi: fix doc typos

2023-10-01 Thread Randy Dunlap
Correct typo of "its". Add a comma for clarity. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: dri-de...@lists.freed

Re: [Intel-gfx] ERR_PTR(0) in a couple of places

2023-09-24 Thread Randy Dunlap
On 9/24/23 21:18, Matthew Brost wrote: > On Sun, Sep 24, 2023 at 12:41:07AM +, Dr. David Alan Gilbert wrote: >> Hi, >> I randomly noticed there are a couple of places in the kernel that >> do >>ERR_PTR(0); >> >> and thought that was odd - shouldn't those just be NULL's ? >> >> 1) i915

Re: [Intel-gfx] linux-next: Tree for Sep 11 (drivers/gpu/drm/i915/display/intel_backlight.o)

2023-09-12 Thread Randy Dunlap
Hi Jani, On 9/12/23 07:52, Randy Dunlap wrote: > > > On 9/12/23 00:47, Jani Nikula wrote: >> On Mon, 11 Sep 2023, Randy Dunlap wrote: >>> On 9/10/23 19:11, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Please do *not* include

Re: [Intel-gfx] linux-next: Tree for Sep 11 (drivers/gpu/drm/i915/display/intel_backlight.o)

2023-09-12 Thread Randy Dunlap
On 9/12/23 00:47, Jani Nikula wrote: > On Mon, 11 Sep 2023, Randy Dunlap wrote: >> On 9/10/23 19:11, Stephen Rothwell wrote: >>> Hi all, >>> >>> Please do *not* include material destined for v6.7 in your linux-next >>> included branches until *aft

Re: [Intel-gfx] linux-next: Tree for Sep 11 (drivers/gpu/drm/i915/display/intel_backlight.o)

2023-09-11 Thread Randy Dunlap
On 9/10/23 19:11, Stephen Rothwell wrote: > Hi all, > > Please do *not* include material destined for v6.7 in your linux-next > included branches until *after* v6.6-rc1 has been released. Also, > do *not* rebase your linu-next included branches onto v6.5. > > Changes since 20230908: > >

Re: [Intel-gfx] [PATCH v4 21/21] dyndbg-doc: add classmap info to howto

2023-07-13 Thread Randy Dunlap
On 7/13/23 09:36, Jim Cromie wrote: > Add some basic info on classmap usage and api > > Signed-off-by: Jim Cromie > --- > .../admin-guide/dynamic-debug-howto.rst | 64 ++- > 1 file changed, 63 insertions(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH v4 20/21] config TEST_DYNAMIC_DEBUG default m

2023-07-13 Thread Randy Dunlap
Hi Jim, On 7/13/23 09:36, Jim Cromie wrote: > Signed-off-by: Jim Cromie > --- > lib/Kconfig.debug | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index d4fbbcc395d2..82d11ac63758 100644 > --- a/lib/Kconfig.debug > +++

Re: [Intel-gfx] [PATCH] drm/i915: make i915_drm_client_fdinfo() reference conditional again

2023-06-16 Thread Randy Dunlap
drm/i915/i915_driver.o:(i915_drm_driver) in >>>> archive vmlinux.a > > Use the PTR_IF() helper to make the reference NULL otherwise. > > Fixes: e894b724c316d ("drm/i915: Use the fdinfo helper") > Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Tes

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add missing forward declarations/includes to display power headers

2023-06-16 Thread Randy Dunlap
e *i915, struct > seq_file *m); > | > ^~~~ > > Reported-by: Randy Dunlap > Closes: > https://lore.kernel.org/intel-gfx/89adc1ac-25a0-6eb6-4cc9-ab6cc8d49...@infradead.org/ > Signed-off-by: Imre Deak Acked-by: Randy D

Re: [Intel-gfx] linux-next: Tree for Jun 13 (drivers/gpu/drm/i915/display/)

2023-06-13 Thread Randy Dunlap
On 6/12/23 23:59, Stephen Rothwell wrote: > Hi all, > > Changes since 20230609: > In file included from : ./../drivers/gpu/drm/i915/display/intel_display_power.h:255:70: error: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration

[Intel-gfx] [PATCH] drm/i915: move a Kconfig symbol to unbreak the menu presentation

2023-02-14 Thread Randy Dunlap
t;drm/i915/gvt: move the gvt code into kvmgt.ko") Signed-off-by: Randy Dunlap Cc: Christoph Hellwig Cc: Zhi Wang Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org Cc: intel-gvt-...@lists.freedesktop.org

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/gt: document TLB cache invalidation functions

2022-08-04 Thread Randy Dunlap
Hi Mauro, On 8/4/22 00:37, Mauro Carvalho Chehab wrote: > Add a description for the TLB cache invalidation algorithm and for > the related kAPI functions. > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C > on the

Re: [Intel-gfx] linux-next: Tree for May 24 (drivers/gpu/drm/i915/display/intel_backlight.o)

2022-05-24 Thread Randy Dunlap
On 5/24/22 02:26, Stephen Rothwell wrote: > Hi all, > > Note: please do not add any v5.20 material to your linux-next included > branches until after v5.19-rc1 has been related. > > Changes since 20220523: > on i386: drivers/gpu/drm/i915/display/intel_backlight.o: in function

Re: [Intel-gfx] [PATCH 11/11] drm/i915: Fix undefined behavior due to shift overflowing the constant

2022-05-17 Thread Randy Dunlap
.@zn.tnic for the gory > details as to why it triggers with older gccs only. > Acked-by: Randy Dunlap Tested-by: Randy Dunlap Is this merged anywhere? It could/should at least be in linux-next so that other people don't waste time on it. thanks. > Signed-off-by: Borislav Petkov > Cc:

Re: [Intel-gfx] linux-next: Tree for May 16 (drm/i915/gt/intel_gt_sysfs_pm.c)

2022-05-17 Thread Randy Dunlap
On 5/17/22 00:35, Tvrtko Ursulin wrote: > > Hi, > > On 16/05/2022 22:22, Randy Dunlap wrote: >> >> >> On 5/16/22 03:57, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20220513: >>> >> >> on i386: >

Re: [Intel-gfx] linux-next: Tree for May 16 (drm/i915/gt/intel_gt_sysfs_pm.c)

2022-05-16 Thread Randy Dunlap
On 5/16/22 03:57, Stephen Rothwell wrote: > Hi all, > > Changes since 20220513: > on i386: CC drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.o ../drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c: In function ‘act_freq_mhz_show’: ../drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:276:20: error:

Re: [Intel-gfx] mmotm 2022-01-26-21-04 uploaded (gpu/drm/i915/i915_gem_evict.h)

2022-01-26 Thread Randy Dunlap
On 1/26/22 21:04, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2022-01-26-21-04 has been uploaded to > >https://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > https://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of

[Intel-gfx] question about an intel-gfx issue (4447)

2021-12-28 Thread Randy Dunlap
Hi, For https://gitlab.freedesktop.org/drm/intel/-/issues/4447, are people aware of it or do I need to make people aware of it somehow? Do I need to provide more information? If so, what? thanks. -- ~Randy

Re: [Intel-gfx] mmotm 2021-12-22-19-02 uploaded (drivers/gpu/drm/i915/display/intel_backlight.o)

2021-12-22 Thread Randy Dunlap
On 12/22/21 19:02, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2021-12-22-19-02 has been uploaded to > >https://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > https://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of

[Intel-gfx] [PATCH] drm/i915/gem: placate scripts/kernel-doc

2021-11-22 Thread Randy Dunlap
value of 'i915_gem_object_read_from_page' Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Thomas Hellström Cc: Matthew Auld Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_object.c

Re: [Intel-gfx] mmotm 2021-10-27-18-32 uploaded (drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c)

2021-10-28 Thread Randy Dunlap
On 10/27/21 6:33 PM, a...@linux-foundation.org wrote: The mm-of-the-moment snapshot 2021-10-27-18-32 has been uploaded to https://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: https://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue.

Re: [Intel-gfx] ✗ Fi.CI.BUILD: failure for i915/gem/dmabuf: add to fix build error

2021-10-27 Thread Randy Dunlap
On 10/27/21 2:27 PM, Patchwork wrote: == Series Details == Series: i915/gem/dmabuf: add to fix build error URL : https://patchwork.freedesktop.org/series/96360/ State : failure == Summary == Applying: i915/gem/dmabuf: add to fix build error error: sha1 information is lacking or useless

[Intel-gfx] [PATCH -next] i915/gem/dmabuf: add to fix build error

2021-10-27 Thread Randy Dunlap
'wbinvd_on_all_cpus'; did you mean 'wrmsr_on_cpus'? [-Werror=implicit-function-declaration] wbinvd_on_all_cpus(); Fixes: a035154da45d ("drm/i915/dmabuf: add paranoid flush-on-acquire") Signed-off-by: Randy Dunlap To: Jani Nikula Cc: Thomas Hellström Cc: Matthew Auld Cc: Joonas La

Re: [Intel-gfx] [PATCH 2/3] fbdev: rework backlight dependencies

2021-10-27 Thread Randy Dunlap
+++--- 5 files changed, 15 insertions(+), 4 deletions(-) Acked-by: Randy Dunlap Thanks. -- ~Randy

Re: [Intel-gfx] linux-next: Tree for Oct 22 (drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c)

2021-10-22 Thread Randy Dunlap
On 10/22/21 2:15 AM, Stephen Rothwell wrote: Hi all, Changes since 20211021: on x86_64: ../drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c: In function ‘i915_gem_object_get_pages_dmabuf’: ../drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:248:3: error: implicit declaration of function

Re: [Intel-gfx] mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

2021-10-06 Thread Randy Dunlap
On 10/6/21 12:24 AM, Christian König wrote: Am 06.10.21 um 09:20 schrieb Stephen Rothwell: Hi Randy, On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap wrote: on i386: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' Full randconfig

[Intel-gfx] [PATCH] drm/i915/gvt: clean up kernel-doc in gtt.c

2021-10-02 Thread Randy Dunlap
: warning: expecting prototype for intel_vgpu_emulate_gtt_mmio_read(). Prototype was for intel_vgpu_emulate_ggtt_mmio_read() instead Fixes: a752b070a678 ("drm/i915/gvt: Fix function comment doc errors") Fixes: 2707e4446688 ("drm/i915/gvt: vGPU graphics memory virtualization")

Re: [Intel-gfx] Intel UHD resolutions

2021-09-11 Thread Randy Dunlap
On 9/11/21 4:37 AM, o1bigtenor wrote: On Fri, Sep 10, 2021 at 9:50 PM Randy Dunlap mailto:rdun...@infradead.org>> wrote: Hi, I would like to use QHD resolution (2560x1440) with my shiny new computer and display. That resolution works if I boot Windows 10 (cough). W

[Intel-gfx] Intel UHD resolutions

2021-09-10 Thread Randy Dunlap
Hi, I would like to use QHD resolution (2560x1440) with my shiny new computer and display. That resolution works if I boot Windows 10 (cough). What do I need to do to use that resolution in Linux? I first tried openSUSE 15.3 (kernel 5.3.18-59.19-default) then I build a v5.14 kernel and tried

[Intel-gfx] [PATCH -next] drm/i915: fix i915_globals_exit() section mismatch error

2021-08-04 Thread Randy Dunlap
section and the fix is to remove the __exit annotation of __i915_globals_flush. ERROR: modpost: Section mismatches detected. Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them. Fixes: 1354d830cb8f ("drm/i915: Call i915_globals_exit() if pci_register_device() fails") Signed-off-by: Ra

Re: [Intel-gfx] [PATCH 1/3] gpu: drm: replace occurrences of invalid character

2021-05-19 Thread Randy Dunlap
gt; Signed-off-by: Mauro Carvalho Chehab Acked-by: Randy Dunlap Thanks. > --- > drivers/gpu/drm/amd/include/atombios.h | 10 +- > drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.h| 2 +- > drivers/gpu/drm/r128/r12

Re: [Intel-gfx] [PATCH v6 2/3] drm/i915/display: Restructure output format computation for better expandability

2021-05-07 Thread Randy Dunlap
On 5/7/21 10:52 AM, Ville Syrjälä wrote: > On Fri, May 07, 2021 at 10:49:02AM +0200, Werner Sembach wrote: >> Couples the decission between RGB and YCbCr420 mode and the check if the >> port clock can archive the required frequency. Other checks and >> configuration steps that where previously

Re: [Intel-gfx] [PATCH] drm: i915: fix build when ACPI is disabled and BACKLIGHT=m

2021-04-27 Thread Randy Dunlap
On 4/27/21 1:03 AM, Jani Nikula wrote: > On Mon, 26 Apr 2021, Randy Dunlap wrote: >> When CONFIG_DRM_I915=y, CONFIG_ACPI is not set, and >> CONFIG_BACKLIGHT_CLASS_DEVICE=m, not due to I915 config, >> there are build errors trying to reference backlight_device_{un}regis

Re: [Intel-gfx] [PATCH 01/12] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-04-26 Thread Randy Dunlap
On 4/26/21 11:26 AM, Jason Gunthorpe wrote: > On Fri, Apr 23, 2021 at 05:08:10PM -0700, Randy Dunlap wrote: >> On 4/23/21 4:02 PM, Jason Gunthorpe wrote: >>> @@ -171,7 +171,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB >>> >>> config SAMPLE_VFIO_MDEV_MBOCHS >&

[Intel-gfx] [PATCH] drm: i915: fix build when ACPI is disabled and BACKLIGHT=m

2021-04-26 Thread Randy Dunlap
`intel_backlight_device_unregister': intel_panel.c:(.text+0x2f93): undefined reference to `backlight_device_unregister' Fixes: 912e8b12eedb ("drm/i915: register backlight device also when backlight class is a module") Fixes: 44c1220a441c ("drm/i915: extract intel_panel.h from intel_drv.h") Signed-off-

Re: [Intel-gfx] [PATCH 01/12] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE

2021-04-23 Thread Randy Dunlap
On 4/23/21 4:02 PM, Jason Gunthorpe wrote: > @@ -171,7 +171,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB > > config SAMPLE_VFIO_MDEV_MBOCHS > tristate "Build VFIO mdpy example mediated device sample code -- > loadable modules only" You can drop the ending of the prompt string. > - depends

Re: [Intel-gfx] [PATCH] drm/i915/gt: A typo fix

2021-03-18 Thread Randy Dunlap
On 3/18/21 3:19 AM, Bhaskar Chowdhury wrote: > > s/bariers/barriers/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [Intel-gfx] [PATCH] gpu: drm: i915: gt: Rudimentary typo fix in the file intel_timeline.c

2021-03-13 Thread Randy Dunlap
On 3/13/21 8:43 PM, Bhaskar Chowdhury wrote: > > s/bariers/barriers/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [Intel-gfx] [PATCH] drivers: gnu: drm: i915: gvt: Fixed couple of spellings in the file gtt.c

2021-02-22 Thread Randy Dunlap
On 2/22/21 6:21 AM, Randy Dunlap wrote: > On 2/22/21 12:18 AM, Bhaskar Chowdhury wrote: >> >> s/negtive/negative/ >> s/possilbe/possible/ >> >> Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap except the Subject has a typo in it. s/gnu/gpu/ &g

Re: [Intel-gfx] [PATCH] drivers: gnu: drm: i915: gvt: Fixed couple of spellings in the file gtt.c

2021-02-22 Thread Randy Dunlap
On 2/22/21 12:18 AM, Bhaskar Chowdhury wrote: > > s/negtive/negative/ > s/possilbe/possible/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > dif

Re: [Intel-gfx] [PATCH 01/30] drm/dp: Rewrap kdocs for struct drm_dp_aux

2021-02-19 Thread Randy Dunlap
On 2/19/21 1:52 PM, Lyude Paul wrote: > Since we're about to be adding some more fields and update this > documentation, let's rewrap it to the new column limit of 100 beforehand. > No actual doc or functional changes are made here. > The preferred column limit is still 80. For some (exceptional)

Re: [Intel-gfx] [PATCH 02/30] drm/dp: Fixup kernel docs for struct drm_dp_aux

2021-02-19 Thread Randy Dunlap
nt values with % so they're formatted > correctly > > Signed-off-by: Lyude Paul Acked-by: Randy Dunlap Thanks. > --- > include/drm/drm_dp_helper.h | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > -- ~Randy ___

Re: [Intel-gfx] linux-next: Tree for Feb 11 (drivers/gpu/drm/i915/display/intel_panel.o)

2021-02-11 Thread Randy Dunlap
r time can be seen at > http://neuling.org/linux-next-size.html . > > Status of my local build tests will be at > http://kisskb.ellerman.id.au/linux-next . If maintainers want to give > advice about cross compilers/configs that work, we are always open to add > more build

Re: [Intel-gfx] linux-next: Tree for Feb 4 (gpu/drm/i915/)

2021-02-04 Thread Randy Dunlap
wbinvd_on_all_cpus’; did you mean ‘wrmsr_on_cpus’? [-Werror=implicit-function-declaration] wbinvd_on_all_cpus(); Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap config-r7644.gz Description: application/gzip ___

Re: [Intel-gfx] linux-next: Tree for Feb 1 (drivers/gpu/drm/i915/i915_gem.c)

2021-02-01 Thread Randy Dunlap
_on_all_cpus’; did you mean ‘wrmsr_on_cpus’? [-Werror=implicit-function-declaration] wbinvd_on_all_cpus(); Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap config-r7539.gz Description: application/gzip ___ Intel-gfx mailin

Re: [Intel-gfx] linux-next: Tree for Jan 27 (drm/i915)

2021-01-27 Thread Randy Dunlap
On 1/27/21 11:30 AM, Randy Dunlap wrote: > On 1/27/21 11:08 AM, Randy Dunlap wrote: >> On 1/27/21 6:44 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Note: the patch file has failed to upload :-( >>> >>> Changes since 20210125: >>

Re: [Intel-gfx] mmotm 2021-01-25-21-18 uploaded (drm/i915/Kconfig.debug)

2021-01-27 Thread Randy Dunlap
IG_COMPILE_TEST=y: WARNING: unmet direct dependencies detected for DRM_I915_WERROR Depends on [n]: HAS_IOMEM [=y] && DRM_I915 [=m] && EXPERT [=y] && !COMPILE_TEST [=y] Selected by [m]: - DRM_I915_DEBUG [=y] && HAS_IOMEM [=y] && EXPERT [=y] && D

Re: [Intel-gfx] linux-next: Tree for Jan 27 (drm/i915)

2021-01-27 Thread Randy Dunlap
On 1/27/21 11:08 AM, Randy Dunlap wrote: > On 1/27/21 6:44 AM, Stephen Rothwell wrote: >> Hi all, >> >> Note: the patch file has failed to upload :-( >> >> Changes since 20210125: >> > > on x86_64: > > ../drivers/gpu/drm/i915/i915_gem.c: In fu

Re: [Intel-gfx] linux-next: Tree for Jan 27 (drm/i915)

2021-01-27 Thread Randy Dunlap
plicit declaration of function ‘wbinvd_on_all_cpus’; did you mean ‘wrmsr_on_cpus’? [-Werror=implicit-function-declaration] wbinvd_on_all_cpus(); -- ~Randy Reported-by: Randy Dunlap ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lis

Re: [Intel-gfx] linux-next: Tree for Jan 22 (drm/i915)

2021-01-22 Thread Randy Dunlap
bug > fix patches pending for the current merge release). > > Stats about the size of the tree over time can be seen at > http://neuling.org/linux-next-size.html . > > Status of my local build tests will be at > http://kisskb.ellerman.id.au/linux-next . If maintainers want to

Re: [Intel-gfx] linux-next: Tree for Dec 18 (drm/i915/display/intel_panel)

2020-12-18 Thread Randy Dunlap
el_backlight_device_unregister': intel_panel.c:(.text+0x2fc8): undefined reference to `backlight_device_unregister' CONFIG_BACKLIGHT_CLASS_DEVICE=m CONFIG_DRM_I915=y Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap config-r6825.xz Description: application/xz ___

Re: [Intel-gfx] [PATCH 2/3] mm: Extract might_alloc() debug check

2020-11-20 Thread Randy Dunlap
Hi, On 11/20/20 1:54 AM, Daniel Vetter wrote: > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > index d5ece7a9a403..f94405d43fd1 100644 > --- a/include/linux/sched/mm.h > +++ b/include/linux/sched/mm.h > @@ -180,6 +180,22 @@ static inline void fs_reclaim_acquire(gfp_t gfp_mask)

Re: [Intel-gfx] [PATCH] drm/modes: Switch to 64bit maths to avoid integer overflow

2020-10-23 Thread Randy Dunlap
On 10/22/20 12:42 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > The new >8k CEA modes have dotclocks reaching 5.94 GHz, which > means our clock*1000 will now overflow the 32bit unsigned > integer. Switch to 64bit maths to avoid it. > > Cc: sta...@vger.kernel.org >

[Intel-gfx] drm_modes: signed integer overflow

2020-10-21 Thread Randy Dunlap
+0x10e/0x116 [0.561078] ? kthread_parkme+0x1c/0x1c [0.561083] ret_from_fork+0x22/0x30 [0.561087] -- ~Randy Reported-by: Randy Dunlap ___ Intel-gfx mailing list

Re: [Intel-gfx] linux-next: Tree for Feb 28 (gpu/drm/i915/display/intel_display.c)

2020-02-27 Thread Randy Dunlap
m transcoder cpu_transcoder) ^~ Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap # # Automatically generated file; DO NOT EDIT. # Linux/i386 5.6.0-rc3 Kernel Configuration # # # Compiler: gcc (SUSE Linux) 7.5.0 # CONFIG_CC_IS_GCC=y CONFIG_GCC_VERSION=70500 CONFIG_CLA

Re: [Intel-gfx] [PATCH] drm/i915: Minimize uaccess exposure in i915_gem_execbuffer2_ioctl()

2020-02-27 Thread Randy Dunlap
functions as __always_inline is the other > option. The problem is, if you keep doing it, eventually you end up > with __always_inline-itis spreading all over the place. And it affects > all the other callers, at least in the CONFIG_CC_OPTIMIZE_FOR_SIZE case. > At least this fix is localized. > > But I agree my patch isn't ideal either. fwiw, Acked-by: Randy Dunlap # build-tested thanks. -- ~Randy ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV

2020-02-21 Thread Randy Dunlap
On 2/21/20 9:49 PM, Masahiro Yamada wrote: > On Sat, Feb 22, 2020 at 2:25 PM Randy Dunlap wrote: >> >> On 2/21/20 8:53 PM, Masahiro Yamada wrote: >>> On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada >>> wrote: >>>> >>>> Hi Jani, >

Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV

2020-02-21 Thread Randy Dunlap
On 2/21/20 8:53 PM, Masahiro Yamada wrote: > On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada wrote: >> >> Hi Jani, >> >> On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula wrote: >>> >>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix >>> appended is writable. This is not the

Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV

2020-02-21 Thread Randy Dunlap
.org/r/d8112767-4089-4c58-d7d3-2ce031398...@infradead.org > Reported-by: Randy Dunlap > Fixes: c6d4a099a240 ("drm/i915: reimplement header test feature") > Cc: Masahiro Yamada > Signed-off-by: Jani Nikula Acked-by: Randy Dunlap # build-tested Thanks. > --- >

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-16 Thread Randy Dunlap
On 12/16/19 9:42 PM, Sam Ravnborg wrote: > Hi Randy. > > On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote: >> On 12/15/19 9:22 PM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20191213: >>> >> >>

Re: [Intel-gfx] linux-next: Tree for Dec 16 (drm_panel & intel_panel)

2019-12-16 Thread Randy Dunlap
e_unregister' CONFIG_DRM_PANEL=y CONFIG_BACKLIGHT_CLASS_DEVICE=m CONFIG_DRM_I915=y Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap # # Automatically generated file; DO NOT EDIT. # Linux/x86_64 5.5.0-rc2 Kernel Configuration # # # Compiler: gcc (SUSE Linux) 7.4.1 20190905 [

Re: [Intel-gfx] linux-next: Tree for Nov 19 (i915)

2019-11-20 Thread Randy Dunlap
On 11/20/19 8:56 AM, Chris Wilson wrote: > Quoting Jani Nikula (2019-11-20 16:15:08) >> On Tue, 19 Nov 2019, Randy Dunlap wrote: >>> On 11/19/19 12:46 AM, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20191118: >>

Re: [Intel-gfx] linux-next: Tree for Nov 19 (i915)

2019-11-19 Thread Randy Dunlap
On 11/19/19 12:46 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20191118: on x86_64: ERROR: "pm_suspend_target_state" [drivers/gpu/drm/i915/i915.ko] undefined! # CONFIG_SUSPEND is not set -- ~Randy Reported-by: Randy Dunlap __

Re: [Intel-gfx] [PATCH V13 4/6] mdev: introduce mediated virtio bus

2019-11-18 Thread Randy Dunlap
Provides > + either kenrel driver or userspace driver. kernel > + > + If you don't know what do here, say N. All of these lines should be indented with one tab, not spaces. -- ~Randy Reported-by: Randy Dunlap

Re: [Intel-gfx] [PATCH V13 3/6] mdev: move to drivers/

2019-11-18 Thread Randy Dunlap
On 11/18/19 2:59 AM, Jason Wang wrote: > diff --git a/drivers/mdev/Kconfig b/drivers/mdev/Kconfig > new file mode 100644 > index ..4561f2d4178f > --- /dev/null > +++ b/drivers/mdev/Kconfig > @@ -0,0 +1,19 @@ > + > +config MDEV > + tristate "Mediated device driver framework" > +

Re: [Intel-gfx] [PATCH V13 1/6] mdev: make mdev bus agnostic

2019-11-18 Thread Randy Dunlap
On 11/18/19 2:59 AM, Jason Wang wrote: > diff --git a/drivers/vfio/mdev/Kconfig b/drivers/vfio/mdev/Kconfig > index 5da27f2100f9..2e07ca915a96 100644 > --- a/drivers/vfio/mdev/Kconfig > +++ b/drivers/vfio/mdev/Kconfig > @@ -1,15 +1,24 @@ > -# SPDX-License-Identifier: GPL-2.0-only > > -config

Re: [Intel-gfx] [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-11-06 Thread Randy Dunlap
On 11/5/19 11:05 PM, Jason Wang wrote: > diff --git a/samples/Kconfig b/samples/Kconfig > index c8dacb4dda80..13a2443e18e0 100644 > --- a/samples/Kconfig > +++ b/samples/Kconfig > @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY > mediated device. It is a simple framebuffer and supports

Re: [Intel-gfx] mmotm 2019-08-24-16-02 uploaded (intel_drv.h header check)

2019-08-27 Thread Randy Dunlap
On 8/24/19 4:03 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2019-08-24-16-02 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my

Re: [Intel-gfx] linux-next: Tree for Aug 21 (gpu/drm/i915/)

2019-08-21 Thread Randy Dunlap
On 8/21/19 1:49 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190820: > on x86_64: ../drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘ggtt_restore_mappings’: ../drivers/gpu/drm/i915/i915_gem_gtt.c::3: error: implicit declaration of function ‘wbinvd_on_all_cpus’; did you

Re: [Intel-gfx] Linux Kernel 5.2.8 (uvc or i915? <<<)

2019-08-15 Thread Randy Dunlap
[adding mailing lists etc. with Nathaniel's test info] On 8/15/19 7:21 PM, Nathaniel Russell wrote: > Well i surpressed the uvcvideo driver and you are right Randy it > definitely is not the uvcvideo driver. There is something going on in > the i915 driver. > > > On 8/1

Re: [Intel-gfx] Linux Kernel 5.2.8 (uvc or i915?)

2019-08-15 Thread Randy Dunlap
On 8/15/19 6:15 PM, Nathaniel Russell wrote: > I would really like help with the kernel error with my uvcvideo driver. > Hi again. What makes you think that the problem is related to the uvcvideo driver? Does some previous kernel version work correctly? If so, what version(s)? Does this

Re: [Intel-gfx] Linux Kernel 5.1.21 (i915)

2019-08-04 Thread Randy Dunlap
On 8/4/19 8:11 PM, Nathaniel Russell wrote: > I'm getting an error message when the uvcvideo module is loaded into > the kernel. Can somebody help me figure this out please? > Looks more like it is related to i915 driver: [ 18.728238] [ cut here ] [ 18.728248] timed

Re: [Intel-gfx] [PATCH v3 2/7] lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer

2019-06-17 Thread Randy Dunlap
Hi, Just a comment style nit below... On 6/16/19 7:04 PM, Alastair D'Silva wrote: > From: Alastair D'Silva > > This patch removes the hardcoded row limits and allows for > other lengths. These lengths must still be a multiple of > groupsize. > > This allows structs that are not 16/32 bytes to

Re: [Intel-gfx] [PATCH v2 3/7] lib/hexdump.c: Optionally suppress lines of repeated bytes

2019-05-08 Thread Randy Dunlap
On 5/8/19 12:01 AM, Alastair D'Silva wrote: > From: Alastair D'Silva > > Some buffers may only be partially filled with useful data, while the rest > is padded (typically with 0x00 or 0xff). > > This patch introduces a flag to allow the supression of lines of repeated > bytes, which are

Re: [Intel-gfx] linux-next: Tree for Mar 29 (i915, no ACPI)

2019-03-29 Thread Randy Dunlap
On 3/28/19 8:18 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190328: > > The pidfd tree lost its build failures. > on x86_64, when # CONFIG_ACPI is not set/enabled: ld: drivers/gpu/drm/i915/intel_panel.o: in function `intel_backlight_device_register':

Re: [Intel-gfx] [PATCH] drm/i915: Use __is_constexpr()

2019-03-20 Thread Randy Dunlap
7:27: error: first argument to > ‘__builtin_choose_expr’ not a constant > ../include/linux/build_bug.h:16:45: error: bit-field ‘’ width not > an integer constant > > Reported-by: Randy Dunlap > Fixes: baa09e7d2f42 ("drm/i915: use REG_FIELD_PREP() to define register > bit

Re: [Intel-gfx] [PATCH 1/4] component: Add documentation

2019-02-17 Thread Randy Dunlap
On 2/7/19 3:27 PM, Daniel Vetter wrote: Hi Daniel, I have a few possible changes for this documentation (see below). > --- > Documentation/driver-api/component.rst | 17 > Documentation/driver-api/device_link.rst | 3 + > Documentation/driver-api/index.rst | 1 + >

Re: [Intel-gfx] [PATCH] drm/i915: Fixup stub definitions for intel_opregion_suspend|resume

2018-11-29 Thread Randy Dunlap
gion_resume'; > drivers/gpu/drm/i915/i915_drv.o:i915_drv.c:(.text+0x2d40): first defined > here > > Reported-by: Randy Dunlap > Reported-by: Stephen Rothwell > Fixes: a950adc6c343 ("drm/i915: Stop calling intel_opregion > unregister/register in suspend/resume"

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-16 Thread Randy Dunlap
On 07/16/2018 01:11 AM, Andy Shevchenko wrote: > On Fri, 2018-07-13 at 16:42 -0700, Randy Dunlap wrote: >> On 07/13/2018 04:37 PM, NeilBrown wrote: > >> >> coding-style.rst says: >> Also, use braces when a loop contains more than a single simple >> statement: &

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-13 Thread Randy Dunlap
On 07/13/2018 04:37 PM, NeilBrown wrote: > On Wed, Jul 11 2018, Andrew Morton wrote: > >> On Wed, 11 Jul 2018 13:51:08 +0200 Daniel Vetter wrote: >> >>> But I still have the situation that a bunch of maintainers acked this >>> and Andrew Morton defacto nacked it, which I guess means I'll keep

  1   2   >