Re: [Intel-gfx] [PATCH 10/10] Revert "drm: crc: Wait for a frame before returning from open()"

crtc, NULL); err: spin_lock_irq(>lock); crtc_crc_cleanup(crc); Adding Tomeu Vizoso to the cc. Can you resend the series, and add dri-de...@lists.freedesktop.org and the driver maintainers to the cc? You'll need to get acks from the maintainers to merge this through d

Re: [Intel-gfx] [RFC PATCH 01/60] hyper_dmabuf: initial working version of hyper_dmabuf drv

On 26 December 2017 at 19:19, Matt Roper wrote: > On Wed, Dec 20, 2017 at 10:59:57AM +0100, Daniel Vetter wrote: >> On Tue, Dec 19, 2017 at 03:27:31PM -0800, Dongwon Kim wrote: >> > I forgot to include this brief information about this patch series. >> > >> > This patch

Re: [Intel-gfx] [PATCH] drm/crc: Handle opening and closing crc better

Looks good to me: Reviewed-by: Tomeu Vizoso <tomeu.viz...@collabora.com> I guess you have tested this with IGT? In any case, I think it would be good to mention how a patch has been tested in the changelog. That can be very useful to others if things go wrong at some point. Thanks,

Re: [Intel-gfx] [PATCH 03/16] drm: document driver interface for CRC capturing

Thanks for doing this. Reviewed-by: Tomeu Vizoso <tomeu.viz...@collabora.com> On 22 March 2017 at 09:36, Daniel Vetter <daniel.vet...@ffwll.ch> wrote: > This was missed in Tomeu's patch. Also remove the kerneldoc for the > internal function, we don't document that in

[Intel-gfx] [PATCH i-g-t v3 1/2] lib: Open debugfs files for the given DRM device

was missed previously - use the minor of the device for the debugfs path, not the major - have a proper exit handler for calling igt_hpd_storm_reset with the right device fd. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Robert Foss <robert.f...@coll

[Intel-gfx] [PATCH i-g-t v3 2/2] kms_pipe_crc_basic: Skip sequence tests if the source doesn't provide frame numbers

Some frame sources such as sinks aren't able to provide meaningful frame numbers, so in those cases just skip the TEST_SEQUENCE tests. v2: Rebased Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_pipe_crc_basic.c | 28 ++-- 1 file chang

[Intel-gfx] [PATCH i-g-t 1/2] lib: Open debugfs files for the given DRM device

When opening a DRM debugfs file, locate the right path based on the given DRM device FD. This is needed so, in setups with more than one DRM device, any operations on debugfs files affect the expected DRM device. v2: rebased and fixed new API additions Signed-off-by: Tomeu Vizoso <tomeu.

[Intel-gfx] [PATCH i-g-t 2/2] kms_pipe_crc_basic: Skip sequence tests if the source doesn't provide frame numbers

Some frame sources such as sinks aren't able to provide meaningful frame numbers, so in those cases just skip the TEST_SEQUENCE tests. v2: Rebased Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_pipe_crc_basic.c | 28 ++-- 1 file chang

[Intel-gfx] [PATCH i-g-t 2/2] kms_pipe_crc_basic: Skip sequence tests if the source doesn't provide frame numbers

Some frame sources such as sinks aren't able to provide meaningful frame numbers, so in those cases just skip the TEST_SEQUENCE tests. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_pipe_crc_basic.c | 29 +++-- 1 file changed, 23 insertions

[Intel-gfx] [PATCH i-g-t 1/2] lib: Open debugfs files for the given DRM device

When opening a DRM debugfs file, locate the right path based on the given DRM device FD. This is needed so, in setups with more than one DRM device, any operations on debugfs files affect the expected DRM device. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- Guess we

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Remove i915ism when checking that debugfs is mounted

On 2 March 2017 at 14:46, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Mar 02, 2017 at 02:39:16PM +0100, Tomeu Vizoso wrote: >> On 2 March 2017 at 11:12, Chris Wilson <ch...@chris-wilson.co.uk> wrote: >> > On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tom

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Remove i915ism when checking that debugfs is mounted

On 2 March 2017 at 11:12, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Mar 02, 2017 at 11:08:25AM +0100, Tomeu Vizoso wrote: >> Instead of checking for "i915_error_state" within dri/N/, check for >> "name". >> >> This allows more t

[Intel-gfx] [PATCH i-g-t 2/2] kms_pipe_crc_basic: Skip sequence tests if the source doesn't provide frame numbers

Some frame sources such as sinks aren't able to provide meaningful frame numbers, so in those cases just skip the TEST_SEQUENCE tests. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_pipe_crc_basic.c | 29 +++-- 1 file changed, 23 insertions

[Intel-gfx] [PATCH i-g-t 1/2] lib: Remove i915ism when checking that debugfs is mounted

Instead of checking for "i915_error_state" within dri/N/, check for "name". This allows more tests to run against drivers other than i915. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[Intel-gfx] [PATCH] drm/edid: Add EDID_QUIRK_FORCE_8BPC quirk for Rotel RSX-1058

?id=99869 Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 24e7b282f16c..d994ccf94f88 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gp

Re: [Intel-gfx] [PATCH i-g-t] lib: Add basic support for valgrind annotations.

Patch looks good to me, but I think the signal changes should be in their own commit. On 7 February 2017 at 16:12, Maarten Lankhorst wrote: ... > +#define VG(x) x > +#else > +#define VG(x) > +#endif Wouldn't be better to stub VALGRIND_MAKE_MEM_DEFINED instead?

[Intel-gfx] [PATCH i-g-t] kms_flip: Calculate max acceptable delta for TEST_TS_CONT

and calculates an acceptable difference taking into account the vertical refresh rate of the current mode. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> References: https://bugs.freedesktop.org/show_bug.cgi?id=98289 --- tests/kms_flip.c | 16 1 file changed, 12 inse

Re: [Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines

On 10 January 2017 at 17:31, Daniel Vetter <dan...@ffwll.ch> wrote: > On Tue, Jan 10, 2017 at 05:54:57PM +0200, Ville Syrjälä wrote: >> On Tue, Jan 10, 2017 at 02:43:05PM +0100, Tomeu Vizoso wrote: >> > Use drm_accurate_vblank_count so we have the full 32 bit to represen

[Intel-gfx] [RESEND PATCH v14 2/2] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Reviewe

[Intel-gfx] [RESEND PATCH v14 1/2] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). v15: - Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Review

[Intel-gfx] [RESEND PATCH v14 0/2] New debugfs API for capturing CRC of frames

Hi, here are the last two patches that remain to be merged in this series, rebased on today's drm-tip. Thanks, Tomeu Tomeu Vizoso (2): drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/i915/i915_drv.h | 1 + drive

[Intel-gfx] [PATCH i-g-t] lib: Make sure we don't use a negative offset

As bytes_read can contain an error condition under some circumstances, in which we want to error out. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index d82868

[Intel-gfx] [PATCH v14 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> Reviewe

[Intel-gfx] [PATCH v14 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil

[Intel-gfx] [PATCH v14 0/4] New debugfs API for capturing CRC of frames

could be dropped if it's preferred that userspace waits for the first frame CRC to come before assuming that the HW is ready. The other patches are unchanged. Thanks, Tomeu Tomeu Vizoso (4): drm: Move locking into drm_debugfs_crtc_crc_add drm: crc: Wait for a frame before returning from

Re: [Intel-gfx] [PATCH 01/17] drm/docs: Small cleanup in drm-uapi.rst

the split-up. >> >> - Collect all the testing stuff together and give the CRC >> section a heading for prettier output. >> >> Cc: Tomeu Vizoso <tomeu.viz...@collabora.com> >> Cc: Jani Nikula <jani.nik...@intel.com> >> Signed-off-by:

[Intel-gfx] [PATCH v13 2/3] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil

[Intel-gfx] [PATCH v13 3/3] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[Intel-gfx] [PATCH v13 0/3] New debugfs API for capturing CRC of frames

Hi, here are the patches that remain to be merged in this series. I have only rebased them since last time. Thanks, Tomeu Tomeu Vizoso (3): drm: Move locking into drm_debugfs_crtc_crc_add drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame

[Intel-gfx] [RESEND PATCH v12] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debug

[Intel-gfx] [PATCH] drm/edid: Don't print an error if the checksum of a CEA block is wrong

<ch...@chris-wilson.co.uk> Cc: Tomi Sarvela <tomi.p.sarv...@intel.com> Cc: intel-gfx@lists.freedesktop.org Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- drivers/gpu/drm/drm_edid.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git

Re: [Intel-gfx] [RFC i-g-t v3 5/5] Add support for hotplug testing with the Chamelium

On 7 December 2016 at 20:56, Lyude Paul <ly...@redhat.com> wrote: > On Wed, 2016-12-07 at 12:27 +0100, Tomeu Vizoso wrote: >> On 1 December 2016 at 02:24, Lyude <ly...@redhat.com> wrote: (big snip) >> > + * By default, this file is expected to exi

Re: [Intel-gfx] [RFC i-g-t v3 5/5] Add support for hotplug testing with the Chamelium

Hi Lyude, this looks very good. Some minor comments below. Regards, Tomeu On 1 December 2016 at 02:24, Lyude wrote: > For the purpose of testing things such as hotplugging and bad monitors, > the ChromeOS team ended up designing a neat little device known as the > Chamelium.

Re: [Intel-gfx] [PATCH i-g-t 1/3] igt_kms: Don't assume we have cursor planes if we have primary ones

On 21 November 2016 at 23:32, Lyude wrote: > On certain models of nvidia and AMD GPUs, we can have a primary plane > without any DRM plane for the cursor plane. Check for this so we don't > segfault on non-intel hardware. > > Signed-off-by: Lyude > --- >

Re: [Intel-gfx] [PATCH i-g-t 2/3] igt_kms: Change the max number of pipes to 6

On 21 November 2016 at 23:32, Lyude wrote: > Unfortunately the assumption that we only have 6 display pipes available > is specific to Intel, and seems to be breaking igt_display_init() on > both radeon and nouveau since this causes us not to leave enough space > in the

[Intel-gfx] [PATCH i-g-t] lib: Use igt_assert_eq in CHECK_RETURN

So that debug logs contain the unexpected value. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 989704e14803..1e30ddcc5373 100644 --- a/lib/igt_kms.c +++

[Intel-gfx] [PATCH i-g-t v1] tests/kms_ccs: Add test for render compression

Add a few subtests that check that lossless compressed render targets are properly displayed. Also test a few error conditions. Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Ben Widawsky <b...@bwidawsk.net> Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> ---

Re: [Intel-gfx] [PATCH i-g-t v9 00/21] Implement sw_sync test

This series has my Reviewed-by tag with the small issues I pointed out addressed. But I think it would be very good if you could go through all the igt_assert* calls and make sure that no information is being lost that could aid in triaging and debugging. The messages you chose for igt_assert_f

Re: [Intel-gfx] [PATCH i-g-t v9 09/21] tests/sw_sync: Add subtest test_sync_multi_consumer

On 22 November 2016 at 14:28, wrote: > From: Robert Foss > > This subtest verifies the access ordering of multiple consumer threads. > > Signed-off-by: Robert Foss > Reviewed-by: Eric Engestrom

Re: [Intel-gfx] [PATCH i-g-t v9 01/21] lib/sw_sync: Add helper functions for managing synchronization primitives

Hi Robert, looks pretty good to me, have just found a few nits. With those addressed: Reviewed-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Regards, Tomeu On 22 November 2016 at 14:28, <robert.f...@collabora.com> wrote: > From: Robert Foss <robert.f...@collabora.com&g

[Intel-gfx] [PATCH i-g-t v4] lib/debugfs: Support new generic ABI for CRC capture

The kernel has now a new debugfs ABI that can also allow capturing frame CRCs for drivers other than i915. Add alternative codepaths so the new ABI is used if the kernel is recent enough, and fall back to the legacy ABI if not. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> -

[Intel-gfx] [RESEND PATCH v12 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debug

[Intel-gfx] [RESEND PATCH v12 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil

[Intel-gfx] [RESEND PATCH v12 0/4] New debugfs API for capturing CRC of frames

Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Move locking into drm_debugfs_crtc_crc_add drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/drm_debugfs_crc.c |9 +- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [RESEND PATCH v12 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[Intel-gfx] [PATCH i-g-t 1/2] lib: Check format of framebuffer before SetPlane

with just one overlay. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_kms.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 989704e14803..3234fa1bbdc4 100644 --- a/lib/igt_kms.c +++ b/lib/igt

[Intel-gfx] [PATCH i-g-t 0/2] Improve error report when there are less overlays than expected

(printing the supported formats), and skip the test if there aren't enough overlay planes. Thanks, Tomeu Tomeu Vizoso (2): lib: Check format of framebuffer before SetPlane kms_plane_scaling: Skip if we don't have enough overlays lib/igt_kms.c | 35

[Intel-gfx] [PATCH i-g-t 2/2] kms_plane_scaling: Skip if we don't have enough overlays

The test currently assumes that there are two overlay planes available, but that's not generally true and from the error that returns the kernel, it isn't obvious what's going on. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- tests/kms_plane_scaling.c | 4 1 file chan

Re: [Intel-gfx] [i-g-t PATCH v8 4/5] igt/kms_flip: Use new igt_spin_batch

.uk> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Signed-off-by: Abdiel Janulgue <abdiel.janul...@linux.intel.com> > --- > tests/kms_flip.c | 212 > +++ > 1 file changed, 26 insertions(+), 186 deletions(-)

Re: [Intel-gfx] [i-g-t PATCH v8 5/5] igt/kms_busy.c: Use new igt_spin_batch

Looks good to me. Reviewed-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cheers, Tomeu On 21 November 2016 at 10:25, Abdiel Janulgue <abdiel.janul...@linux.intel.com> wrote: > v7: Adapt to api rename > v8: Tidy up finish_fb_busy (Chris Wilson) > > Cc: Chris Wilson &

Re: [Intel-gfx] [i-g-t PATCH v9 1/3] igt/gem_wait: Use new igt_spin_batch

away > > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Cc: Tomeu Vizoso <to...@tomeuvizoso.net> > Signed-off-by: Abdiel Janulgue <abdiel.janul...@linux.intel.com> > --- > tests/gem_wait.c | 126 > --

Re: [Intel-gfx] [i-g-t PATCH v9 2/5] lib: add igt_dummyload

t global use of batch, reuse defines > Minor code cleanups. > Rename igt_spin_batch and igt_post_spin_batch to > igt_spin_batch_new and igt_spin_batch_free > respectively (Tomeu Vizoso). > Fix error in dependency relocation handling in HSW causing >

Re: [Intel-gfx] [i-g-t PATCH v7 1/5] lib: Make signal helper definitions reusable

On 21 November 2016 at 10:25, Abdiel Janulgue wrote: > More and more test-cases are using this. > > Signed-off-by: Abdiel Janulgue > --- > lib/igt_aux.c | 11 --- > lib/igt_aux.h | 10 ++ >

Re: [Intel-gfx] [i-g-t PATCH v8 3/5] igt/gem_wait: Use new igt_spin_batch

On 21 November 2016 at 10:25, Abdiel Janulgue wrote: > v7: Adapt to api rename > v8: Restore sanitycheck wait on the recursive batch and > avoid using C99 locals (Chris Wilson) > > Cc: Chris Wilson > Cc: Daniel Vetter

[Intel-gfx] [PATCH i-g-t v3] lib/debugfs: Support new generic ABI for CRC capture

The kernel has now a new debugfs ABI that can also allow capturing frame CRCs for drivers other than i915. Add alternative codepaths so the new ABI is used if the kernel is recent enough, and fall back to the legacy ABI if not. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> ---

[Intel-gfx] [PATCH v12 0/4] New debugfs API for capturing CRC of frames

Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Move locking into drm_debugfs_crtc_crc_add drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines drivers/gpu/drm/drm_debugfs_crc.c |9 +- drivers/gpu/drm/i915/Makefile

[Intel-gfx] [PATCH v12 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. v12: - Rebased. - Remove stub for intel_crtc_set_crc_source and instead set the callback to NULL (Jani Nikula). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil

[Intel-gfx] [PATCH v12 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. v12: Rebased. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debug

[Intel-gfx] [PATCH v12 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

On 16 November 2016 at 13:58, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Wed, 16 Nov 2016, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote: >> On 15 November 2016 at 09:27, Jani Nikula <jani.nik...@linux.intel.com> >> wrote: >>> On Tue, 15

Re: [Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

On 15 November 2016 at 09:27, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Tue, 15 Nov 2016, David Weinehall <t...@kernel.org> wrote: >> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote: >>> On Thu, 06 Oct 2016, Tomeu Vizoso <tomeu.viz...@colla

Re: [Intel-gfx] [RFC i-g-t 0/4] intel-gpu-tools: Add support for the Chamelium

On 15 November 2016 at 22:44, Lyude Paul <ly...@redhat.com> wrote: > I'm fine with libsoup as well, I'll check it out and probably move all > of the code over to using that instead. Cool. > On Tue, 2016-11-15 at 12:44 +0100, Tomeu Vizoso wrote: >> On 11 November 2016 at

Re: [Intel-gfx] [RFC i-g-t 0/4] intel-gpu-tools: Add support for the Chamelium

vs. libsoup. I liked it mostly because we already depend on glib. > On Wed, 2016-11-09 at 16:09 +0100, Tomeu Vizoso wrote: >> Hi Lyude, >> >> I think this looks very good. >> >> On 8 November 2016 at 01:05, Lyude <ly...@redhat.com> wrote: >> > >

Re: [Intel-gfx] [i-g-t PATCH v6 1/4] lib: add igt_dummyload

On 15 November 2016 at 11:59, Tomeu Vizoso <to...@tomeuvizoso.net> wrote: > On 14 November 2016 at 19:24, Abdiel Janulgue > <abdiel.janul...@linux.intel.com> wrote: >> A lot of igt testcases need some GPU workload to make sure a race >> window is big enough. Unfor

Re: [Intel-gfx] [i-g-t PATCH v6 1/4] lib: add igt_dummyload

On 14 November 2016 at 19:24, Abdiel Janulgue wrote: > A lot of igt testcases need some GPU workload to make sure a race > window is big enough. Unfortunately having a fixed amount of > workload leads to spurious test failures or overtly long runtimes > on some

Re: [Intel-gfx] [i-g-t PATCH v6 4/4] igt/kms_busy.c: Use new igt_spin_batch

Hi Abdiel, here running the whole of kms_busy causes all subtests after the first one to be skipped due to: Test requirement not met in function __real_main164, file ../../intel-gpu-tools/tests/kms_busy.c:195: Test requirement: gem_has_ring(display.drm_fd, e->exec_id | e->flags) If I run the

[Intel-gfx] [PATCH i-g-t] lib: Pass I915_TILING_NONE if Yf or Ys

The kernel expects that BOs for framebuffers with I915_FORMAT_MOD_Yf_TILED will have I915_TILING_NONE. Fixes: 050c00d53f39 ("lib: Pass I915_TILING_Y to the kernel if Yf or Ys") Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> Signed-off-by: Tomeu Vizoso <tomeu.viz...@coll

Re: [Intel-gfx] [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions

On 11 November 2016 at 12:33, Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> wrote: > > On 11/11/2016 11:23, Tomeu Vizoso wrote: >> >> On 11/10/2016 05:23 PM, Tvrtko Ursulin wrote: >>> >>> >>> On 10/11/2016 13:17, Tomeu Vizoso wrote: >>&

Re: [Intel-gfx] [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions

On 11/10/2016 05:23 PM, Tvrtko Ursulin wrote: > > On 10/11/2016 13:17, Tomeu Vizoso wrote: >> On 1 November 2016 at 16:44, Tvrtko Ursulin <tursu...@ursulin.net> wrote: >>> >>> Hi, >>> >>> >>> >>> On 02/03/16 14:00, T

Re: [Intel-gfx] [i-g-t PATCH v1 08/14] lib: Add igt_create_bo_with_dimensions

On 1 November 2016 at 16:44, Tvrtko Ursulin <tursu...@ursulin.net> wrote: > > Hi, > > > > On 02/03/16 14:00, Tomeu Vizoso wrote: >> >> igt_create_bo_with_dimensions() is intended to abstract differences >> between drivers in buffer object creation. >&

[Intel-gfx] [PATCH i-g-t] lib: Rename tiling variables to modifier if that's what they contain

Though right now modifiers are only used to specify tiling, there are different constants for them and naming them differently should help with not mixing them. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/igt_fb.c

[Intel-gfx] [PATCH i-g-t] lib: Pass I915_TILING_Y to the kernel if Yf or Ys

GEM_SET_TILING doesn't care about Yf or Ys, so just pass Y. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --- lib/ioctl_wrappers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c index 95bc5e268bcd..eabf3ee3abe6 100644 ---

[Intel-gfx] [PATCH i-g-t] lib: Pass tiling constant where that's expected

We were passing in two places a framebuffer modifier constant instead of a tiling constant. Also adds igt_fb_mod_to_tiling so tests can do that by themselves. Cc: Tvrtko Ursulin <tursu...@ursulin.net> Fixes: 8a1a38661f56 ("lib: Add igt_create_bo_with_dimensions") Signed-off-

Re: [Intel-gfx] [RFC i-g-t 4/4] Add support for hotplug testing with the Chamelium

On 8 November 2016 at 01:05, Lyude wrote: > For the purpose of testing things such as hotplugging and bad monitors, > the ChromeOS team ended up designing a neat little device known as the > Chamelium. More information on this can be found here: > >

Re: [Intel-gfx] [RFC i-g-t 0/4] intel-gpu-tools: Add support for the Chamelium

Hi Lyude, I think this looks very good. On 8 November 2016 at 01:05, Lyude wrote: > > - While writing this patch series, I found that quite a few of the RPC calls >for chameleond don't work as expected. For instance, I have had absolutely >no luck getting CRCs from

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: Take DRIVER_ANY into account when opening the DRM device

On 27 October 2016 at 10:06, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Oct 27, 2016 at 09:58:19AM +0200, Tomeu Vizoso wrote: >> __drm_open_driver was changed to bail out on VGEM devices unless they >> are explicitly asked for (DRIVER_VGEM). But with that chan

[Intel-gfx] [PATCH i-g-t] lib/drmtest: Take DRIVER_ANY into account when opening the DRM device

__drm_open_driver was changed to bail out on VGEM devices unless they are explicitly asked for (DRIVER_VGEM). But with that change we lost support for DRIVER_ANY. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Fixes: 7ce63894854d ("lib: Support opening vGEM device") Cc:

[Intel-gfx] [PATCH v11 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[Intel-gfx] [PATCH v11 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i

[Intel-gfx] [PATCH v11 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +---

[Intel-gfx] [PATCH v11 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Sorry about that, but there was a dangling brace in v10 breaking the build so here is this v11. Thanks, Tomeu Tomeu Vizoso (4

[Intel-gfx] [PATCH v10 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[Intel-gfx] [PATCH v10 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +---

[Intel-gfx] [PATCH v10 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i

[Intel-gfx] [PATCH v10 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. In this v10 debugfs creation failures don't abort CRTC registration, as suggested by Emil Velikov. Thanks, Tomeu Tomeu Vizoso

[Intel-gfx] [PATCH v9 1/4] drm/i915/debugfs: Move out pipe CRC code

intel_display_crc_init accept a drm_i915_private instead. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/i915_debugfs.c | 886 +---

[Intel-gfx] [PATCH v9 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. v9: - Add stub for intel_crtc_set_crc_source. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i

[Intel-gfx] [PATCH v9 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[Intel-gfx] [PATCH v9 0/4] New debugfs API for capturing CRC of frames

callback (tested on Tegra124). Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915: Use new CRC debugfs API drm/i915: Put "cooked" vlank counters in frame CRC lines Documentation/gpu/drm-uapi.rst|6

[Intel-gfx] [PATCH v2] drm/i915: Fix build when !CONFIG_DEBUG_FS

Add stub for intel_crtc_set_crc_source() and fix arguments of intel_display_crc_init(). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code") Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API")

[Intel-gfx] [PATCH] drm/i915: Fix build when !CONFIG_DEBUG_FS

Add stub for intel_crtc_set_crc_source() and fix arguments of stub for intel_display_crc_init(). Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Fixes: 21165bd933ac ("drm/i915/debugfs: Move out pipe CRC code") Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API&q

[Intel-gfx] [PATCH i-g-t v3] lib/debugfs: Support new generic ABI for CRC capture

The kernel has now a new debugfs ABI that can also allow capturing frame CRCs for drivers other than i915. Add alternative codepaths so the new ABI is used if the kernel is recent enough, and fall back to the legacy ABI if not. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> ---

[Intel-gfx] [PATCH i-g-t v2] lib/debugfs: Support new generic ABI for CRC capture

The kernel has now a new debugfs ABI that can also allow capturing frame CRCs for drivers other than i915. Add alternative codepaths so the new ABI is used if the kernel is recent enough, and fall back to the legacy ABI if not. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> --

Re: [Intel-gfx] [PATCH] drm: Add frame CRC debugfs files only for drivers that have CRTC

> caused kernel oops. So, let's add CRC debugfs files > only for those drivers that do modeset. > > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> > Cc: Tomeu Vizoso <tomeu.viz...@collabora.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch>

Re: [Intel-gfx] [PATCH 2/2] kms_atomic: plane_primary: Allow modeset if atomic check returns -EINVAL

On 12 September 2016 at 09:11, Liu Ying wrote: > Allowing modeset may prevent the test case from failing in case the atomic > check phase finds the userspace doesn't allow modeset for the commit and > returns -EINVAL. A real case is to run the test case on imx-drm which >

[Intel-gfx] [PATCH v8 3/4] drm/i915: Use new CRC debugfs API

skip the 1st or 2nd frames. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_irq.c | 83 +-- drivers/gpu/drm/i

[Intel-gfx] [PATCH v8 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> --- dri

[Intel-gfx] [PATCH v8 1/4] drm/i915/debugfs: Move out pipe CRC code

In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. v6: Rebased. v7: Fix whitespace issue. Signed-off-by: Tomeu

[Intel-gfx] [PATCH v8 0/4] New debugfs API for capturing CRC of frames

for hardware that can provide frame CRCs (including eDP panels that support self-refresh) can easily implement the new callback and provide userspace with the CRC values. Thanks, Tomeu Tomeu Vizoso (4): drm/i915/debugfs: Move out pipe CRC code drm: Add API for capturing frame CRCs drm/i915

Re: [Intel-gfx] [PATCH v6 3/4] drm/i915: Use new CRC debugfs API

On 8 September 2016 at 15:35, Emil Velikov <emil.l.veli...@gmail.com> wrote: > Hi Tomeu, > > Just a couple of nitpicks. Nothing that has to be fixed or (if you > agree) cannot be done on top/later on. > > On 7 September 2016 at 11:27, Tomeu Vizoso <tomeu.viz...@collab

  1   2   3   >