Re: [Intel-gfx] [PATCH 05/40] drm/i915: Don't disable PPGTT for CHV based in PCI rev

2014-07-11 Thread Deepak S
; } Reviewed-by: Deepak S deepa...@linux.intel.com ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-10 Thread Deepak S
On Thursday 10 July 2014 11:58 AM, Daniel Vetter wrote: On Fri, Jul 11, 2014 at 09:56:35AM +0530, Deepak S wrote: On Wednesday 09 July 2014 05:33 PM, Daniel Vetter wrote: On Thu, Jul 10, 2014 at 01:16:23PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Since

[Intel-gfx] [PATCH 2/7] drm/i915: Add RP0/RP1/RPn render P state thresholds in VLV sysfs

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com This is useful for userspace utilities to verify and micromanaging the increase/decrease frequncy. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_sysfs.c | 18 +++--- 1 file changed, 15 insertions(+), 3

[Intel-gfx] [PATCH 0/7] Enable RP1/RPn/RP0 sysfs and enable CHV PM interrupt

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Enable RP1/RPn/RP0 sysfs and enable CHV PM interrupt for verifying the freq on VLV and CHV Deepak S (7): drm/i915: Read guaranteed freq for valleyview drm/i915: Add RP0/RP1/RPn render P state thresholds in VLV sysfs drm/i915: keep freq/opcode

[Intel-gfx] [PATCH 4/7] drm/i915: populate mem_freq/cz_clock for chv

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com We need mem_freq or cz clock for freq/opcode conversion Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 6 ++ drivers/gpu/drm/i915/intel_pm.c | 29

[Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Since freq/encode conversion formula changes from platform to platform, create a generic wrapper function and having platform check inside this help to simpilfy adding newer platform freq/opcode conversion. Signed-off-by: Deepak S deepa...@linux.intel.com

[Intel-gfx] [PATCH 6/7] drm/i915/chv: Add basic PM interrupt support for CHV

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Enabled PM interrupt programming for CHV. Re-using gen8 code and extending same for CHV. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_irq.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions

[Intel-gfx] [PATCH 1/7] drm/i915: Read guaranteed freq for valleyview

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Reading RP1 for valleyview to help us enable pm_rps i-g-t testcase execution. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/intel_pm.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 5/7] drm/i915: CHV GPU frequency to opcode functions

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Adding chv specific fre/encode conversion. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/intel_pm.c | 68 +++-- 1 file changed, 59 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 7/7] drm/i915: Add RP1 render P state thresholds in CHV

2014-07-09 Thread deepak . s
From: Deepak S deepa...@linux.intel.com This is useful for userspace utilities to verify and micromanaging the increase/decrease frequncy. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/intel_pm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 3/7] drm/i915: keep freq/opcode conversion function more generic

2014-07-09 Thread Deepak S
On Wednesday 09 July 2014 05:33 PM, Daniel Vetter wrote: On Thu, Jul 10, 2014 at 01:16:23PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Since freq/encode conversion formula changes from platform to platform, create a generic wrapper function and having

Re: [Intel-gfx] [PATCH] drm/i915: Restrict GPU boost to the RCS engine

2014-07-07 Thread Deepak S
On Monday 07 July 2014 02:35 PM, Daniel Vetter wrote: On Tue, Jun 24, 2014 at 05:22:17PM +0530, Deepak S wrote: Hi Chris/Daniel, The patch is helping in some of the side-effects due to gpu boost. I still need to get more data. I will keep the thread updated. Ping. Might as well review

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: gmch: factor out intel_set_memory_cxsr

2014-06-29 Thread Deepak S
On Friday 13 June 2014 05:24 PM, Imre Deak wrote: This functionality will be also needed by an upcoming patch, so factor it out. As a bonus this also makes things a bit more uniform across platforms. Note that this also changes the register read-modify-write to a simple write during disabling.

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: gmch: set SR WMs to valid values before enabling them

2014-06-29 Thread Deepak S
On Friday 13 June 2014 05:24 PM, Imre Deak wrote: Atm it's possible that we enable the memory self-refresh mode before the watermark levels used by this mode are programmed with valid values. So move the enabling after we programmed the WM levels. Signed-off-by: Imre Deak imre.d...@intel.com

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: gmch: fix stuck primary plane due to memory self-refresh mode

2014-06-29 Thread Deepak S
On Friday 13 June 2014 05:24 PM, Imre Deak wrote: Blanking/unblanking the console in a loop on an Asus T100 sometimes leaves the console blank. After some digging I found that applying commit 61bc95c1fbbb6a08b55bbe161fdf1ea5493fc595 Author: Egbert Eich e...@suse.com Date: Mon Mar 4 09:24:38

[Intel-gfx] [PATCH] drm/i915/chv: Drop WaGsvBringDownFreqInRc6

2014-06-27 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Drop WaGsvBringDownFreq on CHV. When in RC6 requesting the min freq should be fine to bring the voltage down. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/intel_pm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[Intel-gfx] [PATCH v2] drm/i915: Drop WA to fix Voltage not getting dropped to Vmin when Gfx is power gated for latest VLV revision

2014-06-27 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Workaround fixed in Latest VLV revision. Forcing Gfx clk up not needed, and Requesting the min freq should bring bring the voltage Vnn. v2: Drop WA for Latest VLV revision (Ville) Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Restrict GPU boost to the RCS engine

2014-06-23 Thread Deepak S
Hi Chris/Daniel, The patch is helping in some of the side-effects due to gpu boost. I still need to get more data. I will keep the thread updated. Thanks Deepak On Thursday 12 June 2014 03:02 PM, Daniel Vetter wrote: Adding Deepak for testing, this hopefully alleviates the bad side-effects

[Intel-gfx] [PATCH v3] drm/i915: Force GPU Freq to lowest while suspending.

2014-06-19 Thread deepak . s
From: Deepak S deepa...@linux.intel.com We might be leaving the GPU Frequency (and thus vnn) high during the suspend. Force gt to move to lowest freq while suspending. v2: Fixed typo in commit message (Deepak) v3: Force gt to lowest freq in suspend_gt_powersave (Daniel) Signed-off-by: Deepak S

Re: [Intel-gfx] [PATCH v3] drm/i915: Force GPU Freq to lowest while suspending.

2014-06-19 Thread Deepak S
On Thursday 19 June 2014 06:04 PM, Daniel Vetter wrote: On Fri, Jun 20, 2014 at 1:59 PM, deepa...@linux.intel.com wrote: diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 2043c4b..6bbb90b 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++

[Intel-gfx] [PATCH v4] drm/i915: Force GPU Freq to lowest while suspending.

2014-06-19 Thread deepak . s
From: Deepak S deepa...@linux.intel.com We might be leaving the GPU Frequency (and thus vnn) high during the suspend. Force gt to move to lowest freq while suspending. v2: Fixed typo in commit message (Deepak) v3: Force gt to lowest freq in suspend_gt_powersave (Daniel) v4: Add GPU min freq

Re: [Intel-gfx] [PATCH] drm/i915: Restrict GPU boost to the RCS engine

2014-06-19 Thread Deepak S
On Thursday 12 June 2014 03:02 PM, Daniel Vetter wrote: Adding Deepak for testing, this hopefully alleviates the bad side-effects of the gpu booster he's seeing. -Daniel On Thu, Jun 12, 2014 at 11:28 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: Make the assumption that media workloads are

[Intel-gfx] [PATCH] drm/i915: Bring GPU Freq to min while suspending.

2014-06-17 Thread deepak . s
From: Deepak S deepa...@linux.intel.com We might be leaving the PGU Frequency (and thus vnn) high during the suspend. Flusing the delayed work queue should take care of this. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion

[Intel-gfx] [PATCH v2] drm/i915: Bring GPU Freq to min while suspending.

2014-06-17 Thread deepak . s
From: Deepak S deepa...@linux.intel.com We might be leaving the GPU Frequency (and thus vnn) high during the suspend. Flush the delayed work queue should take care of this. v2: Fixed typo in commit message (Deepak) Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2] drm/i915: Bring GPU Freq to min while suspending.

2014-06-17 Thread Deepak S
On Wednesday 18 June 2014 03:47 AM, Daniel Vetter wrote: On Wed, Jun 18, 2014 at 05:30:53AM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com We might be leaving the GPU Frequency (and thus vnn) high during the suspend. Flush the delayed work queue should take

Re: [Intel-gfx] [PATCH] drm/i915: Drop WA to fix Voltage not getting dropped to Vmin when Gfx is power gated.

2014-06-16 Thread Deepak S
On Friday 13 June 2014 07:24 PM, Daniel Vetter wrote: On Fri, Jun 13, 2014 at 05:56:41PM +0530, Deepak S wrote: On Friday 13 June 2014 05:27 PM, Ville Syrjälä wrote: On Fri, Jun 13, 2014 at 02:33:44PM +0300, Ville Syrjälä wrote: On Fri, Jun 13, 2014 at 03:46:14PM +0530, deepa

[Intel-gfx] [PATCH] drm/i915: Drop WA to fix Voltage not getting dropped to Vmin when Gfx is power gated.

2014-06-13 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Workaround fixed in BYT. Forcing Gfx clk up not needed, and Requesting the min freq should bring bring the voltage Vnn. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/intel_pm.c | 40 +--- 1

Re: [Intel-gfx] [PATCH] drm/i915: Drop WA to fix Voltage not getting dropped to Vmin when Gfx is power gated.

2014-06-13 Thread Deepak S
On Friday 13 June 2014 05:27 PM, Ville Syrjälä wrote: On Fri, Jun 13, 2014 at 02:33:44PM +0300, Ville Syrjälä wrote: On Fri, Jun 13, 2014 at 03:46:14PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Workaround fixed in BYT. Forcing Gfx clk up not needed

[Intel-gfx] [PATCH v6] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-27 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv-rps variables in upstream. v4: Rebase against latest code. (Deepak) v5: Rebase against latest nightly code. (Deepak) v6: Rename the variables to match the spec

[Intel-gfx] [PATCH v7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-27 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv-rps variables in upstream. v4: Rebase against latest code. (Deepak) v5: Rebase against latest nightly code. (Deepak) v6: Rename the variables to match the spec

Re: [Intel-gfx] [PATCH 6/7] drm/i915/chv: Added CHV specific DDR fetch into init_clock_gating

2014-05-27 Thread Deepak S
On Tuesday 27 May 2014 05:29 PM, Ville Syrjälä wrote: On Tue, May 27, 2014 at 01:42:50PM +0200, Daniel Vetter wrote: On Mon, May 26, 2014 at 06:19:07PM +0300, Mika Kuoppala wrote: deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com Signed-off-by: Deepak S deepa

Re: [Intel-gfx] [PATCH 6/7] drm/i915/chv: Added CHV specific DDR fetch into init_clock_gating

2014-05-27 Thread Deepak S
On Tuesday 27 May 2014 05:12 PM, Daniel Vetter wrote: On Mon, May 26, 2014 at 06:19:07PM +0300, Mika Kuoppala wrote: deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com Signed-off-by: Deepak S deepa...@linux.intel.com [vsyrjala: Fix merge fubmle where the code ended up

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Deepak S
On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: Hi Deepak, deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv-rps variables in upstream. v4: Rebase against latest code

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Deepak S
Thanks for the Review. I will address the comments On Monday 26 May 2014 08:07 PM, Mika Kuoppala wrote: Deepak S deepa...@linux.intel.com writes: On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: Hi Deepak, deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com v2

Re: [Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-26 Thread Deepak S
On Monday 26 May 2014 08:02 PM, Ville Syrjälä wrote: On Mon, May 26, 2014 at 07:24:21PM +0530, Deepak S wrote: On Monday 26 May 2014 07:00 PM, Mika Kuoppala wrote: Hi Deepak, deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com v2: Disable media turbo and Add

[Intel-gfx] [PATCH 7/7] drm/i915/chv: Freq(opcode) request for CHV.

2014-05-23 Thread deepak . s
From: Deepak S deepa...@linux.intel.com On CHV, All the freq request should be even. So, we need to make sure we request the opcode accordingly. v2: Avoid vairable for freq request (ville) Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Ben Widawsky b...@bwidawsk.net --- drivers

[Intel-gfx] [PATCH 0/7] Enable RC6/Turbo on CHV

2014-05-23 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Squashed some of the patches and rebased the patches on latest nightly. Deepak S (5): drm/i915/chv: Enable Render Standby (RC6) for Cherryview drm/i915/chv: Added CHV specific register read and write and Streamline CHV forcewake stuff drm/i915

[Intel-gfx] [PATCH 3/7] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-23 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv-rps variables in upstream. v4: Rebase against latest code. (Deepak) v5: Rebase against latest nightly code. (Deepak) Signed-off-by: Deepak S deepa

[Intel-gfx] [PATCH 4/7] drm/i915/chv: CHV doesn't need WaRsForcewakeWaitTC0

2014-05-23 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com Skip __gen6_gt_wait_for_thread_c0() on CHV. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] [PATCH 2/7] drm/i915/chv: Added CHV specific register read and write and Streamline CHV forcewake stuff

2014-05-23 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Support to individually control Media/Render well based on the register access. Add CHV specific write function to habdle difference between registers that are sadowed vs those that need forcewake even for writes. Streamline the CHV forcewake functions

[Intel-gfx] [PATCH 5/7] drm/i915/chv: Skip gen6_gt_check_fifodbg() on CHV

2014-05-23 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com CHV uses the gen8 shadow register mechanism so we shouldn't be checking the GT FIFO status. This effectively removes the posting read, so add an explicit posting read using FORCEWAKE_ACK_VLV (which is what use in vlv_forcewake_reset()).

[Intel-gfx] [PATCH 1/7] drm/i915/chv: Enable Render Standby (RC6) for Cherryview

2014-05-23 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition check during CHV RC6 Enable flag set v4: Fixup PCBR comment msg. (Chris) Rebase against latest code (Deak) Fixup Spurious hunk (Ben) v5: Fix PCBR and commentis msg

[Intel-gfx] [PATCH 6/7] drm/i915/chv: Added CHV specific DDR fetch into init_clock_gating

2014-05-23 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Signed-off-by: Deepak S deepa...@linux.intel.com [vsyrjala: Fix merge fubmle where the code ended up in g4x_disable_trickle_feed() instead of cherryview_init_clock_gating()] Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com Acked-by: Ben Widawsky b

[Intel-gfx] [PATCH v5] drm/i915/chv: Enable Render Standby (RC6) for Cherryview

2014-05-15 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition check during CHV RC6 Enable flag set v4: Fixup PCBR comment msg. (Chris) Rebase against latest code (Deak) Fixup Spurious hunk (Ben) v5: Fix PCBR and commentis msg

Re: [Intel-gfx] [PATCH v5] drm/i915/chv: Enable Render Standby (RC6) for Cherryview

2014-05-15 Thread Deepak S
Hi Mika, On the PCBR check comment. I will create a separate patch to address both VLV and CHV Thanks Deepak On Thursday 15 May 2014 03:27 PM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR

[Intel-gfx] [PATCH v5 1/8] drm/i915/chv: Enable Render Standby (RC6) for Cherryview

2014-05-15 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition check during CHV RC6 Enable flag set v4: Fixup PCBR comment msg. (Chris) Rebase against latest code (Deak) Fixup Spurious hunk (Ben) v5: Fix PCBR and commentis msg

[Intel-gfx] [PATCH v3] drm/i915: Enable PM Interrupts target via Display Interface.

2014-05-14 Thread deepak . s
From: Deepak S deepa...@linux.intel.com In BDW, Apart from unmasking up/down threshold interrupts. we need to umask bit 32 of PM_INTRMASK to route interrupts to target via Display Interface. v2: Add (131) mask (Ville) v3: Add Gen check for the mask (ville) Signed-off-by: Deepak S deepa

Re: [Intel-gfx] [PATCH 03/10] drm/i915/chv: Enable Render Standby (RC6) for Cherryview

2014-05-14 Thread Deepak S
On Friday 09 May 2014 06:49 PM, Mika Kuoppala wrote: Hi Deepak, deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition check during CHV RC6 Enable flag set v4: Fixup PCBR comment msg. (Chris

[Intel-gfx] [PATCH v2] drm/i915/chv: Freq(opcode) request for CHV.

2014-05-12 Thread deepak . s
From: Deepak S deepa...@linux.intel.com On CHV, All the freq request should be even. So, we need to make sure we request the opcode accordingly. v2: Avoid vairable for freq request (ville) Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Ben Widawsky b...@bwidawsk.net --- drivers

Re: [Intel-gfx] [PATCH v3] drm/i915: Debugfs disable RPS boost and idle

2014-05-09 Thread Deepak S
On Tuesday 06 May 2014 03:20 AM, Daisy Sun wrote: RP frequency request is affected by 2 modules: normal turbo algorithm and RPS boost algorithm. By adding RPS boost algorithm to the mix, the final frequency becomes relatively unpredictable. Add a switch to enable/disable RPS boost

[Intel-gfx] [PATCH 01/10] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-05 Thread deepak . s
, Unnecessary empty line and use right IIR interrupt (Ville) Signed-off-by: Ben Widawsky b...@bwidawsk.net Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_irq.c | 75 ++-- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 04/10] drm/i915/chv: Added CHV specific register read and write

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Support to individually control Media/Render well based on the register access. Add CHV specific write function to habdle difference between registers that are sadowed vs those that need forcewake even for writes. v2: Drop write FIFO for CHV and add comman

[Intel-gfx] [PATCH 02/10] drm/i915: Enable PM Interrupts target via Display Interface.

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com In BDW, Apart from unmasking up/down threshold interrupts. we need to umask bit 32 of PM_INTRMASK to route interrupts to target via Display Interface. v2: Add (131) mask (Ville) Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 00/10] Enable RC6/Turbo on CHV

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Squashed some of the patches and created a new patch series. Addressed review comments on most of the patches. Ben Widawsky (1): drm/i915/bdw: Implement a basic PM interrupt handler Deepak S (7): drm/i915: Enable PM Interrupts target via Display

[Intel-gfx] [PATCH 03/10] drm/i915/chv: Enable Render Standby (RC6) for Cherryview

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition check during CHV RC6 Enable flag set v4: Fixup PCBR comment msg. (Chris) Rebase against latest code (Deak) Fixup Spurious hunk (Ben) Signed-off-by: Deepak S deepa

[Intel-gfx] [PATCH 10/10] drm/i915/chv: Freq(opcode) request for CHV.

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com On CHV, All the freq request should be even. So, we need to make sure we request the opcode accordingly. Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Ben Widawsky b...@bwidawsk.net --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu

[Intel-gfx] [PATCH 07/10] drm/i915/chv: CHV doesn't need WaRsForcewakeWaitTC0

2014-05-05 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com Skip __gen6_gt_wait_for_thread_c0() on CHV. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] [PATCH 06/10] drm/i915/chv: Enable RPS (Turbo) for Cherryview

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv-rps variables in upstream. v4: Rebase against latest code. (Deepak) Signed-off-by: Deepak S deepa...@linux.intel.com Signed-off-by: Daniel Vetter daniel.vet

[Intel-gfx] [PATCH 09/10] drm/i915/chv: Added CHV specific DDR fetch into init_clock_gating

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Signed-off-by: Deepak S deepa...@linux.intel.com [vsyrjala: Fix merge fubmle where the code ended up in g4x_disable_trickle_feed() instead of cherryview_init_clock_gating()] Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com Acked-by: Ben Widawsky b

[Intel-gfx] [PATCH 05/10] drm/i915/chv: Streamline CHV forcewake stuff

2014-05-05 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Streamline the CHV forcewake functions just like was done for VLV. This will also fix a bug in accessing the common well registers, where we'd end up trying to wake up the wells too many times since we'd call force_wake_get/put twice per register access

[Intel-gfx] [PATCH 08/10] drm/i915/chv: Skip gen6_gt_check_fifodbg() on CHV

2014-05-05 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com CHV uses the gen8 shadow register mechanism so we shouldn't be checking the GT FIFO status. This effectively removes the posting read, so add an explicit posting read using FORCEWAKE_ACK_VLV (which is what use in vlv_forcewake_reset()).

Re: [Intel-gfx] [PATCH 04/10] drm/i915/chv: Added CHV specific register read and write

2014-05-04 Thread Deepak S
Thanks Ben. Apologies for delayed response. I am incorporating the review comment changes next set of patch review. On Saturday 26 April 2014 03:24 AM, Ben Widawsky wrote: On Mon, Apr 21, 2014 at 01:34:08PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com

Re: [Intel-gfx] [PATCH v3] drm/i915: Add boot paramter to control rps boost at boot time.

2014-04-30 Thread Deepak S
On Monday 28 April 2014 08:42 PM, Daniel Vetter wrote: On Mon, Apr 28, 2014 at 4:47 PM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com We are adding a module paramter to control rps boost. By default, we enable the boost for better performace. Based on the need (perf

[Intel-gfx] [PATCH v3] drm/i915: Add boot paramter to control rps boost at boot time.

2014-04-28 Thread deepak . s
From: Deepak S deepa...@linux.intel.com We are adding a module paramter to control rps boost. By default, we enable the boost for better performace. Based on the need (perf/power) we can either enable/disable. v2: Addressed rps default comment (Jani) v3: Use bool to represent the boot parameter

[Intel-gfx] [PATCH v6] drm/i915/vlv: WA for Turbo and RC6 to work together.

2014-04-28 Thread deepak . s
From: Deepak S deepa...@linux.intel.com With RC6 enabled, BYT has an HW issue in determining the right Gfx busyness. WA for Turbo + RC6: Use SW based Gfx busy-ness detection to decide on increasing/decreasing the freq. This logic will monitor C0 counters of render/media power-wells over EI period

Re: [Intel-gfx] [PATCH 03/10] drm/i915/chv: Enable Render Standby (RC6) for Cheeryview

2014-04-28 Thread Deepak S
On Monday 28 April 2014 08:15 PM, Daniel Vetter wrote: On Mon, Apr 28, 2014 at 05:29:46PM +0300, Imre Deak wrote: +static void cherryview_setup_pctx(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev-dev_private; + unsigned long pctx_paddr; + struct i915_gtt

Re: [Intel-gfx] [PATCH 03/10] drm/i915/chv: Enable Render Standby (RC6) for Cheeryview

2014-04-28 Thread Deepak S
Thanks for the review. I will address the comments On Saturday 26 April 2014 03:12 AM, Ben Widawsky wrote: On Mon, Apr 21, 2014 at 01:34:07PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR

Re: [Intel-gfx] [PATCH 03/10] drm/i915/chv: Enable Render Standby (RC6) for Cheeryview

2014-04-28 Thread Deepak S
Thanks for the review. I will address the comments On Monday 28 April 2014 07:59 PM, Imre Deak wrote: On Mon, 2014-04-21 at 13:34 +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition

Re: [Intel-gfx] [PATCH 00/10] Enable RC6/Turbo on CHV

2014-04-22 Thread Deepak S
On Wednesday 23 April 2014 01:49 AM, Daniel Vetter wrote: On Mon, Apr 21, 2014 at 07:28:54PM +0530, Deepak S wrote: Hi Ville, let me know if you want some of other small patches to be squashed. Quick aside: Something seems to have gone with git send-email thread - the patches aren't in-reply

[Intel-gfx] [PATCH 00/10] Enable RC6/Turbo on CHV

2014-04-21 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Squashed some of the patches and created a new patch series. ToDo: Address the comments on some the patches. Changes will be shared in next series. Ben Widawsky (1): drm/i915/bdw: Implement a basic PM interrupt handler Deepak S (6): drm/i915: Enable

[Intel-gfx] [PATCH 09/10] drm/i915/chv: Added CHV specific DDR fetch into init_clock_gating

2014-04-21 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Signed-off-by: Deepak S deepa...@linux.intel.com [vsyrjala: Fix merge fubmle where the code ended up in g4x_disable_trickle_feed() instead of cherryview_init_clock_gating()] Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm

[Intel-gfx] [PATCH 07/10] drm/i915/chv: CHV doesn't need WaRsForcewakeWaitTC0

2014-04-21 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com Skip __gen6_gt_wait_for_thread_c0() on CHV. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] [PATCH 03/10] drm/i915/chv: Enable Render Standby (RC6) for Cheeryview

2014-04-21 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition check during CHV RC6 Enable flag set Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 100

[Intel-gfx] [PATCH 02/10] drm/i915: Enable PM Interrupts target via Display Interface.

2014-04-21 Thread deepak . s
From: Deepak S deepa...@linux.intel.com In BDW, Apart from unmasking up/down threshold interrupts. we need to umask bit 32 of PM_INTRMASK to route interrupts to target via Display Interface. v2: Add (131) mask (Ville) Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 06/10] drm/i915/chv: Streamline CHV forcewake stuff

2014-04-21 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com Streamline the CHV forcewake functions just like was done for VLV. This will also fix a bug in accessing the common well registers, where we'd end up trying to wake up the wells too many times since we'd call force_wake_get/put twice per register

[Intel-gfx] [PATCH 08/10] drm/i915/chv: Skip gen6_gt_check_fifodbg() on CHV

2014-04-21 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com CHV uses the gen8 shadow register mechanism so we shouldn't be checking the GT FIFO status. This effectively removes the posting read, so add an explicit posting read using FORCEWAKE_ACK_VLV (which is what use in vlv_forcewake_reset()).

[Intel-gfx] [PATCH 01/10] drm/i915/bdw: Implement a basic PM interrupt handler

2014-04-21 Thread deepak . s
, Unnecessary empty line and use right IIR interrupt (Ville) Signed-off-by: Ben Widawsky b...@bwidawsk.net Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_irq.c | 75 ++-- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 05/10] drm/i915/chv: Enable RPS (Turbo) for Cheeryview

2014-04-21 Thread deepak . s
From: Deepak S deepa...@linux.intel.com v2: Disable media turbo and Add DOWN_IDLE_AVG support (Ville) v3: Mass rename of the dev_priv-rps variables in upstream. Signed-off-by: Deepak S deepa...@linux.intel.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 10/10] drm/i915/chv: Freq(opcode) request value for CHV.

2014-04-21 Thread deepak . s
From: Deepak S deepa...@linux.intel.com On CHV, All the freq request should be even. S0, we need to make sure we request the opcode accordingly. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_drv.h | 9 + drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 2 files

[Intel-gfx] [PATCH 04/10] drm/i915/chv: Added CHV specific register read and write

2014-04-21 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Support to individually control Media/Render well based on the register access. Add CHV specific write function to habdle difference between registers that are sadowed vs those that need forcewake even for writes. v2: Drop write FIFO for CHV and add comman

Re: [Intel-gfx] [PATCH 00/10] Enable RC6/Turbo on CHV

2014-04-21 Thread Deepak S
Hi Ville, let me know if you want some of other small patches to be squashed. Thanks Deepak On Monday 21 April 2014 01:23 PM, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com Squashed some of the patches and created a new patch series. ToDo: Address the comments

Re: [Intel-gfx] [PATCH 28/71] drm/i915/chv: Added CHV specific register read and write

2014-04-18 Thread Deepak S
On Friday 18 April 2014 05:58 AM, Ben Widawsky wrote: On Wed, Apr 09, 2014 at 01:28:26PM +0300, ville.syrj...@linux.intel.com wrote: From: Deepak S deepa...@intel.com Support to individually control Media/Render well based on the register access. Add CHV specific write function to habdle

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Enable PM Interrupts target via Display Interface.

2014-04-18 Thread Deepak S
On Wednesday 16 April 2014 07:02 PM, Ville Syrjälä wrote: On Mon, Apr 14, 2014 at 10:36:55PM +0300, Ville Syrjälä wrote: On Mon, Apr 14, 2014 at 10:41:15PM +0530, deepa...@intel.com wrote: From: Deepak S deepa...@intel.com In BDW, Apart from unmasking up/down threshold interrupts. we need

[Intel-gfx] [PATCH 0/2] Enable PM Interrupts for BDW

2014-04-14 Thread deepak . s
From: Deepak S deepa...@intel.com Added patch to enable PM Interrupts Ben Widawsky (1): drm/i915/bdw: Implement a basic PM interrupt handler Deepak S (1): drm/i915: Enable PM Interrupts target via Display Interface. drivers/gpu/drm/i915/i915_irq.c | 81

[Intel-gfx] [PATCH 1/2] drm/i915/bdw: Implement a basic PM interrupt handler

2014-04-14 Thread deepak . s
From: Ben Widawsky benjamin.widaw...@intel.com Almost all of it is reusable from the existing code. The primary difference is we need to do even less in the interrupt handler, since interrupts are not shared in the same way. The patch is mostly a copy-paste of the existing snb+ code, with

[Intel-gfx] [PATCH 2/2] drm/i915: Enable PM Interrupts target via Display Interface.

2014-04-14 Thread deepak . s
From: Deepak S deepa...@intel.com In BDW, Apart from unmasking up/down threshold interrupts. we need to umask bit 32 of PM_INTRMASK to route interrupts to target via Display Interface. Signed-off-by: Deepak S deepa...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 27/71] drm/i915/chv: Enable Render Standby (RC6) for Cheeryview

2014-04-13 Thread Deepak S
, Jani Nikula wrote: On Wed, 09 Apr 2014, ville.syrj...@linux.intel.com wrote: From: Deepak S deepa...@intel.com v2: Configure PCBR if BIOS fails allocate pcbr (deepak) Signed-off-by: Deepak S deepa...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 101

Re: [Intel-gfx] [PATCH 30/71] drm/i915/chv: Enable PM interrupts when we in CHV turbo initialize sequence.

2014-04-13 Thread Deepak S
On Thursday 10 April 2014 04:03 AM, Ben Widawsky wrote: On Thu, Apr 10, 2014 at 12:47:01AM +0530, Deepak S wrote: On Wednesday 09 April 2014 06:36 PM, Chris Wilson wrote: On Wed, Apr 09, 2014 at 01:28:28PM +0300, ville.syrj...@linux.intel.com wrote: +static void gen8_enable_rps_interrupts

Re: [Intel-gfx] [PATCH 45/71] drm/i915/chv: Streamline CHV forcewake stuff

2014-04-09 Thread Deepak S
On Wednesday 09 April 2014 11:17 PM, Ville Syrjälä wrote: On Wed, Apr 09, 2014 at 06:02:36PM +0200, Daniel Vetter wrote: On Wed, Apr 09, 2014 at 01:28:43PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Streamline the CHV forcewake functions

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Bring UP Power Wells before disabling RC6.

2014-04-09 Thread Deepak S
:20PM -0700, Ben Widawsky wrote: On Mon, Apr 07, 2014 at 05:01:46PM -0300, Rodrigo Vivi wrote: From: Deepak S deepa...@intel.com We need do forcewake before Disabling RC6, This is what the BIOS expects while going into suspend. v2: updated commit message. (Daniel) Signed-off-by: Deepak S deepa

Re: [Intel-gfx] [PATCH 30/71] drm/i915/chv: Enable PM interrupts when we in CHV turbo initialize sequence.

2014-04-09 Thread Deepak S
On Wednesday 09 April 2014 06:36 PM, Chris Wilson wrote: On Wed, Apr 09, 2014 at 01:28:28PM +0300, ville.syrj...@linux.intel.com wrote: +static void gen8_enable_rps_interrupts(struct drm_device *dev) +{ + struct drm_i915_private *dev_priv = dev-dev_private; + + /* Clear out any

[Intel-gfx] [PATCH v2] Revert drm/i915/vlv: fixup DDR freq detection per Punit spec

2014-04-03 Thread deepak . s
From: Deepak S deepa...@linux.intel.com As per the inputs provided by hardware team we still use DDR Rates as 0,1=800, 2=1066, 3=1333. With this change, Turbo freqs used on current machines matches. This reverts commit f64a28a7c5ab2fc342326de9e126acf3cc0f91d6. commit

[Intel-gfx] [PATCH v2] drm/i915: Match debugfs interface name to new RPS naming

2014-03-31 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Let's change the i915_cur_delayinfo to i915_frequency_info to be in sync with new RPS naming convention. v2: Add i915_frequency_info as debugfs interface name (Ben) Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_debugfs.c

Re: [Intel-gfx] [PATCH v5] drm/i915/vlv: WA for Turbo and RC6 to work together.

2014-03-30 Thread Deepak S
On Friday 28 March 2014 06:36 PM, Chris Wilson wrote: On Fri, Mar 28, 2014 at 02:53:48PM +0200, Ville Syrjälä wrote: On Thu, Mar 27, 2014 at 12:05:01PM +0530, deepa...@linux.intel.com wrote: @@ -1403,6 +1411,13 @@ typedef struct drm_i915_private { /* gen6+ rps state */ struct

[Intel-gfx] [PATCH v6] drm/i915/vlv: WA for Turbo and RC6 to work together.

2014-03-30 Thread deepak . s
From: Deepak S deepa...@linux.intel.com With RC6 enabled, BYT has an HW issue in determining the right Gfx busyness. WA for Turbo + RC6: Use SW based Gfx busy-ness detection to decide on increasing/decreasing the freq. This logic will monitor C0 counters of render/media power-wells over EI period

Re: [Intel-gfx] [PATCH] drm/i915: Mask PM/RPS interrupt generation based on activity

2014-03-30 Thread Deepak S
frequency versus our imposed range, i.e. if at minimum, we know we will not want to generate any more down-interrupts and vice versa. v2: We only need the TIMEOUT when above min frequency. v3: Tweak VLV at the same time Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Deepak S deepa

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Refactor gen6_set_rps

2014-03-30 Thread Deepak S
On Thursday 27 March 2014 01:54 PM, Chris Wilson wrote: What used to be a short-circuit now needs to adjust interrupt masking in response to user requests for changing the min/max allowed frequencies. This is currently done by a special case and early return, but the next patch adds another

Re: [Intel-gfx] [PATCH 1/3] Revert drm/i915: Disable/Enable PM Intrrupts based on the current freq.

2014-03-30 Thread Deepak S
upclocking in response to a requirement for more power. Testcase: pm_rps/blocking Cc: Deepak S deepa...@intel.com Cc: Ville Syrjälä ville.syrj...@linux.intel.com Cc: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h | 3

[Intel-gfx] [PATCH] Revert drm/i915/vlv: fixup DDR freq detection per Punit spec

2014-03-30 Thread deepak . s
From: Deepak S deepa...@linux.intel.com This reverts commit f64a28a7c5ab2fc342326de9e126acf3cc0f91d6. As per the inputs provided by hardware team we still use DDR Rates as 0,1=800, 2=1066, 3=1333. With this change, Turbo freqs used on current machines matches. --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: Match debugfs interface name to new RPS naming

2014-03-30 Thread deepak . s
From: Deepak S deepa...@intel.com Let's change the i915_cur_delayinfo to i915_cur_freqinfo to be in sync with new RPS naming convention. Signed-off-by: Deepak S deepa...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

<    1   2   3   4   >