Re: [PATCH v2 8/8] Revert "drm/i915: Depend on !PREEMPT_RT."

CI - depends on !PREEMPT_RT select INTEL_GTT if X86 select INTERVAL_TREE # we need shmfs for the swappable backing store, and in particular Cool! Acked-by: Tvrtko Ursulin Regards, Tvrtko

Re: [PATCH v2 6/8] drm/i915: Drop the irqs_disabled() check

\n"); - GEM_BUG_ON(!irqs_disabled()); lockdep_assert_held(>sched_engine->lock); /* Maarten can you r-b since it seems this one originated from your testing? Otherwise: Acked-by: Tvrtko Ursulin Regards, Tvrtko

Re: [PATCH v2 4/8] drm/i915: Disable tracing points on PREEMPT_RT

ine NOTRACE +#endif + #include #include #include If tracing experts said this is the way then it is fine by me. Acked-by: Tvrtko Ursulin Regards, Tvrtko

Re: [PATCH v2 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT

On 18/06/2024 13:54, Sebastian Andrzej Siewior wrote: On 2024-06-18 10:00:09 [+0100], Tvrtko Ursulin wrote: I did a re-test but am not 100% certain yet. CI looks frustratingly noisy at the moment. igt@debugfs_test@read_all_entries appears to be a fluke which is not new. But igt

Re: [PATCH v2 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT

On 17/06/2024 11:07, Sebastian Andrzej Siewior wrote: On 2024-06-14 13:19:25 [+0100], Tvrtko Ursulin wrote: So the question is why do you need to know if the context is atomic? The only impact is avoiding disabling preemption. Is it that important to avoid it? If so would cant_migrate() work

Re: [PATCH v2 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT

On 14/06/2024 12:05, Sebastian Andrzej Siewior wrote: On 2024-06-14 09:32:07 [+0100], Tvrtko Ursulin wrote: I think this could be okay-ish in principle, but the commit text is not entirely accurate because there is no direct coupling between the wait helpers and the uncore lock. They can

Re: [PATCH v2 3/8] drm/i915: Don't check for atomic context on PREEMPT_RT

On 13/06/2024 11:20, Sebastian Andrzej Siewior wrote: The !in_atomic() check in _wait_for_atomic() triggers on PREEMPT_RT because the uncore::lock is a spinlock_t and does not disable preemption or interrupts. Changing the uncore:lock to a raw_spinlock_t doubles the worst case latency on an

[PULL] drm-intel-gt-next

the timeout used. A couple tiny cleanups here and there and finally one back-merge which was required to land some display code base refactoring. Regards, Tvrtko drm-intel-gt-next-2024-06-12: UAPI Changes: - Support replaying GPU hangs with captured context image (Tvrtko Ursulin) Driver

Re: [PATCH] drm/i915/gt: debugfs: Evaluate forcewake usage within locks

On 10/06/2024 10:24, Nirmoy Das wrote: Hi Andi, On 6/7/2024 4:51 PM, Andi Shyti wrote: The forcewake count and domains listing is multi process critical and the uncore provides a spinlock for such cases. Lock the forcewake evaluation section in the fw_domains_show() debugfs interface.

Re: [PATCH 00/10] drm/i915: PREEMPT_RT related fixups.

Hi Sebastian, On 05/06/2024 11:01, Sebastian Andrzej Siewior wrote: On 2024-04-05 16:18:18 [+0200], To intel-gfx@lists.freedesktop.org wrote: Hi, The following patches are from the PREEMPT_RT queue. It is mostly about disabling interrupts/preemption which leads to problems. Unfortunately

Re: [PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

Hi Andi, On 10/06/2024 13:10, Andi Shyti wrote: Hi Tvrtko, On Mon, Jun 10, 2024 at 12:42:31PM +0100, Tvrtko Ursulin wrote: On 03/06/2024 17:20, Niemiec, Krzysztof wrote: The test is trying to push the heartbeat frequency to the limit, which might sometimes fail. Such a failure does

Re: [PATCH] drm/i915/gt: Delete the live_hearbeat_fast selftest

On 03/06/2024 17:20, Niemiec, Krzysztof wrote: The test is trying to push the heartbeat frequency to the limit, which might sometimes fail. Such a failure does not provide valuable information, because it does not indicate that there is something necessarily wrong with either the driver or the

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

On 23/05/2024 13:24, Ville Syrjälä wrote: On Thu, May 23, 2024 at 01:07:24PM +0100, Tvrtko Ursulin wrote: On 23/05/2024 12:19, Ville Syrjälä wrote: On Thu, May 23, 2024 at 09:25:45AM +0100, Tvrtko Ursulin wrote: On 22/05/2024 16:29, Vidya Srinivas wrote: In some scenarios, the DPT object

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

On 23/05/2024 12:19, Ville Syrjälä wrote: On Thu, May 23, 2024 at 09:25:45AM +0100, Tvrtko Ursulin wrote: On 22/05/2024 16:29, Vidya Srinivas wrote: In some scenarios, the DPT object gets shrunk but the actual framebuffer did not and thus its still there on the DPT's vm->bound_l

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

On 22/05/2024 16:29, Vidya Srinivas wrote: In some scenarios, the DPT object gets shrunk but the actual framebuffer did not and thus its still there on the DPT's vm->bound_list. Then it tries to rewrite the PTEs via a stale CPU mapping. This causes panic. Suggested-by: Ville Syrjala Cc:

[PATCH] drm/i915: 2 GiB of relocations ought to be enough for anybody*

From: Tvrtko Ursulin Kernel test robot reports i915 can hit a warn in kvmalloc_node which has a purpose of dissalowing crazy size kernel allocations. This was added in 7661809d493b ("mm: don't allow oversized kvmalloc() calls"): /* Don't even allow crazy sizes */ if (WA

[CI 2/2] drm/i915: Support replaying GPU hangs with captured context image

From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which prevent replicating all hangs, one step further is being able to replay against a real GPU. This is almost

[CI 1/2] drm/i915: Shadow default engine context image in the context

From: Tvrtko Ursulin To enable adding override of the default engine context image let us start shadowing the per engine state in the context. Signed-off-by: Tvrtko Ursulin Cc: Lionel Landwerlin Cc: Carlos Santa Cc: Rodrigo Vivi Reviewed-by: Rodrigo Vivi Signed-off-by: Tvrtko Ursulin

[CI 1/2] drm/i915: Shadow default engine context image in the context

From: Tvrtko Ursulin To enable adding override of the default engine context image let us start shadowing the per engine state in the context. Signed-off-by: Tvrtko Ursulin Cc: Lionel Landwerlin Cc: Carlos Santa Cc: Rodrigo Vivi Reviewed-by: Rodrigo Vivi Signed-off-by: Tvrtko Ursulin

[CI 2/2] drm/i915: Support replaying GPU hangs with captured context image

From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which prevent replicating all hangs, one step further is being able to replay against a real GPU. This is almost

Re: [PATCH] MAINTAINERS: Move the drm-intel repo location to fd.o GitLab

-by: Lucas De Marchi Also Cc'ing maintainers Thanks, Acked-by: Tvrtko Ursulin Regards, Tvrtko --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d6327dc12cb1..fbf7371a0bb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10854,7

Re: [PATCH 1/2] drm/i915/display: remove small micro-optimizations in irq handling

On 18/04/2024 10:49, Jani Nikula wrote: On Wed, 17 Apr 2024, Lucas De Marchi wrote: On Mon, Apr 08, 2024 at 03:54:44PM GMT, Jani Nikula wrote: The raw register reads/writes are there as micro-optimizations to avoid multiple pointer indirections on uncore->regs. Presumably this is useful

Re: [PATCH] drm/i915/gem: Replace dev_priv with i915

sneaking it in. Signed-off-by: Andi Shyti Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 6 +++--- drivers/gpu/drm/i915/gem/i915_gem_stolen.h | 8

Re: [PATCH v6 0/3] Disable automatic load CCS load balancing

On 20/03/2024 15:06, Andi Shyti wrote: Ping! Any thoughts here? I only casually observed the discussion after I saw Matt suggested further simplifications. As I understood it, you will bring back the uabi engine games when adding the dynamic behaviour and that is fine by me. Regards,

Re: [PATCH 0/5] drm/i915: cleanup dead code

On 11/03/2024 19:27, Lucas De Marchi wrote: On Mon, Mar 11, 2024 at 05:43:00PM +, Tvrtko Ursulin wrote: On 06/03/2024 19:36, Lucas De Marchi wrote: Remove platforms that never had their PCI IDs added to the driver and are of course marked with requiring force_probe. Note that most

Re: [PATCH 0/5] drm/i915: cleanup dead code

On 06/03/2024 19:36, Lucas De Marchi wrote: Remove platforms that never had their PCI IDs added to the driver and are of course marked with requiring force_probe. Note that most of the code for those platforms is actually used by subsequent ones, so it's not a huge amount of code being

[PATCH] MAINTAINERS: Update email address for Tvrtko Ursulin

From: Tvrtko Ursulin I will lose access to my @.*intel.com e-mail addresses soon so let me adjust the maintainers entry and update the mailmap too. While at it consolidate a few other of my old emails to point to the main one. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter Cc: Dave Airlie

[PULL] drm-intel-gt-next

. Regards, Tvrtko drm-intel-gt-next-2024-02-28: Driver Changes: Fixes: - Add some boring kerneldoc (Tvrtko Ursulin) - Check before removing mm notifier (Nirmoy The following changes since commit eb927f01dfb6309c8a184593c2c0618c4000c481: drm/i915/gt: Restart the heartbeat timer when forcing

Re: [PATCH] drm/i915: check before removing mm notifier

On 27/02/2024 09:26, Nirmoy Das wrote: Hi Tvrtko, On 2/27/2024 10:04 AM, Tvrtko Ursulin wrote: On 21/02/2024 11:52, Nirmoy Das wrote: Merged it to drm-intel-gt-next with s/check/Check Shouldn't this have had: Fixes: ed29c2691188 ("drm/i915: Fix userptr so we do not have to worry

Re: [PATCH v2] drm/i915/guc: Use context hints for GT freq

/sushmave/mesa/-/commits/compute_hint v2: Rename flags as per review suggestions (Rodrigo, Tvrtko). Also, use flag bits in intel_context as it allows finer control for toggling per engine if needed (Tvrtko). Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Sushma Venkatesh Reddy Signed-off-by: Vinay Belgaumkar

Re: [PATCH] drm/i915: check before removing mm notifier

On 21/02/2024 11:52, Nirmoy Das wrote: Merged it to drm-intel-gt-next with s/check/Check Shouldn't this have had: Fixes: ed29c2691188 ("drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.") Cc: # v5.13+ ? Regards, Tvrtko On 2/19/2024 1:50 PM, Nirmoy Das wrote:

Re: [PATCH 2/2] drm/i915: Support replaying GPU hangs with captured context image

On 22/02/2024 21:07, Rodrigo Vivi wrote: On Wed, Feb 21, 2024 at 02:22:45PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which

Re: [PATCH] drm/i915/guc: Add Compute context hint

On 26/02/2024 08:47, Tvrtko Ursulin wrote: On 23/02/2024 19:25, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 10:31:41AM -0800, Belgaumkar, Vinay wrote: On 2/23/2024 12:51 AM, Tvrtko Ursulin wrote: On 22/02/2024 23:31, Belgaumkar, Vinay wrote: On 2/22/2024 7:32 AM, Tvrtko Ursulin wrote

Re: [PATCH] drm/i915/guc: Add Compute context hint

On 23/02/2024 19:25, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 10:31:41AM -0800, Belgaumkar, Vinay wrote: On 2/23/2024 12:51 AM, Tvrtko Ursulin wrote: On 22/02/2024 23:31, Belgaumkar, Vinay wrote: On 2/22/2024 7:32 AM, Tvrtko Ursulin wrote: On 21/02/2024 21:28, Rodrigo Vivi wrote

Re: [PATCH] drm/i915/guc: Add Compute context hint

On 22/02/2024 23:31, Belgaumkar, Vinay wrote: On 2/22/2024 7:32 AM, Tvrtko Ursulin wrote: On 21/02/2024 21:28, Rodrigo Vivi wrote: On Wed, Feb 21, 2024 at 09:42:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Vinay Belgaumkar wrote: Allow user to provide a context hint. When

Re: [PATCH] drm/i915/guc: Add Compute context hint

On 21/02/2024 21:28, Rodrigo Vivi wrote: On Wed, Feb 21, 2024 at 09:42:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Vinay Belgaumkar wrote: Allow user to provide a context hint. When this is set, KMD will send a hint to GuC which results in special handling for this context. SLPC

[PATCH 2/2] drm/i915: Support replaying GPU hangs with captured context image

From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which prevent replicating all hangs, one step further is being able to replay against a real GPU. This is almost

[PATCH v2 0/2] GPU hang replay

From: Tvrtko Ursulin Please see 2/2 for explanation and rationale. v2: * Extracted shadowing of default state into a leading patch. Tvrtko Ursulin (2): drm/i915: Shadow default engine context image in the context drm/i915: Support replaying GPU hangs with captured context image drivers

[PATCH 1/2] drm/i915: Shadow default engine context image in the context

From: Tvrtko Ursulin To enable adding override of the default engine context image let us start shadowing the per engine state in the context. Signed-off-by: Tvrtko Ursulin Cc: Lionel Landwerlin Cc: Carlos Santa Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_context_types.h | 2

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

On 21/02/2024 12:08, Tvrtko Ursulin wrote: On 21/02/2024 11:19, Andi Shyti wrote: Hi Tvrtko, On Wed, Feb 21, 2024 at 08:19:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Andi Shyti wrote: On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: On 20/02/2024 14:35, Andi

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

On 21/02/2024 11:19, Andi Shyti wrote: Hi Tvrtko, On Wed, Feb 21, 2024 at 08:19:34AM +, Tvrtko Ursulin wrote: On 21/02/2024 00:14, Andi Shyti wrote: On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: On 20/02/2024 14:35, Andi Shyti wrote: Enable only one CCS engine

Re: [PATCH] drm/i915/guc: Add Compute context hint

On 21/02/2024 00:14, Vinay Belgaumkar wrote: Allow user to provide a context hint. When this is set, KMD will send a hint to GuC which results in special handling for this context. SLPC will ramp the GT frequency aggressively every time it switches to this context. The down freq threshold will

Re: [RFC] drm/i915: Support replaying GPU hangs with captured context image

On 20/02/2024 22:50, Rodrigo Vivi wrote: On Tue, Feb 13, 2024 at 01:14:34PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

On 21/02/2024 00:14, Andi Shyti wrote: Hi Tvrtko, On Tue, Feb 20, 2024 at 02:48:31PM +, Tvrtko Ursulin wrote: On 20/02/2024 14:35, Andi Shyti wrote: Enable only one CCS engine by default with all the compute sices slices Thanks! diff --git a/drivers/gpu/drm/i915/gt

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

On 20/02/2024 14:35, Andi Shyti wrote: Enable only one CCS engine by default with all the compute sices slices allocated to it. While generating the list of UABI engines to be exposed to the user, exclude any additional CCS engines beyond the first instance. This change can be tested

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

On 20/02/2024 14:20, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Erm *all* CSS engines work together.. Simultaneously, the user will see only 1 CCS

Re: [PATCH] drm/i915: Fix possible null pointer dereference after drm_dbg_printer conversion

On 20/02/2024 10:36, Maxime Ripard wrote: On Tue, Feb 20, 2024 at 09:16:43AM +, Tvrtko Ursulin wrote: On 19/02/2024 20:02, Rodrigo Vivi wrote: On Mon, Feb 19, 2024 at 01:14:23PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Request can be NULL if no guilty request was identified

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

On 20/02/2024 10:11, Andi Shyti wrote: Hi Tvrtko, On Mon, Feb 19, 2024 at 12:51:44PM +, Tvrtko Ursulin wrote: On 19/02/2024 11:16, Tvrtko Ursulin wrote: On 15/02/2024 13:59, Andi Shyti wrote: ... +/* + * Exclude unavailable engines. + * + * Only the first CCS engine is utilized due

Re: [PATCH] drm/i915: Fix possible null pointer dereference after drm_dbg_printer conversion

On 19/02/2024 20:02, Rodrigo Vivi wrote: On Mon, Feb 19, 2024 at 01:14:23PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Request can be NULL if no guilty request was identified so simply use engine->i915 instead. Signed-off-by: Tvrtko Ursulin Fixes: d50892a9554c ("drm/i915

[PATCH] drm/i915: Add some boring kerneldoc

From: Tvrtko Ursulin Tooling appears very strict so lets pacify it by adding some comments, even if fields are completely self-explanatory. Signed-off-by: Tvrtko Ursulin Fixes: b11236486749 ("drm/i915: Add GuC submission interface version query") Reported-by: Stephen Rothwell Cc:

[PATCH] drm/i915: Fix possible null pointer dereference after drm_dbg_printer conversion

From: Tvrtko Ursulin Request can be NULL if no guilty request was identified so simply use engine->i915 instead. Signed-off-by: Tvrtko Ursulin Fixes: d50892a9554c ("drm/i915: switch from drm_debug_printer() to device specific drm_dbg_printer()") Reported-by: Dan Carpenter Cc: Ja

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

On 19/02/2024 11:16, Tvrtko Ursulin wrote: On 15/02/2024 13:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS

Re: [PATCH 2/2] drm/i915/gt: Set default CCS mode '1'

On 15/02/2024 13:59, Andi Shyti wrote: Since CCS automatic load balancing is disabled, we will impose a fixed balancing policy that involves setting all the CCS engines to work together on the same load. Simultaneously, the user will see only 1 CCS rather than the actual number. As of now,

[PULL] drm-intel-gt-next

submission version query which Mesa wants for implementing Vulkan async compute queues. Regards, Tvrtko drm-intel-gt-next-2024-02-15: UAPI Changes: - Add GuC submission interface version query (Tvrtko Ursulin) Driver Changes: Fixes/improvements/new stuff: - Atomically invalidate userptr on mmu

Re: [PATCH 2/2] i915/pmu: Cleanup pending events on unbind

On 13/02/2024 18:03, Umesh Nerlige Ramappa wrote: Once a user opens an fd for a perf event, if the driver undergoes a function level reset (FLR), the resources are not cleaned up as expected. For this discussion FLR is defined as a PCI unbind followed by a bind. perf_pmu_unregister() would

[RFC] drm/i915: Support replaying GPU hangs with captured context image

From: Tvrtko Ursulin When debugging GPU hangs Mesa developers are finding it useful to replay the captured error state against the simulator. But due various simulator limitations which prevent replicating all hangs, one step further is being able to replay against a real GPU. This is almost

Re: [PATCH] drm/i915: Add flex arrays to struct i915_syncmap

On 08/02/2024 18:13, Erick Archer wrote: The "struct i915_syncmap" uses a dynamically sized set of trailing elements. It can use an "u32" array or a "struct i915_syncmap *" array. So, use the preferred way in the kernel declaring flexible arrays [1]. Because there are two possibilities for

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

On 08/02/2024 17:55, Souza, Jose wrote: On Thu, 2024-02-08 at 07:19 -0800, José Roberto de Souza wrote: On Thu, 2024-02-08 at 14:59 +, Tvrtko Ursulin wrote: On 08/02/2024 14:30, Souza, Jose wrote: On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new

Re: [PATCH v2] drm/i915: Add GuC submission interface version query

On 08/02/2024 14:30, Souza, Jose wrote: On Thu, 2024-02-08 at 08:25 +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render

Re: [RFC] drm/i915: Add GuC submission interface version query

On 07/02/2024 19:34, John Harrison wrote: On 2/7/2024 10:49, Tvrtko Ursulin wrote: On 07/02/2024 18:12, John Harrison wrote: On 2/7/2024 03:56, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information

[PATCH v2] drm/i915: Add GuC submission interface version query

From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and compute command streamers simultaneously can cause GPU hangs due issues in firmware scheduling

Re: [RFC] drm/i915: Add GuC submission interface version query

On 07/02/2024 18:12, John Harrison wrote: On 2/7/2024 03:56, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and compute

[RFC] drm/i915: Add GuC submission interface version query

From: Tvrtko Ursulin Add a new query to the GuC submission interface version. Mesa intends to use this information to check for old firmware versions with a known bug where using the render and compute command streamers simultaneously can cause GPU hangs due issues in firmware scheduling

Re: [PATCH] drm/i915/gt: Prevent possible NULL dereference in __caps_show()

Hi, On 06/02/2024 16:45, Nikita Zhandarovich wrote: After falling through the switch statement to default case 'repr' is initialized with NULL, which will lead to incorrect dereference of '!repr[n]' in the following loop. Fix it with the help of an additional check for NULL. Found by Linux

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

On 06/02/2024 20:51, Souza, Jose wrote: On Tue, 2024-02-06 at 12:42 -0800, John Harrison wrote: On 2/6/2024 08:33, Tvrtko Ursulin wrote: On 01/02/2024 18:25, Souza, Jose wrote: On Wed, 2024-01-24 at 08:55 +, Tvrtko Ursulin wrote: On 24/01/2024 08:19, Joonas Lahtinen wrote: Add

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

On 01/02/2024 18:25, Souza, Jose wrote: On Wed, 2024-01-24 at 08:55 +, Tvrtko Ursulin wrote: On 24/01/2024 08:19, Joonas Lahtinen wrote: Add reporting of the GuC submissio/VF interface version via GETPARAM properties. Mesa intends to use this information to check for old firmware

Re: [PATCH 5/6] drm/i915: Update shared stats to use the new gem helper

s[id].shared += sz; else stats[id].private += sz; Reviewed-by: Tvrtko Ursulin Good that you remembered this story, I completely forgot! Regards, Tvrtko

Re: [PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

G_LOCKDEP /** Not sure what the local view on static inlines, but fine nevertheless. Reviewed-by: Tvrtko Ursulin Regards, Tvrtko

Re: [PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs

ts(obj)) { status.shared += obj->size; } else { status.private += obj->size; Reviewed-by: Tvrtko Ursulin Regards, Tvrtko

Re: [PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-*

-total-: [KiB|MiB] Reviewed-by: Tvrtko Ursulin Regards, Tvrtko

Re: [RFC PATCH] drm/i915: Add GETPARAM for GuC submission version

remembers. Signed-off-by: Joonas Lahtinen Cc: Kenneth Graunke Cc: Jose Souza Cc: Sagar Ghuge Cc: Paulo Zanoni Cc: John Harrison Cc: Rodrigo Vivi Cc: Jani Nikula Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_getparam.c | 12 include/uapi/drm/i915_drm.h | 13

[PATCH i-g-t] tools/intel_gpu_top: Fix near full percentage bar formatting

From: Tvrtko Ursulin Fix a bug where 1) the end vertical separator element would not be printed if the progress bar portion was all filled by the progress bar characters (no trailing spaces), and 2) the numerical overlay would be skipped to. The bug would also shift the layout of following UI

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

On 08/01/2024 15:13, Joonas Lahtinen wrote: Quoting Tvrtko Ursulin (2024-01-05 12:39:31) On 04/01/2024 21:23, Andi Shyti wrote: +void intel_gt_apply_ccs_mode(struct intel_gt *gt) +{ + mutex_lock(>ccs.mutex); + __intel_gt_apply_ccs_mode(gt); + mutex_unlock(>ccs.mutex); +} +

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

On 04/01/2024 21:23, Andi Shyti wrote: Hi Tvrtko, [1] + /* +* Loop over all available slices and assign each a user engine. +* +* With 1 engine (ccs0): +* slice 0, 1, 2, 3: ccs0 +* +* With 2 engines (ccs0, ccs1): +* slice 0,

Re: [PATCH v2 1/3] drm/i915/gt: Support fixed CCS mode

On 04/01/2024 14:35, Andi Shyti wrote: The CCS mode involves assigning CCS engines to slices depending on the number of slices and the number of engines the user wishes to set. In this patch, the default CCS setting is established during the initial GT settings. It involves assigning only one

Re: [RFC] drm/i915: Allow dmabuf mmap forwarding

On 13/12/2023 14:13, Christian König wrote: Am 13.12.23 um 12:46 schrieb Tvrtko Ursulin: Hi, On 12/12/2023 14:10, Christian König wrote: Hi Tvrtko, Thanks for pointing this mail out once more, I've totally missed it. That's okay, if it was really urgent I would have re-raised the thread

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

On 14/12/2023 15:04, Zhao Liu wrote: On Thu, Dec 14, 2023 at 02:35:26PM +, Tvrtko Ursulin wrote: Date: Thu, 14 Dec 2023 14:35:26 + From: Tvrtko Ursulin Subject: Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page() On 14/12/2023 13:45, Tvrtko Ursulin wrote

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

On 14/12/2023 13:45, Tvrtko Ursulin wrote: Hi Zhao, On 14/12/2023 13:19, Zhao Liu wrote: Hi maintainers, Just kindly ping. May I ask if this refresh version could be merged into the next tree of the i915? I certainly spotted your series last week or so but then it slipped my mind to go

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

Hi Zhao, On 14/12/2023 13:19, Zhao Liu wrote: Hi maintainers, Just kindly ping. May I ask if this refresh version could be merged into the next tree of the i915? I certainly spotted your series last week or so but then it slipped my mind to go through it. Should be able to go through it

Re: â Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes

On 13/12/2023 17:24, Tvrtko Ursulin wrote: Hi Andrzej, On 13/12/2023 16:13, Andrzej Hajda wrote: On 13.12.2023 02:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: (stolen) memory region related fixes *URL:*    https://patchwork.freedesktop.org/series/127721/ <ht

Re: â Fi.CI.BAT: failure for drm/i915: (stolen) memory region related fixes

Hi Andrzej, On 13/12/2023 16:13, Andrzej Hajda wrote: On 13.12.2023 02:37, Patchwork wrote: *Patch Details* *Series:*    drm/i915: (stolen) memory region related fixes *URL:*    https://patchwork.freedesktop.org/series/127721/ *State:*   

Re: [RFC] drm/i915: Allow dmabuf mmap forwarding

and no known real use cases affected. Am 12.12.23 um 11:37 schrieb Tvrtko Ursulin: On 25/09/2023 14:16, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Allow mmap forwarding for imported buffers in order to allow minigbm mmap to work on aperture-less platforms such as Meteorlake. So far i915 did

Re: [PATCH] drm/i915/uapi: fix typos/spellos and punctuation

ndy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org --- include/uapi/drm/i915_drm.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff -- a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h --

Re: [RFC] drm/i915: Allow dmabuf mmap forwarding

On 25/09/2023 14:16, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Allow mmap forwarding for imported buffers in order to allow minigbm mmap to work on aperture-less platforms such as Meteorlake. So far i915 did not allow mmap on imported buffers but from minigbm perspective that worked

Re: [PATCH 1/2] drm/i915/selftests: Fix engine reset count storage for multi-tile

On 07/12/2023 11:46, Andi Shyti wrote: On Thu, Dec 07, 2023 at 11:43:28AM +, Tvrtko Ursulin wrote: On 07/12/2023 11:26, Andi Shyti wrote: Hi Tvrtko, Engine->id namespace is per-tile so struct igt_live_test->reset_engine[] needs to be two-dimensional so engine reset counts fr

Re: [PATCH 1/2] drm/i915/selftests: Fix engine reset count storage for multi-tile

counts would be incorrect for same engine instance on different tiles. Signed-off-by: Tvrtko Ursulin Fixes: 0c29efa23f5c ("drm/i915/selftests: Consider multi-gt instead of to_gt()") Reported-by: Alan Previn Teres Alexis Cc: Tejas Upadhyay Cc: Andi Shyti Cc: Daniele Ceraolo Spurio

Re: [PATCH 2/2] drm/i915: Use internal class when counting engine resets

On 06/12/2023 00:52, Daniele Ceraolo Spurio wrote: On 12/1/2023 4:21 AM, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 503579448db9 ("drm/i915/gsc: Mark internal GSC engine with reserved uabi class") made the GSC0 engine not have a valid uabi class and so broke the en

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

On 05/12/2023 10:44, Nirmoy Das wrote: Hi Tvrtko, On 12/5/2023 11:05 AM, Tvrtko Ursulin wrote: On 05/12/2023 08:50, Nirmoy Das wrote: Hi Tvrtko, On 12/5/2023 9:34 AM, Tvrtko Ursulin wrote: On 01/12/2023 15:44, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

On 05/12/2023 08:50, Nirmoy Das wrote: Hi Tvrtko, On 12/5/2023 9:34 AM, Tvrtko Ursulin wrote: On 01/12/2023 15:44, Nirmoy Das wrote: gen8_engine_reset_prepare() can fail when HW fails to set RESET_CTL_READY_TO_RESET bit. In some cases this is not fatal error as driver will retry. Let

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reduce log severity on reset prepare.

or not. No complaints per se but I don't see the caller deciding and it is not really reducing log level but converting to trace. So commit message and patch do not align for me which I think should be improved. Regards, Tvrtko Cc: Tvrtko Ursulin Cc: John Harrison Cc: Andi Shyti Cc

[Intel-gfx] [PATCH 2/2] drm/i915: Use internal class when counting engine resets

From: Tvrtko Ursulin Commit 503579448db9 ("drm/i915/gsc: Mark internal GSC engine with reserved uabi class") made the GSC0 engine not have a valid uabi class and so broke the engine reset counting, which in turn was made class based in cb823ed9915b ("drm/i915/gt: Use intel_gt

[Intel-gfx] [PATCH 1/2] drm/i915/selftests: Fix engine reset count storage for multi-tile

From: Tvrtko Ursulin Engine->id namespace is per-tile so struct igt_live_test->reset_engine[] needs to be two-dimensional so engine reset counts from all tiles can be stored with no aliasing. With aliasing, if we had a real multi-tile platform, the reset counts would be incorrect for same

Re: [Intel-gfx] [PATCH v6] drm/i915: handle uncore spinlock when not available

On 30/11/2023 12:26, Coelho, Luciano wrote: On Thu, 2023-11-30 at 12:21 +, Tvrtko Ursulin wrote: On 30/11/2023 11:35, Luca Coelho wrote: The uncore code may not always be available (e.g. when we build the display code with Xe), so we can't always rely on having the uncore's spinlock

Re: [Intel-gfx] [PATCH v6] drm/i915: handle uncore spinlock when not available

functions and all such logic inside the display code. Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Ville Syrjala Reviewed-by: Rodrigo Vivi Signed-off-by: Luca Coelho --- In v2: * Renamed uncore_spin_*() to intel_spin_*() * Corrected the order: save, lock, unlock, restore In v3

Re: [Intel-gfx] [PATCH v5] drm/i915/pxp: Add drm_dbgs for critical PXP events.

On 22/11/2023 19:15, Alan Previn wrote: Debugging PXP issues can't even begin without understanding precedding sequence of important events. Add drm_dbg into the most important PXP events. v5 : - rebase. v4 : - rebase. v3 : - move gt_dbg to after mutex block in function

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/i915: don't use uncore spinlock to protect critical section in vblank

On 17/11/2023 12:21, Coelho, Luciano wrote: Adding Tvrtko, for some reason he didn't get CCed before. On Fri, 2023-11-17 at 11:26 +0200, Ville Syrjälä wrote: On Fri, Nov 17, 2023 at 10:41:43AM +0200, Ville Syrjälä wrote: On Fri, Nov 17, 2023 at 08:05:21AM +, Coelho, Luciano wrote:

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

On 14/11/2023 19:48, Teres Alexis, Alan Previn wrote: On Tue, 2023-11-14 at 17:52 +, Tvrtko Ursulin wrote: On 14/11/2023 17:37, Teres Alexis, Alan Previn wrote: On Tue, 2023-11-14 at 17:27 +, Tvrtko Ursulin wrote: On 13/11/2023 17:57, Teres Alexis, Alan Previn wrote: On Wed, 2023

[Intel-gfx] [PATCH v2] drm/i915/gsc: Mark internal GSC engine with reserved uabi class

From: Tvrtko Ursulin The GSC CS is not exposed to the user, so we skipped assigning a uabi class number for it. However, the trace logs use the uabi class and instance to identify the engine, so leaving uabi class unset makes the GSC CS show up as the RCS in those logs. Given that the engine

Re: [Intel-gfx] [char-misc-next 3/4] mei: pxp: re-enable client on errors

On 14/11/2023 15:31, Teres Alexis, Alan Previn wrote: On Tue, 2023-11-14 at 16:00 +0200, Ville Syrjälä wrote: On Wed, Oct 11, 2023 at 02:01:56PM +0300, Tomas Winkler wrote: From: Alexander Usyskin Disable and enable mei-pxp client on errors to clean the internal state. This broke i915 on

Re: [Intel-gfx] [PATCH v2] drm/i915: do not clean GT table on error path

enable_rpm_wakeref_asserts(>runtime_pm); i915_driver_late_release(i915); --- base-commit: 1489bab52c281a869295414031a56506a375b036 change-id: 20231114-dont_clean_gt_on_error_path-91cd9c3caa0a Looks okay. Reviewed-by: Tvrtko Ursulin Although on the overall driver init/exit in general

  1   2   3   4   5   6   7   8   9   10   >