Re: [Intel-gfx] [PATCH] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-22 Thread David E. Box
Hi Bjorn, On Wed, 2023-03-22 at 15:57 -0500, Bjorn Helgaas wrote: > On Wed, Mar 22, 2023 at 03:45:01PM -0500, Bjorn Helgaas wrote: > > Hi David, > > > > On Tue, Mar 21, 2023 at 04:38:49PM -0700, David E. Box wrote: > > > The VMD driver calls pci_enabled_link_state as a callback from > > >

Re: [Intel-gfx] [PATCH] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-22 Thread Bjorn Helgaas
On Wed, Mar 22, 2023 at 03:45:01PM -0500, Bjorn Helgaas wrote: > Hi David, > > On Tue, Mar 21, 2023 at 04:38:49PM -0700, David E. Box wrote: > > The VMD driver calls pci_enabled_link_state as a callback from > > pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep > >

Re: [Intel-gfx] [PATCH] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-22 Thread Bjorn Helgaas
Hi David, On Tue, Mar 21, 2023 at 04:38:49PM -0700, David E. Box wrote: > The VMD driver calls pci_enabled_link_state as a callback from > pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep > warning. Add an argument to pci_enable_link_state to set whether the lock > should

[Intel-gfx] [PATCH] PCI/ASPM: pci_enable_link_state: Add argument to acquire bus lock

2023-03-21 Thread David E. Box
The VMD driver calls pci_enabled_link_state as a callback from pci_bus_walk. Both will acquire the pci_bus_sem lock leading to a lockdep warning. Add an argument to pci_enable_link_state to set whether the lock should be acquired. In the VMD driver, set the argument to false since the lock will