Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-28 Thread Hiatt, Don
> > From: Ceraolo Spurio, Daniele > > Sent: Monday, October 28, 2019 11:30 AM > > To: Hiatt, Don ; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o > GuC > > submission but enabled > > >

Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-28 Thread Hiatt, Don
> From: Ceraolo Spurio, Daniele > Sent: Monday, October 28, 2019 11:30 AM > To: Hiatt, Don ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC > submission but enabled > > > > On 10/28/19 11:17 AM,

Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-28 Thread Daniele Ceraolo Spurio
On 10/28/19 11:17 AM, Hiatt, Don wrote: From: Ceraolo Spurio, Daniele Sent: Monday, October 28, 2019 9:44 AM To: Hiatt, Don ; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled On 10/24/19 9:29 AM, don.hi

Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-28 Thread Hiatt, Don
> From: Ceraolo Spurio, Daniele > Sent: Monday, October 28, 2019 9:44 AM > To: Hiatt, Don ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC > submission but enabled > > > > On 10/24/19 9:29 AM, don.hi..

Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-28 Thread Daniele Ceraolo Spurio
On 10/24/19 9:29 AM, don.hi...@intel.com wrote: From: Don Hiatt Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action. You're only skipping the resume, but does it make any sense to do the suspend action if we're not going to call the resume one? Does guc do

Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-24 Thread Hiatt, Don
> On Thu, 2019-10-24 at 09:29 -0700, don.hi...@intel.com wrote: > > From: Don Hiatt > > > > Check to see if GuC submission is enabled before requesting the > > EXIT_S_STATE action. > > > > On some platforms (e.g. KBL) that do not support GuC submission, but > > the user enabled the GuC

Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-24 Thread Summers, Stuart
On Thu, 2019-10-24 at 09:29 -0700, don.hi...@intel.com wrote: > From: Don Hiatt > > Check to see if GuC submission is enabled before requesting the > EXIT_S_STATE action. > > On some platforms (e.g. KBL) that do not support GuC submission, but > the user enabled the GuC communication (e.g for

[Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

2019-10-24 Thread don . hiatt
From: Don Hiatt Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action. On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of