Re: [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local

2020-03-26 Thread Jani Nikula
On Thu, 26 Mar 2020, Chris Wilson wrote: > Beware dereferencing the NULL pointer prior to checking for its > existence. Okay, so the crt code calls ddi functions, and enc_to_dig_port() will return NULL. Backtrace for posterity below, copy-pasted from logs Chris pointed me at. I think

Re: [Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local

2020-03-26 Thread Jani Nikula
On Thu, 26 Mar 2020, Chris Wilson wrote: > Beware dereferencing the NULL pointer prior to checking for its > existence. Huh, I don't see the failure mode. Please enlighten me. BR, Jani. > > Fixes: 419190429cd1 ("drm/i915/hdmi: use struct drm_device based logging") > Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH] drm/i915/display: Remove useless but deadly local

2020-03-26 Thread Chris Wilson
Beware dereferencing the NULL pointer prior to checking for its existence. Fixes: 419190429cd1 ("drm/i915/hdmi: use struct drm_device based logging") Signed-off-by: Chris Wilson Cc: Wambui Karuga Cc: Jani Nikula Cc: "Ville Syrjälä" --- drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++--- 1