Re: [Intel-gfx] [PATCH] drm/i915/dp: Improve clock recovery loop limit comment

2018-07-25 Thread Rodrigo Vivi
On Tue, Jul 24, 2018 at 05:17:53PM -0700, Marc Herbert wrote: > Reviewed-by: Marc Herbert pushed, thanks. > > Thx Nathan, I think this helps. I'm still curious how training normally > converges much faster than the total number of possibilities but - unlike > this latest clarification below - I

Re: [Intel-gfx] [PATCH] drm/i915/dp: Improve clock recovery loop limit comment

2018-07-24 Thread Marc Herbert
Reviewed-by: Marc Herbert Thx Nathan, I think this helps. I'm still curious how training normally converges much faster than the total number of possibilities but - unlike this latest clarification below - I expect the spec(s) to document that. On 24/07/2018 15:33, Nathan Ciobanu wrote: > Clari

[Intel-gfx] [PATCH] drm/i915/dp: Improve clock recovery loop limit comment

2018-07-24 Thread Nathan Ciobanu
Clarifies the clock recovery loop limit comment that 80 max_cr_tries for pre-DP1.4 devices was chosen as a very tolerant upper bound. Assumptions made: - DP1.4 syncs should be smarter so they won't need more than 10 tries - pre-DP1.4 syncs should be compliant enough to not need that many tries (80)