Re: [Intel-gfx] [PATCH] drm/i915/execlists: Remove incorrect BUG_ON for schedule-out

2019-09-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-09-09 11:23:56) > > On 07/09/2019 11:50, Chris Wilson wrote: > > As we may unwind incomplete requests (for preemption) prior to > > processing the CSB and the schedule-out events, we may update rq->engine > > (resetting it to point back to the parent virtual engine)

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Remove incorrect BUG_ON for schedule-out

2019-09-09 Thread Tvrtko Ursulin
On 07/09/2019 11:50, Chris Wilson wrote: As we may unwind incomplete requests (for preemption) prior to processing the CSB and the schedule-out events, we may update rq->engine (resetting it to point back to the parent virtual engine) prior to calling execlists_schedule_out(), invalidating the

[Intel-gfx] [PATCH] drm/i915/execlists: Remove incorrect BUG_ON for schedule-out

2019-09-07 Thread Chris Wilson
As we may unwind incomplete requests (for preemption) prior to processing the CSB and the schedule-out events, we may update rq->engine (resetting it to point back to the parent virtual engine) prior to calling execlists_schedule_out(), invalidating the assertion that the request still points to