Re: [Intel-gfx] [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

2017-04-28 Thread Ander Conselvan De Oliveira
On Fri, 2017-04-28 at 12:44 +, Chauhan, Madhav wrote: > > -Original Message- > > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > > Sent: Friday, April 28, 2017 2:28 PM > > To: Chauhan, Madhav ; intel- > > g...@lists.freedesktop.org > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

2017-04-28 Thread Chauhan, Madhav
> -Original Message- > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > Sent: Friday, April 28, 2017 2:28 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Deepak M ; Nikula, Jani ; >

Re: [Intel-gfx] [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

2017-04-28 Thread Ander Conselvan De Oliveira
On Fri, 2017-04-28 at 08:50 +, Chauhan, Madhav wrote: > > -Original Message- > > From: Conselvan De Oliveira, Ander > > Sent: Friday, April 28, 2017 1:32 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Conselvan De Oliveira, Ander ; > > Deepak

Re: [Intel-gfx] [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

2017-04-28 Thread Chauhan, Madhav
> -Original Message- > From: Conselvan De Oliveira, Ander > Sent: Friday, April 28, 2017 1:32 PM > To: intel-gfx@lists.freedesktop.org > Cc: Conselvan De Oliveira, Ander ; > Deepak M ; Chauhan, Madhav > ;

[Intel-gfx] [PATCH] drm/i915/glk: Fix DSI "*ERROR* ULPS is still active" messages

2017-04-28 Thread Ander Conselvan de Oliveira
The sequence in glk_dsi_device_ready() enters ULPS then waits until it is *not* active to then disable it. The correct sequence according to the spec is to enter ULPS then wait until the GLK_ULPS_NOT_ACTIVE bit is zero, i.e., ULPS is active, and then disable ULPS. Fixing the codition gets rid of