Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Belgaumkar, Vinay
On 7/21/2023 3:08 PM, Belgaumkar, Vinay wrote: On 7/21/2023 2:23 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 01:44:34PM -0700, Belgaumkar, Vinay wrote: On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: This should be done before

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Belgaumkar, Vinay
On 7/21/2023 2:23 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 01:44:34PM -0700, Belgaumkar, Vinay wrote: On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: This should be done before the soft min/max frequencies are restored. When

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Rodrigo Vivi
On Fri, Jul 21, 2023 at 01:44:34PM -0700, Belgaumkar, Vinay wrote: > > On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: > > On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: > > > This should be done before the soft min/max frequencies are restored. > > > When we disable the "Ignore effic

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Belgaumkar, Vinay
On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: This should be done before the soft min/max frequencies are restored. When we disable the "Ignore efficient frequency" flag, GuC does not actually bring the requested freq down to RPn.

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Rodrigo Vivi
On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: > This should be done before the soft min/max frequencies are restored. > When we disable the "Ignore efficient frequency" flag, GuC does not > actually bring the requested freq down to RPn. > > Specifically, this scenario- > > - i

[Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Vinay Belgaumkar
This should be done before the soft min/max frequencies are restored. When we disable the "Ignore efficient frequency" flag, GuC does not actually bring the requested freq down to RPn. Specifically, this scenario- - ignore efficient freq set to true - reduce min to RPn (from efficient) - suspend