Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable preemption if it fails

2018-06-01 Thread Jeff McGee
On Thu, May 31, 2018 at 10:20:54PM +0100, Chris Wilson wrote: > Quoting Singh, Satyeshwar (2018-05-31 22:17:25) > > Hi Chris, > > Isn't this dependent upon the workload submitted to the GuC? Meaning we > > have one workload that refused to be preempted (really long shader for > > example) but it

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable preemption if it fails

2018-05-31 Thread Chris Wilson
Quoting Singh, Satyeshwar (2018-05-31 22:17:25) > Hi Chris, > Isn't this dependent upon the workload submitted to the GuC? Meaning we have > one workload that refused to be preempted (really long shader for example) > but it went away on its own. Other workloads that come in later are >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable preemption if it fails

2018-05-31 Thread Singh, Satyeshwar
-gfx] [PATCH] drm/i915/guc: Disable preemption if it fails If we fail to tell the GuC to perform preemption, we get stuck attempting to continually retry inject_preempt_context() until we eventually timeout and reset the GPU (approximately emitting the same warning 1000 times). Bail after

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable preemption if it fails

2018-05-31 Thread Michel Thierry
On 5/31/2018 1:47 PM, Chris Wilson wrote: If we fail to tell the GuC to perform preemption, we get stuck attempting to continually retry inject_preempt_context() until we eventually timeout and reset the GPU (approximately emitting the same warning 1000 times). Bail after the first failure, emit

[Intel-gfx] [PATCH] drm/i915/guc: Disable preemption if it fails

2018-05-31 Thread Chris Wilson
If we fail to tell the GuC to perform preemption, we get stuck attempting to continually retry inject_preempt_context() until we eventually timeout and reset the GPU (approximately emitting the same warning 1000 times). Bail after the first failure, emit the WARN and stop trying to do any further