Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Don't use FIELD_PREP

2022-11-02 Thread Dixit, Ashutosh
On Tue, 01 Nov 2022 03:58:13 -0700, Jani Nikula wrote: > > On Mon, 31 Oct 2022, Ashutosh Dixit wrote: > > FIELD_PREP and REG_FIELD_PREP have checks requiring a compile time constant > > mask. When the mask comes in as the argument of a function these checks can > > can fail depending on the

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Don't use FIELD_PREP

2022-11-01 Thread Jani Nikula
On Mon, 31 Oct 2022, Ashutosh Dixit wrote: > FIELD_PREP and REG_FIELD_PREP have checks requiring a compile time constant > mask. When the mask comes in as the argument of a function these checks can > can fail depending on the compiler (gcc vs clang), optimization level, > etc. Use a simpler

[Intel-gfx] [PATCH] drm/i915/hwmon: Don't use FIELD_PREP

2022-10-31 Thread Ashutosh Dixit
FIELD_PREP and REG_FIELD_PREP have checks requiring a compile time constant mask. When the mask comes in as the argument of a function these checks can can fail depending on the compiler (gcc vs clang), optimization level, etc. Use a simpler version of FIELD_PREP which skips these checks. The

[Intel-gfx] [PATCH] drm/i915/hwmon: Don't use FIELD_PREP

2022-10-30 Thread Ashutosh Dixit
FIELD_PREP and REG_FIELD_PREP have checks requiring a compile time constant mask. When the mask comes in as the argument of a function these checks can can fail depending on the compiler (gcc vs clang), optimization level, etc. Use a simpler local version of FIELD_PREP which skips these checks.