Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-08-07 Thread Chris Wilson
Quoting Umesh Nerlige Ramappa (2019-08-07 00:30:02) > The oa object manages the oa buffer and must be allocated when the user > intends to read performance counter snapshots. This can be achieved by > making the oa object part of the stream object which is allocated when a > stream is opened by the

[Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-08-06 Thread Umesh Nerlige Ramappa
The oa object manages the oa buffer and must be allocated when the user intends to read performance counter snapshots. This can be achieved by making the oa object part of the stream object which is allocated when a stream is opened by the user. Attributes in the oa object that are gen-specific ar

[Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-08-05 Thread Umesh Nerlige Ramappa
The oa object manages the oa buffer and must be allocated when the user intends to read performance counter snapshots. This can be achieved by making the oa object part of the stream object which is allocated when a stream is opened by the user. Attributes in the oa object that are gen-specific ar

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-16 Thread Lionel Landwerlin
Hi Umesh, This v3 looks good to me. I've left some nits below, but with or with them applied this is : Reviewed-by: Lionel Landwerlin On 15/05/2019 19:07, Umesh Nerlige Ramappa wrote: The oa object manages the oa buffer and must be allocated when the user intends to read performance counter

[Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-15 Thread Umesh Nerlige Ramappa
The oa object manages the oa buffer and must be allocated when the user intends to read performance counter snapshots. This can be achieved by making the oa object part of the stream object which is allocated when a stream is opened by the user. Attributes in the oa object that are gen-specific ar

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-15 Thread Umesh Nerlige Ramappa
On Wed, May 15, 2019 at 10:11:34AM +0100, Lionel Landwerlin wrote: On 14/05/2019 19:14, Umesh Nerlige Ramappa wrote: On Tue, May 14, 2019 at 10:34:49AM +0100, Lionel Landwerlin wrote: Hi Umesh, I just noticed this different between v1 & v2. My understanding is that if destroy() is called, stre

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-15 Thread Lionel Landwerlin
On 14/05/2019 19:14, Umesh Nerlige Ramappa wrote: On Tue, May 14, 2019 at 10:34:49AM +0100, Lionel Landwerlin wrote: Hi Umesh, I just noticed this different between v1 & v2. My understanding is that if destroy() is called, stream should be the same as dev_priv->perf.exclusive_stream. If it's

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-14 Thread Umesh Nerlige Ramappa
On Tue, May 14, 2019 at 10:34:49AM +0100, Lionel Landwerlin wrote: Hi Umesh, I just noticed this different between v1 & v2. My understanding is that if destroy() is called, stream should be the same as dev_priv->perf.exclusive_stream. If it's not it sounds like a bug. So why change this? v2 f

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-14 Thread Lionel Landwerlin
Hi Umesh, I just noticed this different between v1 & v2. My understanding is that if destroy() is called, stream should be the same as dev_priv->perf.exclusive_stream. If it's not it sounds like a bug. So why change this? -Lionel On 03/05/2019 00:13, Umesh Nerlige Ramappa wrote: static voi

[Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-02 Thread Umesh Nerlige Ramappa
The oa object manages the oa buffer and must be allocated when the user intends to read performance counter snapshots. This can be achieved by making the oa object part of the stream object which is allocated when a stream is opened by the user. Attributes in the oa object that are gen-specific ar

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-02 Thread Lionel Landwerlin
On 01/05/2019 17:50, Umesh Nerlige Ramappa wrote: The oa object manages the oa buffer and must be allocated when the user intends to read performance counter snapshots. This can be achieved by making the oa object part of the stream object which is allocated when a stream is opened by the user.

[Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-01 Thread Umesh Nerlige Ramappa
The oa object manages the oa buffer and must be allocated when the user intends to read performance counter snapshots. This can be achieved by making the oa object part of the stream object which is allocated when a stream is opened by the user. Attributes in the oa object that are gen-specific ar