Re: [Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-10-02 Thread Jani Nikula
On Fri, 29 Sep 2017, Joonas Lahtinen wrote: > On Wed, 2017-09-27 at 12:32 -0700, Rodrigo Vivi wrote: >> On Wed, Sep 27, 2017 at 12:03 AM, Jani Nikula >> wrote: >> > On Tue, 26 Sep 2017, Rodrigo Vivi wrote: >>

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-09-29 Thread Joonas Lahtinen
On Wed, 2017-09-27 at 12:32 -0700, Rodrigo Vivi wrote: > On Wed, Sep 27, 2017 at 12:03 AM, Jani Nikula > wrote: > > On Tue, 26 Sep 2017, Rodrigo Vivi wrote: > > > On Tue, Sep 26, 2017 at 09:21:43PM +, Paulo Zanoni wrote: > > > > Em Ter,

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-09-27 Thread Rodrigo Vivi
On Wed, Sep 27, 2017 at 12:03 AM, Jani Nikula wrote: > On Tue, 26 Sep 2017, Rodrigo Vivi wrote: >> On Tue, Sep 26, 2017 at 09:21:43PM +, Paulo Zanoni wrote: >>> Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu: >>> > Let's stop

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-09-27 Thread Jani Nikula
On Tue, 26 Sep 2017, Rodrigo Vivi wrote: > On Tue, Sep 26, 2017 at 09:21:43PM +, Paulo Zanoni wrote: >> Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu: >> > Let's stop this usage before it spreads so much. >> > >> > 1. This check is not part of usual

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-09-26 Thread Rodrigo Vivi
On Tue, Sep 26, 2017 at 09:21:43PM +, Paulo Zanoni wrote: > Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu: > > Let's stop this usage before it spreads so much. > > > > 1. This check is not part of usual searches happening when adding > > new platform. > > 2. There is already a

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-09-26 Thread Matt Roper
On Tue, Sep 26, 2017 at 02:13:46PM -0700, Rodrigo Vivi wrote: > Let's stop this usage before it spreads so much. > > 1. This check is not part of usual searches happening when adding > new platform. > 2. There is already a duplication here with INTEL_INFO(dev_priv)->gen > and INTEL_GEN(dev_priv).

Re: [Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-09-26 Thread Paulo Zanoni
Em Ter, 2017-09-26 às 14:13 -0700, Rodrigo Vivi escreveu: > Let's stop this usage before it spreads so much. > > 1. This check is not part of usual searches happening when adding > new platform. > 2. There is already a duplication here with INTEL_INFO(dev_priv)->gen > and INTEL_GEN(dev_priv). >

[Intel-gfx] [PATCH] drm/i915: Avoid using dev_priv->info.gen directly.

2017-09-26 Thread Rodrigo Vivi
Let's stop this usage before it spreads so much. 1. This check is not part of usual searches happening when adding new platform. 2. There is already a duplication here with INTEL_INFO(dev_priv)->gen and INTEL_GEN(dev_priv). So let's please avoid yet another way. Fixes: b22ca995ba1c ("drm/i915: