Re: [Intel-gfx] [PATCH] drm/i915: Disable full ppgtt by default

2014-03-18 Thread Daniel Vetter
On Thu, Mar 06, 2014 at 09:30:01PM +0100, Daniel Vetter wrote: On Thu, Mar 06, 2014 at 10:17:12AM -0800, Ben Widawsky wrote: On Thu, Mar 06, 2014 at 12:14:21PM +0100, Daniel Vetter wrote: There are too many oustanding issues: - Fence handling in the current code is broken. There's a

[Intel-gfx] [PATCH] drm/i915: Disable full ppgtt by default

2014-03-06 Thread Daniel Vetter
There are too many oustanding issues: - Fence handling in the current code is broken. There's a patch series from me, but it's blocked on and extended review (which includes writing the testcases). - IOMMU mapping handling is broken, we need to properly refcount it - currently it gets

Re: [Intel-gfx] [PATCH] drm/i915: Disable full ppgtt by default

2014-03-06 Thread Ben Widawsky
On Thu, Mar 06, 2014 at 12:14:21PM +0100, Daniel Vetter wrote: There are too many oustanding issues: - Fence handling in the current code is broken. There's a patch series from me, but it's blocked on and extended review (which includes writing the testcases). - IOMMU mapping handling

Re: [Intel-gfx] [PATCH] drm/i915: Disable full ppgtt by default

2014-03-06 Thread Jesse Barnes
On Thu, 6 Mar 2014 12:14:21 +0100 Daniel Vetter daniel.vet...@ffwll.ch wrote: There are too many oustanding issues: - Fence handling in the current code is broken. There's a patch series from me, but it's blocked on and extended review (which includes writing the testcases). - IOMMU

Re: [Intel-gfx] [PATCH] drm/i915: Disable full ppgtt by default

2014-03-06 Thread Daniel Vetter
On Thu, Mar 06, 2014 at 10:17:12AM -0800, Ben Widawsky wrote: On Thu, Mar 06, 2014 at 12:14:21PM +0100, Daniel Vetter wrote: There are too many oustanding issues: - Fence handling in the current code is broken. There's a patch series from me, but it's blocked on and extended review

Re: [Intel-gfx] [PATCH] drm/i915: Disable full ppgtt by default

2014-03-06 Thread Daniel Vetter
On Thu, Mar 6, 2014 at 9:30 PM, Daniel Vetter dan...@ffwll.ch wrote: * Aliasing PPGTT real address treatment: What do you want? i915_gem_context_free in i195_gem_context.c has a comment: /* We refcount even the aliasing PPGTT to keep the code symmetric */ That comment is a lie and

Re: [Intel-gfx] [PATCH] drm/i915: Disable full ppgtt by default

2014-03-06 Thread Ben Widawsky
On Thu, Mar 06, 2014 at 09:30:01PM +0100, Daniel Vetter wrote: On Thu, Mar 06, 2014 at 10:17:12AM -0800, Ben Widawsky wrote: On Thu, Mar 06, 2014 at 12:14:21PM +0100, Daniel Vetter wrote: There are too many oustanding issues: - Fence handling in the current code is broken. There's a