Re: [Intel-gfx] [PATCH] drm/i915: Don't overwrite (e)DP PLL selection on SKL

2015-05-18 Thread Daniel Vetter
On Fri, May 15, 2015 at 12:19:12PM +0100, Damien Lespiau wrote: On Fri, May 15, 2015 at 01:34:29PM +0300, Ander Conselvan de Oliveira wrote: In the following commit, the place where the contents of dpll_hw_state in crtc_state where zeroed was changed. Prior to that commit, it happened when

Re: [Intel-gfx] [PATCH] drm/i915: Don't overwrite (e)DP PLL selection on SKL

2015-05-18 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6417 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH] drm/i915: Don't overwrite (e)DP PLL selection on SKL

2015-05-15 Thread Tvrtko Ursulin
Hi, On 05/15/2015 11:34 AM, Ander Conselvan de Oliveira wrote: In the following commit, the place where the contents of dpll_hw_state in crtc_state where zeroed was changed. Prior to that commit, it happened when the new state was allocated, but now that happens just before the call the

[Intel-gfx] [PATCH] drm/i915: Don't overwrite (e)DP PLL selection on SKL

2015-05-15 Thread Ander Conselvan de Oliveira
In the following commit, the place where the contents of dpll_hw_state in crtc_state where zeroed was changed. Prior to that commit, it happened when the new state was allocated, but now that happens just before the call the .crtc_compute_clock() hook. The DP code for SKL, however, sets up the

Re: [Intel-gfx] [PATCH] drm/i915: Don't overwrite (e)DP PLL selection on SKL

2015-05-15 Thread Ander Conselvan De Oliveira
On Fri, 2015-05-15 at 13:56 +0300, Jani Nikula wrote: On Fri, 15 May 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: In the following commit, the place where the contents of dpll_hw_state in crtc_state where zeroed was changed. Prior to that commit, it

Re: [Intel-gfx] [PATCH] drm/i915: Don't overwrite (e)DP PLL selection on SKL

2015-05-15 Thread Jani Nikula
On Fri, 15 May 2015, Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com wrote: In the following commit, the place where the contents of dpll_hw_state in crtc_state where zeroed was changed. Prior to that commit, it happened when the new state was allocated, but now that happens

Re: [Intel-gfx] [PATCH] drm/i915: Don't overwrite (e)DP PLL selection on SKL

2015-05-15 Thread Damien Lespiau
On Fri, May 15, 2015 at 01:34:29PM +0300, Ander Conselvan de Oliveira wrote: In the following commit, the place where the contents of dpll_hw_state in crtc_state where zeroed was changed. Prior to that commit, it happened when the new state was allocated, but now that happens just before the