Re: [Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display.

2017-10-17 Thread Puthikorn Voravootivat
Hi Rodrigo The previous email (quote below) is tested with that patch applied. >> >> > lane_align = dp_link_status(link_status, >> >> >DP_LANE_ALIGN_STATUS_UPDATED); >> >> > if ((lane_align & DP_INTERLANE_ALIGN_DONE) == 0) >> >> >return false; >> >> >> >> I always got lane_align = 128

Re: [Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display.

2017-10-17 Thread Rodrigo Vivi
Puthikorn, could you please test the patch Manasi had pointed out [1] to see if that solves your issue instead of your patch? If that one solves it you put a Tested-by on that one to help that getting merged. If that is not the case so we need to hunt down PSR2 bugs that are killing the link

Re: [Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display.

2017-10-17 Thread Puthikorn Voravootivat
+ Vathsala for PSR related code. On Tue, Oct 17, 2017 at 4:29 PM, Manasi Navare wrote: > On Tue, Oct 17, 2017 at 03:46:00PM -0700, Puthikorn Voravootivat wrote: >> I tried https://patchwork.freedesktop.org/series/30670/ but it doesn't work. >> >> > When you see the

Re: [Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display.

2017-10-17 Thread Manasi Navare
On Tue, Oct 17, 2017 at 03:46:00PM -0700, Puthikorn Voravootivat wrote: > I tried https://patchwork.freedesktop.org/series/30670/ but it doesn't work. > > > When you see the display blinking, do you know for sure that > > drm_dp_channel_eq_ok() returns false? > Yes. Repro is running "modetest"

Re: [Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display.

2017-10-17 Thread Puthikorn Voravootivat
I tried https://patchwork.freedesktop.org/series/30670/ but it doesn't work. > When you see the display blinking, do you know for sure that > drm_dp_channel_eq_ok() returns false? Yes. Repro is running "modetest" while PSR is on (easier to repro with PSR2 but PSR1 is fine too) > lane_align =

Re: [Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display.

2017-10-17 Thread Manasi Navare
On Tue, Oct 17, 2017 at 02:01:56PM -0700, Puthikorn Voravootivat wrote: > intel_dp_long_pulse() is always checking link status because > there has been known issues of link loss triggerring long pulse. > > However this is not needed for eDP display since we won't have > link loss for internal

[Intel-gfx] [PATCH] drm/i915: Don't recheck link status for eDP display.

2017-10-17 Thread Puthikorn Voravootivat
intel_dp_long_pulse() is always checking link status because there has been known issues of link loss triggerring long pulse. However this is not needed for eDP display since we won't have link loss for internal display. Also there are reports that screens are flickering during link status check.