Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist
creation")
Signed-off-by: Cong Liu
---
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
Hi Andi,
thank you for your reminder, next time I will pay attention to my
format, and when someone has already
reviewed, add the Reviewed-by field
Regards.
On 2023/4/13 16:44, Andi Shyti wrote:
On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote:
This patch fixes memory leaks on
This patch fixes memory leaks on error escapes in function fake_get_pages
Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist
creation")
Signed-off-by: Cong Liu
---
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote:
> This patch fixes memory leaks on error escapes in function fake_get_pages
>
> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist
> creation")
> Signed-off-by: Cong Liu
OK, while I was proposing the adjustments
Hi Cong,
> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist
> creation")
>
> Signed-off-by: Cong Liu
As Jani suggested we need a commit message here. Would something
like this work for you?
"
We forget to free 'pages' after checking for overflow. Be sure to
On Thu, 13 Apr 2023, Andrzej Hajda wrote:
> On 13.04.2023 05:13, Cong Liu wrote:
A commit message is still needed.
>> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist
>> creation")
>>
No blank line here.
BR,
Jani.
>> Signed-off-by: Cong Liu
>> ---
>
>
On 13.04.2023 05:13, Cong Liu wrote:
Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist
creation")
Signed-off-by: Cong Liu
---
Reviewed-by: Andrzej Hajda
Regards
Andrzej
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
1 file changed, 3
