; VAT No: 860 2173 47
>
> > -Original Message-
> > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf
> > Of Ben Widawsky
> > Sent: Saturday, June 28, 2014 10:56 PM
> > To: Chris Wilson; Rodrigo Vivi; Widawsky, Benjamin; Intel GFX
> >
op.org] On Behalf
> Of Ben Widawsky
> Sent: Saturday, June 28, 2014 10:56 PM
> To: Chris Wilson; Rodrigo Vivi; Widawsky, Benjamin; Intel GFX
> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix some NUM_RING iterators
>
> On Sat, Jun 28, 2014 at 08:28:55PM +0100, Chris Wilson wrote:
On Sat, Jun 28, 2014 at 08:28:55PM +0100, Chris Wilson wrote:
> On Sat, Jun 28, 2014 at 08:26:15AM -0700, Ben Widawsky wrote:
> > On Sat, Jun 28, 2014 at 07:20:38AM +0100, Chris Wilson wrote:
> > > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c
> > > > b/drivers/gpu/drm/i915/i915_gp
On Sat, Jun 28, 2014 at 08:26:15AM -0700, Ben Widawsky wrote:
> On Sat, Jun 28, 2014 at 07:20:38AM +0100, Chris Wilson wrote:
> > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c
> > > b/drivers/gpu/drm/i915/i915_gpu_error.c
> > > index 86362de..6e5250d 100644
> > > --- a/dr
On Sat, Jun 28, 2014 at 07:20:38AM +0100, Chris Wilson wrote:
> On Fri, Jun 27, 2014 at 03:21:20PM -0700, Rodrigo Vivi wrote:
> >Reviewed-by: Rodrigo Vivi <[1]rodrigo.v...@intel.com>
> >
> >On Fri, Jun 27, 2014 at 3:09 PM, Ben Widawsky
> ><[2]benjamin.widaw...@intel.com> wrote:
> >
>
On Fri, Jun 27, 2014 at 03:21:20PM -0700, Rodrigo Vivi wrote:
>Reviewed-by: Rodrigo Vivi <[1]rodrigo.v...@intel.com>
>
>On Fri, Jun 27, 2014 at 3:09 PM, Ben Widawsky
><[2]benjamin.widaw...@intel.com> wrote:
>
> There are some cases in the code where we need to know how many rings
On Fri, Jun 27, 2014 at 03:21:20PM -0700, Rodrigo Vivi wrote:
> Reviewed-by: Rodrigo Vivi
>
I have a couple of spots that I think are important to add, all in error
state. I'll repost v2 after I can actually test it.
[snip]
--
Ben Widawsky, Intel Open Source Technology Center
___
Reviewed-by: Rodrigo Vivi
On Fri, Jun 27, 2014 at 3:09 PM, Ben Widawsky
wrote:
> There are some cases in the code where we need to know how many rings to
> iterate over, but cannot use for_each_ring(). These are always error cases
> which happen either before ring setup, or after ring teardown
There are some cases in the code where we need to know how many rings to
iterate over, but cannot use for_each_ring(). These are always error cases
which happen either before ring setup, or after ring teardown (or
reset).
Note, a NUM_RINGS issue exists in semaphores, but this is fixed by the
remai
