Re: [Intel-gfx] [PATCH] drm/i915: Flush the RPS bottom-half when the GPU idles

2015-12-10 Thread Chris Wilson
On Thu, Dec 10, 2015 at 12:02:55AM +0200, Imre Deak wrote: > On Wed, 2015-12-09 at 20:52 +, Chris Wilson wrote: > > On Wed, Dec 09, 2015 at 07:47:29PM +0200, Imre Deak wrote: > > > >  void gen6_rps_idle(struct drm_i915_private *dev_priv) > > > >  { > > > > - struct drm_device *dev =

[Intel-gfx] [PATCH] drm/i915: Flush the RPS bottom-half when the GPU idles

2015-12-09 Thread Chris Wilson
Make sure that the RPS bottom-half is flushed before we set the idle frequency when we decide the GPU is idle. This should prevent any races with the bottom-half and setting the idle frequency, and ensures that the bottom-half is bounded by the GPU's rpm reference taken for when it is active (i.e.

Re: [Intel-gfx] [PATCH] drm/i915: Flush the RPS bottom-half when the GPU idles

2015-12-09 Thread Imre Deak
On Wed, 2015-12-09 at 20:52 +, Chris Wilson wrote: > On Wed, Dec 09, 2015 at 07:47:29PM +0200, Imre Deak wrote: > > >  void gen6_rps_idle(struct drm_i915_private *dev_priv) > > >  { > > > - struct drm_device *dev = dev_priv->dev; > > > + /* Flush our bottom-half so that it does not race with >

Re: [Intel-gfx] [PATCH] drm/i915: Flush the RPS bottom-half when the GPU idles

2015-12-09 Thread Chris Wilson
On Wed, Dec 09, 2015 at 07:47:29PM +0200, Imre Deak wrote: > >  void gen6_rps_idle(struct drm_i915_private *dev_priv) > >  { > > - struct drm_device *dev = dev_priv->dev; > > + /* Flush our bottom-half so that it does not race with us > > +  * setting the idle frequency and so that it is

Re: [Intel-gfx] [PATCH] drm/i915: Flush the RPS bottom-half when the GPU idles

2015-12-09 Thread Jesse Barnes
On 12/09/2015 09:10 AM, Chris Wilson wrote: > Make sure that the RPS bottom-half is flushed before we set the idle > frequency when we decide the GPU is idle. This should prevent any races > with the bottom-half and setting the idle frequency, and ensures that > the bottom-half is bounded by the