Re: [Intel-gfx] [PATCH] drm/i915: Pevent copying uninitialised garbage into vma->ggtt_view

2017-01-23 Thread Chris Wilson
On Mon, Jan 23, 2017 at 03:01:20PM +, Matthew Auld wrote: > On 23 January 2017 at 14:52, Chris Wilson wrote: > > Since tweaking i915_vma_compare() we allowed constructors to skip > > clearing the ggtt_view believing that we didn't access the unused > > members. That,

Re: [Intel-gfx] [PATCH] drm/i915: Pevent copying uninitialised garbage into vma->ggtt_view

2017-01-23 Thread Matthew Auld
On 23 January 2017 at 14:52, Chris Wilson wrote: > Since tweaking i915_vma_compare() we allowed constructors to skip > clearing the ggtt_view believing that we didn't access the unused > members. That, as it turns out, was not entirely true. In particular, >

[Intel-gfx] [PATCH] drm/i915: Pevent copying uninitialised garbage into vma->ggtt_view

2017-01-23 Thread Chris Wilson
Since tweaking i915_vma_compare() we allowed constructors to skip clearing the ggtt_view believing that we didn't access the unused members. That, as it turns out, was not entirely true. In particular, i915_gem_fault() uses ret = remap_io_mapping(area, area->vm_start +