Re: [Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-08-25 Thread Chris Wilson
On Mon, Aug 25, 2014 at 02:00:17AM +0200, Daniel Vetter wrote: On Sun, Aug 24, 2014 at 5:40 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, May 23, 2014 at 08:48:08AM +0200, Daniel Vetter wrote: - Apply the batch offset bias everywhere but mention that we've only observed it on

Re: [Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-08-24 Thread Chris Wilson
On Fri, May 23, 2014 at 08:48:08AM +0200, Daniel Vetter wrote: - Apply the batch offset bias everywhere but mention that we've only observed it on gen7 gpus. +static struct drm_i915_gem_object * +eb_get_batch(struct eb_vmas *eb) +{ + struct i915_vma *vma = list_entry(eb-vmas.prev,

Re: [Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-08-24 Thread Daniel Vetter
On Sun, Aug 24, 2014 at 5:40 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Fri, May 23, 2014 at 08:48:08AM +0200, Daniel Vetter wrote: - Apply the batch offset bias everywhere but mention that we've only observed it on gen7 gpus. +static struct drm_i915_gem_object *

[Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-23 Thread Daniel Vetter
From: Chris Wilson ch...@chris-wilson.co.uk This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These batches also contain self-referenced relocations as a single buffer encompasses the state

[Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Chris Wilson
This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These batches also contain self-referenced relocations as a single buffer encompasses the state commands, kernels, vertices and sampler.

[Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Chris Wilson
This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These batches also contain self-referenced relocations as a single buffer encompasses the state commands, kernels, vertices and sampler.

Re: [Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 01:17:12PM +0100, Chris Wilson wrote: This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These batches also contain self-referenced relocations as a single buffer

Re: [Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Chris Wilson
On Thu, May 15, 2014 at 02:46:32PM +0200, Daniel Vetter wrote: On Thu, May 15, 2014 at 01:17:12PM +0100, Chris Wilson wrote: This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These