Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread Daniel Vetter
On Wed, Mar 11, 2015 at 06:58:12PM +0200, Ville Syrjälä wrote: > On Wed, Mar 11, 2015 at 11:37:54AM +, Conselvan De Oliveira, Ander wrote: > > On Wed, 2015-03-11 at 13:35 +0200, Ander Conselvan de Oliveira wrote: > > > Remove the global modeset resource function that would disable the > > > bif

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5933 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -3 281/281

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread Ville Syrjälä
On Wed, Mar 11, 2015 at 11:37:54AM +, Conselvan De Oliveira, Ander wrote: > On Wed, 2015-03-11 at 13:35 +0200, Ander Conselvan de Oliveira wrote: > > Remove the global modeset resource function that would disable the > > bifurcation bit, and instead enable/disable it when enabling the pch > > t

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread Conselvan De Oliveira, Ander
On Wed, 2015-03-11 at 15:10 +0200, Ville Syrjälä wrote: > On Wed, Mar 11, 2015 at 01:35:43PM +0200, Ander Conselvan de Oliveira wrote: > > Remove the global modeset resource function that would disable the > > bifurcation bit, and instead enable/disable it when enabling the pch > > transcoder. The

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread Ville Syrjälä
On Wed, Mar 11, 2015 at 01:35:43PM +0200, Ander Conselvan de Oliveira wrote: > Remove the global modeset resource function that would disable the > bifurcation bit, and instead enable/disable it when enabling the pch > transcoder. The mode set consistency check should prevent us from > disabling th

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread Ville Syrjälä
On Wed, Mar 11, 2015 at 01:35:43PM +0200, Ander Conselvan de Oliveira wrote: > Remove the global modeset resource function that would disable the > bifurcation bit, and instead enable/disable it when enabling the pch > transcoder. The mode set consistency check should prevent us from > disabling th

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread Conselvan De Oliveira, Ander
On Wed, 2015-03-11 at 13:35 +0200, Ander Conselvan de Oliveira wrote: > Remove the global modeset resource function that would disable the > bifurcation bit, and instead enable/disable it when enabling the pch > transcoder. The mode set consistency check should prevent us from > disabling the bit i

[Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-11 Thread Ander Conselvan de Oliveira
Remove the global modeset resource function that would disable the bifurcation bit, and instead enable/disable it when enabling the pch transcoder. The mode set consistency check should prevent us from disabling the bit if pipe C is enabled so the change should be safe. Note that this doens't affe

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-10 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5925 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 282/282

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-10 Thread Daniel Vetter
On Tue, Mar 10, 2015 at 03:03:59PM +0200, Ville Syrjälä wrote: > On Tue, Mar 10, 2015 at 02:32:34PM +0200, Ander Conselvan de Oliveira wrote: > > Remove the global modeset resource function that would disable the > > bifurcation bit, and instead enable/disable it when enabling or > > disabling the

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-10 Thread Daniel Vetter
On Tue, Mar 10, 2015 at 02:32:34PM +0200, Ander Conselvan de Oliveira wrote: > Remove the global modeset resource function that would disable the > bifurcation bit, and instead enable/disable it when enabling or > disabling the pch transcoder. The checks before the mode set should > ensure that the

Re: [Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-10 Thread Ville Syrjälä
On Tue, Mar 10, 2015 at 02:32:34PM +0200, Ander Conselvan de Oliveira wrote: > Remove the global modeset resource function that would disable the > bifurcation bit, and instead enable/disable it when enabling or > disabling the pch transcoder. The checks before the mode set should > ensure that the

[Intel-gfx] [PATCH] drm/i915: Simplify the way BC bifurcation state consistency is kept

2015-03-10 Thread Ander Conselvan de Oliveira
Remove the global modeset resource function that would disable the bifurcation bit, and instead enable/disable it when enabling or disabling the pch transcoder. The checks before the mode set should ensure that the configuration is valid, so it should be safe to do it so. Signed-off-by: Ander Cons