Re: [Intel-gfx] [PATCH] drm/i915: Skip the ERR_PTR error state

2018-12-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-12-07 10:45:17) > > @@ -1941,15 +1948,9 @@ void i915_capture_error_state(struct > > drm_i915_private *i915, > > if (!i915_modparams.error_capture) > > return; > > > > - if (READ_ONCE(i915->gpu_error.first_error)) > > - return; > >

Re: [Intel-gfx] [PATCH] drm/i915: Skip the ERR_PTR error state

2018-12-07 Thread Tvrtko Ursulin
On 07/12/2018 09:16, Chris Wilson wrote: Although commit fb6f0b64e455 ("drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture") applied cleanly after a 24 month hiatus, the code had moved on with new methods for peeking and fetching the captured gpu info. Make sure we catch all

[Intel-gfx] [PATCH] drm/i915: Skip the ERR_PTR error state

2018-12-07 Thread Chris Wilson
Although commit fb6f0b64e455 ("drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture") applied cleanly after a 24 month hiatus, the code had moved on with new methods for peeking and fetching the captured gpu info. Make sure we catch all uses of the stashed error state and avoid d