Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-10 Thread Chiou, Cooper
Thanks Ville, I'll backport your patch (drm/i915/vbt: Fix HDMI level shifter and max data rate bitfield sizes) to CrOS kernel for resolving this issue. Please abandon my patch. Best Regards, Cooper ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-10 Thread Ville Syrjälä
On Wed, Apr 10, 2019 at 11:32:47AM +, Chiou, Cooper wrote: > Hi Ville, > > > > From BSpec define, HDMI max data rate is “Bits 5-7” not Bits 4-7. And the > following image is what I captured by latest VBT BMP v2.67 tool to load GLK > VBT bin file and changed HDMI_MAX_TMDS_Bit_Rate field in

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-10 Thread Ville Syrjälä
ernel: [0.172369] Missing switch case (4) in parse_ddi_port > > > > Best Regards, > > Cooper > > +886-2-6622-1166 > > > > > > -----Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Tuesday, April

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-10 Thread Chiou, Cooper
6622-1166 -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Tuesday, April 9, 2019 23:57 PM To: Chiou, Cooper Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; ch...@freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 03:46:20PM +, Chiou, Cooper wrote: > Hi Ville, > > The bits is 5-7 means it’s 001x for 2.97Gbps, and 010x for 1.65Gbps. > So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297. No. The bitfield is defined as something:3. > And HDMI_MAX_DATA_RATE_165

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Chiou, Cooper
Hi Ville, The bits is 5-7 means it’s 001x for 2.97Gbps, and 010x for 1.65Gbps. So correct value should be 2 not 1 for HDMI_MAX_DATA_RATE_297. And HDMI_MAX_DATA_RATE_165 is 4 not 2. I checked kernel i915 log and modified VBT to limit HDMI 1.4 from HDMI 2.0 then found this error. And I

Re: [Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 06:07:08PM +0800, Chiou, Cooper wrote: > VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps > is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map > correct values Eh what? Did someone just change the interpretation of these

[Intel-gfx] [PATCH] drm/i915: Update HDMI max TMDS data rate definition for VBT

2019-04-09 Thread Chiou, Cooper
VBT version 212 defined HDMI max. bit-rate 2.97Gbps is 0x02 and 1.65Gbps is 0x04, so changed HDMI_MAX_DATA_RATE_297/HDMI_MAX_DATA_RATE_165 to map correct values Per VBT BSpec definition in HDMI max. data rate, Bits7-5 is HDMI max. data rate 000=Default, 001=2.97Gbps, 010=1.65Gbps, so