Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-26 Thread Daniel Vetter
On Mon, Aug 18, 2014 at 02:13:06PM +0100, Chris Wilson wrote: On Mon, Aug 18, 2014 at 02:07:40PM +0100, Damien Lespiau wrote: On Mon, Aug 18, 2014 at 01:58:06PM +0100, Chris Wilson wrote: On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: Chris has decided that enough is

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-18 Thread Jani Nikula
On Fri, 15 Aug 2014, Damien Lespiau damien.lesp...@intel.com wrote: Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv and the, oh so awful, INTEL_INFO(). This is a modest contribution to the crusade. -#define for_each_pipe(p) for ((p) = 0; (p)

[Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-18 Thread Damien Lespiau
Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest contribution to the crusade. v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode the info struct with defines (Chris) Rename the macro argument from 'dev' to 'dev_priv'

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-18 Thread Chris Wilson
On Mon, Aug 18, 2014 at 11:00:42AM +0100, Damien Lespiau wrote: Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest contribution to the crusade. v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode the info struct with defines

[Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-18 Thread Damien Lespiau
Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest contribution to the crusade. v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode the info struct with defines (Chris) Rename the macro argument from 'dev' to 'dev_priv'

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-18 Thread Chris Wilson
On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest contribution to the crusade. v2: Still use INTEL_INFO(), for the (mythical!) case we want to hardcode the info struct with defines

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-18 Thread Damien Lespiau
On Mon, Aug 18, 2014 at 01:58:06PM +0100, Chris Wilson wrote: On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest contribution to the crusade. v2: Still use INTEL_INFO(), for the

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-18 Thread Chris Wilson
On Mon, Aug 18, 2014 at 02:07:40PM +0100, Damien Lespiau wrote: On Mon, Aug 18, 2014 at 01:58:06PM +0100, Chris Wilson wrote: On Mon, Aug 18, 2014 at 01:49:10PM +0100, Damien Lespiau wrote: Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv. This is a modest

[Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-15 Thread Damien Lespiau
Chris has decided that enough is enough. It's time to fixup dev Vs dev_priv and the, oh so awful, INTEL_INFO(). This is a modest contribution to the crusade. Suggested-by: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Damien Lespiau damien.lesp...@intel.com ---

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_priv as first argument of for_each_pipe()

2014-08-15 Thread Chris Wilson
On Fri, Aug 15, 2014 at 06:34:06PM +0100, Damien Lespiau wrote: -#define for_each_pipe(p) for ((p) = 0; (p) INTEL_INFO(dev)-num_pipes; (p)++) +#define for_each_pipe(dev, p) for ((p) = 0; (p) (dev)-info.num_pipes; (p)++) #define for_each_sprite(p, s) for ((s) = 0; (s)