Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-11-19 Thread Daniel Vetter
On Wed, Nov 18, 2015 at 06:31:05PM +, Vivi, Rodrigo wrote: > On Tue, 2015-11-17 at 15:08 +0100, Daniel Vetter wrote: > > On Mon, Nov 16, 2015 at 04:05:42PM +, Rodrigo Vivi wrote: > > > Ok, so after trying it we saw that we really cannot trust on aux > > > mutex.At > > > least not on all SK

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-11-18 Thread Vivi, Rodrigo
On Tue, 2015-11-17 at 15:08 +0100, Daniel Vetter wrote: > On Mon, Nov 16, 2015 at 04:05:42PM +, Rodrigo Vivi wrote: > > Ok, so after trying it we saw that we really cannot trust on aux > > mutex.At > > least not on all SKL/KBL > > It worked in a KBL but failed on a SKL that I have here... > >

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-11-17 Thread Daniel Vetter
On Mon, Nov 16, 2015 at 04:05:42PM +, Rodrigo Vivi wrote: > Ok, so after trying it we saw that we really cannot trust on aux mutex.At > least not on all SKL/KBL > It worked in a KBL but failed on a SKL that I have here... > > So without aux mutex option we still need to get sink_crc more relia

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-11-16 Thread Rodrigo Vivi
Ok, so after trying it we saw that we really cannot trust on aux mutex.At least not on all SKL/KBL It worked in a KBL but failed on a SKL that I have here... So without aux mutex option we still need to get sink_crc more reliable and I see only 2 quick ways here: - This read wake - Return -EBUSY t

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-10-21 Thread Thulasimani, Sivakumar
On 10/22/2015 1:44 AM, Damien Lespiau wrote: On Thu, Oct 22, 2015 at 12:01:21AM +0530, Thulasimani, Sivakumar wrote: On 8/25/2015 2:50 AM, Vivi, Rodrigo wrote: On Mon, 2015-08-24 at 19:54 +, Zanoni, Paulo R wrote: Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu: Let's use a na

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-10-21 Thread Damien Lespiau
On Thu, Oct 22, 2015 at 12:01:21AM +0530, Thulasimani, Sivakumar wrote: > > > On 8/25/2015 2:50 AM, Vivi, Rodrigo wrote: > >On Mon, 2015-08-24 at 19:54 +, Zanoni, Paulo R wrote: > >>Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu: > >>>Let's use a native read with retry as suggested

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-10-21 Thread Vivi, Rodrigo
On Thu, 2015-10-22 at 00:01 +0530, Thulasimani, Sivakumar wrote: > > On 8/25/2015 2:50 AM, Vivi, Rodrigo wrote: > > On Mon, 2015-08-24 at 19:54 +, Zanoni, Paulo R wrote: > > > Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu: > > > > Let's use a native read with retry as suggested per

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-10-21 Thread Thulasimani, Sivakumar
On 8/25/2015 2:50 AM, Vivi, Rodrigo wrote: On Mon, 2015-08-24 at 19:54 +, Zanoni, Paulo R wrote: Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu: Let's use a native read with retry as suggested per spec to fix Sink CRC on SKL when PSR is enabled. With PSR enabled panel is probab

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-27 Thread Jani Nikula
On Thu, 27 Aug 2015, Daniel Vetter wrote: > On Wed, Aug 26, 2015 at 6:41 PM, Vivi, Rodrigo wrote: >> On Wed, 2015-08-26 at 11:06 +0200, Daniel Vetter wrote: >>> On Thu, Aug 20, 2015 at 04:12:00PM -0700, Rodrigo Vivi wrote: >>> > From: Rodrigo Vivi >>> > >>> > Let's use a native read with retry a

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-27 Thread Daniel Vetter
On Wed, Aug 26, 2015 at 6:41 PM, Vivi, Rodrigo wrote: > On Wed, 2015-08-26 at 11:06 +0200, Daniel Vetter wrote: >> On Thu, Aug 20, 2015 at 04:12:00PM -0700, Rodrigo Vivi wrote: >> > From: Rodrigo Vivi >> > >> > Let's use a native read with retry as suggested per spec to >> > fix Sink CRC on SKL w

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-26 Thread Vivi, Rodrigo
On Wed, 2015-08-26 at 11:06 +0200, Daniel Vetter wrote: > On Thu, Aug 20, 2015 at 04:12:00PM -0700, Rodrigo Vivi wrote: > > From: Rodrigo Vivi > > > > Let's use a native read with retry as suggested per spec to > > fix Sink CRC on SKL when PSR is enabled. > > > > With PSR enabled panel is probab

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-26 Thread Daniel Vetter
On Thu, Aug 20, 2015 at 04:12:00PM -0700, Rodrigo Vivi wrote: > From: Rodrigo Vivi > > Let's use a native read with retry as suggested per spec to > fix Sink CRC on SKL when PSR is enabled. > > With PSR enabled panel is probably taking more time to wake > and dpcd read is faling. > > Cc: Sonika

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-24 Thread Vivi, Rodrigo
On Mon, 2015-08-24 at 19:54 +, Zanoni, Paulo R wrote: > Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu: > > Let's use a native read with retry as suggested per spec to > > fix Sink CRC on SKL when PSR is enabled. > > > > With PSR enabled panel is probably taking more time to wake > >

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-24 Thread Zanoni, Paulo R
Em Qui, 2015-08-20 às 16:23 -0700, Rodrigo Vivi escreveu: > Let's use a native read with retry as suggested per spec to > fix Sink CRC on SKL when PSR is enabled. > > With PSR enabled panel is probably taking more time to wake > and dpcd read is faling. Does this commit actually fix any known pro

Re: [Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-23 Thread Jindal, Sonika
So, sink crc during psr works now? Great, I will give a try with this patch.. Regards, Sonika -Original Message- From: Vivi, Rodrigo Sent: Friday, August 21, 2015 4:53 AM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo; Antognolli, Rafael; Jindal, Sonika Subject: [PATCH] drm/i915:

[Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-20 Thread Rodrigo Vivi
Let's use a native read with retry as suggested per spec to fix Sink CRC on SKL when PSR is enabled. With PSR enabled panel is probably taking more time to wake and dpcd read is faling. v2: Fix my email domain on commit message. Thanks Rafael. Cc: Rafael Antognolli Cc: Sonika Jindal Signed-off

[Intel-gfx] [PATCH] drm/i915: Use dpcd read wake for sink crc calls.

2015-08-20 Thread Rodrigo Vivi
From: Rodrigo Vivi Let's use a native read with retry as suggested per spec to fix Sink CRC on SKL when PSR is enabled. With PSR enabled panel is probably taking more time to wake and dpcd read is faling. Cc: Sonika Jindal Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 15