Re: [Intel-gfx] [PATCH] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-26 Thread Chris Wilson
On Tue, Apr 26, 2016 at 10:08:07AM +0100, Matthew Auld wrote: > If we are not in FULL_48BIT_PPGTT mode then we really shouldn't > continue on with our allocations, given that the call to free_pdp would > bail early without freeing everything, thus leaking memory. Why? Why are you second guessing

[Intel-gfx] [PATCH] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-26 Thread Matthew Auld
If we are not in FULL_48BIT_PPGTT mode then we really shouldn't continue on with our allocations, given that the call to free_pdp would bail early without freeing everything, thus leaking memory. v2: (Joonas Lahtinen) - tidy up with goto teardown path v3: (Joonas Lahtinen) - use more