Re: [Intel-gfx] [PATCH] drm/i915: clean up vlv -pre_pll_enable and pll enable sequence

2013-07-12 Thread Daniel Vetter
On Thu, Jul 11, 2013 at 05:11:41PM +0300, Imre Deak wrote: This piece was not added to vlv_enable_pll. Other than this patches 29-31 look ok, so on those: Reviewed-by: Imre Deak imre.d...@intel.com Ok, I've pushed the updated patch plus the other two, thanks for the review. -Daniel --

Re: [Intel-gfx] [PATCH] drm/i915: clean up vlv -pre_pll_enable and pll enable sequence

2013-07-11 Thread Imre Deak
On Thu, 2013-06-06 at 10:22 +0200, Daniel Vetter wrote: No need to call the -pre_pll_enable hook twice if we don't enable the dpll too early. This should make Jani a bit less grumpy. v2: Rebase on top of the newly-colored BUG_ONs. Cc: Jani Nikula jani.nik...@intel.com Signed-off-by:

[Intel-gfx] [PATCH] drm/i915: clean up vlv -pre_pll_enable and pll enable sequence

2013-07-11 Thread Daniel Vetter
No need to call the -pre_pll_enable hook twice if we don't enable the dpll too early. This should make Jani a bit less grumpy. v2: Rebase on top of the newly-colored BUG_ONs. v3: Reinstate the lost write of the DPLL_MD register, spotted by Imre. Cc: Imre Deak imre.d...@intel.com Cc: Jani Nikula

[Intel-gfx] [PATCH] drm/i915: clean up vlv -pre_pll_enable and pll enable sequence

2013-06-06 Thread Daniel Vetter
No need to call the -pre_pll_enable hook twice if we don't enable the dpll too early. This should make Jani a bit less grumpy. v2: Rebase on top of the newly-colored BUG_ONs. Cc: Jani Nikula jani.nik...@intel.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch ---