Re: [Intel-gfx] [PATCH] drm/i915: fix driver's versions of WARN_ON & WARN_ON_ONCE

2015-08-26 Thread Daniel Vetter
On Mon, Aug 17, 2015 at 01:45:01PM -0300, Paulo Zanoni wrote: > 2015-08-17 13:30 GMT-03:00 Dave Gordon : > > The current versions of these two macros don't work correctly if the > > argument expression happens to contain a modulo operator (%) -- when > > stringified, it gets interpreted as a printf

Re: [Intel-gfx] [PATCH] drm/i915: fix driver's versions of WARN_ON & WARN_ON_ONCE

2015-08-26 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7223 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -2

Re: [Intel-gfx] [PATCH] drm/i915: fix driver's versions of WARN_ON & WARN_ON_ONCE

2015-08-17 Thread Paulo Zanoni
2015-08-17 13:30 GMT-03:00 Dave Gordon : > The current versions of these two macros don't work correctly if the > argument expression happens to contain a modulo operator (%) -- when > stringified, it gets interpreted as a printf formatting character! > With a specifically crafted parameter, this c

[Intel-gfx] [PATCH] drm/i915: fix driver's versions of WARN_ON & WARN_ON_ONCE

2015-08-17 Thread Dave Gordon
The current versions of these two macros don't work correctly if the argument expression happens to contain a modulo operator (%) -- when stringified, it gets interpreted as a printf formatting character! With a specifically crafted parameter, this could probably cause a kernel OOPS; consider WARN_