Hi,
Patch LGTM.
Reviewed-by: Mahesh Kumar
thanks,
-Mahesh
On 6/8/2018 4:37 AM, Paulo Zanoni wrote:
While things may have been different before, right now the function is
very simple and has a single caller. IMHO any possible benefits from
an abstraction here are gone and not worth the price
Em Sex, 2018-06-08 às 00:49 +0100, Chris Wilson escreveu:
> Quoting Paulo Zanoni (2018-06-08 00:07:00)
> > static void
> > skl_print_wm_changes(const struct drm_atomic_state *state)
> > {
> > @@ -5381,7 +5370,10 @@ static void skl_initial_wm(struct
> > intel_atomic_state *state,
> > if
Quoting Paulo Zanoni (2018-06-08 00:07:00)
> static void
> skl_print_wm_changes(const struct drm_atomic_state *state)
> {
> @@ -5381,7 +5370,10 @@ static void skl_initial_wm(struct intel_atomic_state
> *state,
> if (cstate->base.active_changed)
>
While things may have been different before, right now the function is
very simple and has a single caller. IMHO any possible benefits from
an abstraction here are gone and not worth the price of the current
indirection while reading the code.
Cc: Mahesh Kumar
Signed-off-by: Paulo Zanoni
---