Re: [Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-09-02 Thread Chris Wilson
On Thu, 1 Sep 2011 19:51:11 -0700, Ben Widawsky b...@bwidawsk.net wrote: On Thu, 01 Sep 2011 11:03:07 -0700 Eric Anholt e...@anholt.net wrote: On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky b...@bwidawsk.net wrote: Assertion + unsigned helps catch potential issues. From the

Re: [Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-09-01 Thread Eric Anholt
On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky b...@bwidawsk.net wrote: Assertion + unsigned helps catch potential issues. From the docs it is hard to tell if the global GTT flag is actually needed, but it shouldn't hurt. We're updating a register, not the GTT, so I don't see why the flag

Re: [Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-09-01 Thread Ben Widawsky
On Thu, 01 Sep 2011 11:03:07 -0700 Eric Anholt e...@anholt.net wrote: On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky b...@bwidawsk.net wrote: Assertion + unsigned helps catch potential issues. From the docs it is hard to tell if the global GTT flag is actually needed, but it

[Intel-gfx] [PATCH] drm/i915: small semaphore fix

2011-08-31 Thread Ben Widawsky
Assertion + unsigned helps catch potential issues. From the docs it is hard to tell if the global GTT flag is actually needed, but it shouldn't hurt. Signed-off-by: Ben Widawsky b...@bwidawsk.net --- drivers/gpu/drm/i915/intel_ringbuffer.c |5 - 1 files changed, 4 insertions(+), 1