[Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-13 Thread Maarten Lankhorst
From: Daniel Vetter Two bits: - check actual atomic state, the legacy stuff can only be looked at from within the atomic_commit_tail function, since it's only protected by ordering and not by any locks. - Make sure we don't wreak the work an ongoing nonblocking

[Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-13 Thread Maarten Lankhorst
From: Daniel Vetter Two bits: - check actual atomic state, the legacy stuff can only be looked at from within the atomic_commit_tail function, since it's only protected by ordering and not by any locks. - Make sure we don't wreak the work an ongoing nonblocking

Re: [Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Manasi Navare
On Wed, Nov 08, 2017 at 10:09:32AM -0800, Manasi Navare wrote: > On Wed, Nov 08, 2017 at 02:28:23PM +0100, Daniel Vetter wrote: > > On Wed, Nov 08, 2017 at 03:26:15PM +0200, Ville Syrjälä wrote: > > > On Wed, Nov 08, 2017 at 02:11:46PM +0100, Daniel Vetter wrote: > > > > On Wed, Nov 08, 2017 at

Re: [Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Manasi Navare
On Wed, Nov 08, 2017 at 02:28:23PM +0100, Daniel Vetter wrote: > On Wed, Nov 08, 2017 at 03:26:15PM +0200, Ville Syrjälä wrote: > > On Wed, Nov 08, 2017 at 02:11:46PM +0100, Daniel Vetter wrote: > > > On Wed, Nov 08, 2017 at 03:04:58PM +0200, Ville Syrjälä wrote: > > > > On Wed, Nov 08, 2017 at

Re: [Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Daniel Vetter
On Wed, Nov 08, 2017 at 03:26:15PM +0200, Ville Syrjälä wrote: > On Wed, Nov 08, 2017 at 02:11:46PM +0100, Daniel Vetter wrote: > > On Wed, Nov 08, 2017 at 03:04:58PM +0200, Ville Syrjälä wrote: > > > On Wed, Nov 08, 2017 at 01:57:50PM +0100, Daniel Vetter wrote: > > > > Two bits: > > > > - check

Re: [Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Ville Syrjälä
On Wed, Nov 08, 2017 at 02:11:46PM +0100, Daniel Vetter wrote: > On Wed, Nov 08, 2017 at 03:04:58PM +0200, Ville Syrjälä wrote: > > On Wed, Nov 08, 2017 at 01:57:50PM +0100, Daniel Vetter wrote: > > > Two bits: > > > - check actual atomic state, the legacy stuff can only be looked at > > > from

Re: [Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Maarten Lankhorst
Op 08-11-17 om 14:04 schreef Ville Syrjälä: > On Wed, Nov 08, 2017 at 01:57:50PM +0100, Daniel Vetter wrote: >> Two bits: >> - check actual atomic state, the legacy stuff can only be looked at >> from within the atomic_commit_tail function, since it's only >> protected by ordering and not by

Re: [Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Daniel Vetter
On Wed, Nov 08, 2017 at 03:04:58PM +0200, Ville Syrjälä wrote: > On Wed, Nov 08, 2017 at 01:57:50PM +0100, Daniel Vetter wrote: > > Two bits: > > - check actual atomic state, the legacy stuff can only be looked at > > from within the atomic_commit_tail function, since it's only > > protected

Re: [Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Ville Syrjälä
On Wed, Nov 08, 2017 at 01:57:50PM +0100, Daniel Vetter wrote: > Two bits: > - check actual atomic state, the legacy stuff can only be looked at > from within the atomic_commit_tail function, since it's only > protected by ordering and not by any locks. > > - Make sure we don't wreak the work

[Intel-gfx] [PATCH] drm/i915: sync dp link status checks against atomic commmits

2017-11-08 Thread Daniel Vetter
Two bits: - check actual atomic state, the legacy stuff can only be looked at from within the atomic_commit_tail function, since it's only protected by ordering and not by any locks. - Make sure we don't wreak the work an ongoing nonblocking commit is doing. v2: We need the crtc lock too,