Re: [Intel-gfx] [PATCH] drm/sysfs: Grab lock for edid/modes_show

2015-11-19 Thread Daniel Vetter
On Fri, Oct 02, 2015 at 01:08:40PM +0100, Emil Velikov wrote: > On 2 October 2015 at 12:01, Daniel Vetter wrote: > > We chase pointers/lists without taking the locks protecting them, > > which isn't that good. > > > > Fix it. > > > > v2: Actually unlock properly, spotted

[Intel-gfx] [PATCH] drm/sysfs: Grab lock for edid/modes_show

2015-10-02 Thread Daniel Vetter
We chase pointers/lists without taking the locks protecting them, which isn't that good. Fix it. v2: Actually unlock properly, spotted by Julia. Cc: Julia Lawall Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_sysfs.c | 16

[Intel-gfx] [PATCH] drm/sysfs: Grab lock for edid/modes_show

2015-10-02 Thread Daniel Vetter
We chase pointers/lists without taking the locks protecting them, which isn't that good. Fix it. v2: Actually unlock properly, spotted by Julia. v3: Put the label _before_ the mutex_unlock (Emil) Cc: Emil Velikov Cc: Julia Lawall Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/sysfs: Grab lock for edid/modes_show

2015-10-02 Thread Emil Velikov
On 2 October 2015 at 12:01, Daniel Vetter wrote: > We chase pointers/lists without taking the locks protecting them, > which isn't that good. > > Fix it. > > v2: Actually unlock properly, spotted by Julia. > > v3: Put the label _before_ the mutex_unlock (Emil) > > Cc: Emil

Re: [Intel-gfx] [PATCH] drm/sysfs: Grab lock for edid/modes_show

2015-10-02 Thread Julia Lawall
On Fri, 2 Oct 2015, Daniel Vetter wrote: > We chase pointers/lists without taking the locks protecting them, > which isn't that good. > > Fix it. > > v2: Actually unlock properly, spotted by Julia. The unlock is still on top of the unlock label? julia > > Cc: Julia Lawall