[Intel-gfx] [PATCH] drm: Assert correct locking for drm_send_vblank_event

2014-09-12 Thread Daniel Vetter
The comment says that the caller must hold the dev-event_lock spinlock, so let's enforce this. A quick audit over all driver shows that except for the one place in i915 which motivated this all callers fullfill this requirement already. Cc: Chris Wilson ch...@chris-wilson.co.uk Cc:

Re: [Intel-gfx] [PATCH] drm: Assert correct locking for drm_send_vblank_event

2014-09-12 Thread Chris Wilson
On Fri, Sep 12, 2014 at 03:40:56PM +0200, Daniel Vetter wrote: The comment says that the caller must hold the dev-event_lock spinlock, so let's enforce this. A quick audit over all driver shows that except for the one place in i915 which motivated this all callers fullfill this requirement

Re: [Intel-gfx] [PATCH] drm: Assert correct locking for drm_send_vblank_event

2014-09-12 Thread Daniel Vetter
On Fri, Sep 12, 2014 at 04:23:29PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at 03:40:56PM +0200, Daniel Vetter wrote: The comment says that the caller must hold the dev-event_lock spinlock, so let's enforce this. A quick audit over all driver shows that except for the one place in

Re: [Intel-gfx] [PATCH] drm: Assert correct locking for drm_send_vblank_event

2014-09-12 Thread Chris Wilson
On Fri, Sep 12, 2014 at 05:34:56PM +0200, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 04:23:29PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at 03:40:56PM +0200, Daniel Vetter wrote: The comment says that the caller must hold the dev-event_lock spinlock, so let's enforce this.

Re: [Intel-gfx] [PATCH] drm: Assert correct locking for drm_send_vblank_event

2014-09-12 Thread Daniel Vetter
On Fri, Sep 12, 2014 at 01:03:51PM -0400, Peter Hurley wrote: On 09/12/2014 12:04 PM, Chris Wilson wrote: On Fri, Sep 12, 2014 at 05:34:56PM +0200, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 04:23:29PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at 03:40:56PM +0200, Daniel Vetter

Re: [Intel-gfx] [PATCH] drm: Assert correct locking for drm_send_vblank_event

2014-09-12 Thread Peter Hurley
On 09/12/2014 01:25 PM, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 01:03:51PM -0400, Peter Hurley wrote: On 09/12/2014 12:04 PM, Chris Wilson wrote: On Fri, Sep 12, 2014 at 05:34:56PM +0200, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 04:23:29PM +0100, Chris Wilson wrote: On Fri, Sep 12,

Re: [Intel-gfx] [PATCH] drm: Assert correct locking for drm_send_vblank_event

2014-09-12 Thread Peter Hurley
On 09/12/2014 12:04 PM, Chris Wilson wrote: On Fri, Sep 12, 2014 at 05:34:56PM +0200, Daniel Vetter wrote: On Fri, Sep 12, 2014 at 04:23:29PM +0100, Chris Wilson wrote: On Fri, Sep 12, 2014 at 03:40:56PM +0200, Daniel Vetter wrote: The comment says that the caller must hold the dev-event_lock