Re: [Intel-gfx] [PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported()

2020-10-26 Thread Daniel Vetter
On Sat, Oct 24, 2020 at 12:52 AM Ville Syrjälä wrote: > > On Fri, Oct 23, 2020 at 10:03:50PM +, Simon Ser wrote: > > On Friday, October 23, 2020 10:39 PM, Ville Syrjala > > wrote: > > > > > From: Ville Syrjälä ville.syrj...@linux.intel.com > > > > > > The code responsible for creating the

Re: [Intel-gfx] [PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported()

2020-10-23 Thread Ville Syrjälä
On Fri, Oct 23, 2020 at 10:03:50PM +, Simon Ser wrote: > On Friday, October 23, 2020 10:39 PM, Ville Syrjala > wrote: > > > From: Ville Syrjälä ville.syrj...@linux.intel.com > > > > The code responsible for creating the IN_FORMATS > > blob is broken when the driver doesn't provide a > >

Re: [Intel-gfx] [PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported()

2020-10-23 Thread Simon Ser
On Friday, October 23, 2020 10:39 PM, Ville Syrjala wrote: > From: Ville Syrjälä ville.syrj...@linux.intel.com > > The code responsible for creating the IN_FORMATS > blob is broken when the driver doesn't provide a > .format_mod_supported() hook. It just copies in > the format list, but leaves

[Intel-gfx] [PATCH] drm: Don't create the IN_FORMATS blob when the driver does not provide .format_mod_supported()

2020-10-23 Thread Ville Syrjala
From: Ville Syrjälä The code responsible for creating the IN_FORMATS blob is broken when the driver doesn't provide a .format_mod_supported() hook. It just copies in the format list, but leaves all the modifier information zeroed. That would indicate (in a very silly way) that there are in fact