Re: [Intel-gfx] [PATCH] drm: fix call_kern.cocci warnings (fwd)

2018-10-25 Thread Koenig, Christian
Am 25.10.18 um 09:51 schrieb Maarten Lankhorst: > Op 25-10-18 om 08:53 schreef Christian König: >> Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing): >>> Reviewed-by: Chunming Zhou >> NAK, GFP_ATOMIC should be avoided. >> >> The correct solution is to move the allocation out of the spinlock or

Re: [Intel-gfx] [PATCH] drm: fix call_kern.cocci warnings (fwd)

2018-10-25 Thread Maarten Lankhorst
Op 25-10-18 om 08:53 schreef Christian König: > Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing): >> Reviewed-by: Chunming Zhou > > NAK, GFP_ATOMIC should be avoided. > > The correct solution is to move the allocation out of the spinlock or drop > the lock and reacquire. Yeah +1. Especially

Re: [Intel-gfx] [PATCH] drm: fix call_kern.cocci warnings (fwd)

2018-10-25 Thread Maarten Lankhorst
Op 24-10-18 om 20:57 schreef Julia Lawall: > The containing function is called with a spin_lock held, so GFP_KERNEL > can't be used. > > julia > > -- Forwarded message -- > Date: Tue, 23 Oct 2018 17:14:25 +0800 > From: kbuild test robot > To: kbu...@01.org > Cc: Julia Lawall >

Re: [Intel-gfx] [PATCH] drm: fix call_kern.cocci warnings (fwd)

2018-10-24 Thread Zhou, David(ChunMing)
Reviewed-by: Chunming Zhou > -Original Message- > From: Julia Lawall > Sent: Thursday, October 25, 2018 2:57 AM > To: Zhou, David(ChunMing) > Cc: kbuild-...@01.org; intel-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; Christian König > ; Gustavo Padovan > ; Maarten

[Intel-gfx] [PATCH] drm: fix call_kern.cocci warnings (fwd)

2018-10-24 Thread Julia Lawall
The containing function is called with a spin_lock held, so GFP_KERNEL can't be used. julia -- Forwarded message -- Date: Tue, 23 Oct 2018 17:14:25 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: [PATCH] drm: fix call_kern.cocci warnings CC: