Re: [Intel-gfx] [PATCH] drm: i915: Preserve old FBC status if update with no new planes

On Tue, May 16, 2017 at 06:52:17PM -0700, Manasi Navare wrote: > On Tue, May 16, 2017 at 10:27:33PM -0300, Gabriel Krisman Bertazi wrote: > > Manasi Navare writes: > > > > Hi Manasi, > > > > > So the purpose of this patch is to avoid overwriting the no_fbc_reason > >

Re: [Intel-gfx] [PATCH] drm: i915: Preserve old FBC status if update with no new planes

On Tue, May 16, 2017 at 10:27:33PM -0300, Gabriel Krisman Bertazi wrote: > Manasi Navare writes: > > Hi Manasi, > > > So the purpose of this patch is to avoid overwriting the no_fbc_reason > > field during atomic_check in case there is no plane update so that > > it

Re: [Intel-gfx] [PATCH] drm: i915: Preserve old FBC status if update with no new planes

Manasi Navare writes: Hi Manasi, > So the purpose of this patch is to avoid overwriting the no_fbc_reason > field during atomic_check in case there is no plane update so that > it retains the actual failure message from previous atomic commit operation > failure where

Re: [Intel-gfx] [PATCH] drm: i915: Preserve old FBC status if update with no new planes

Hi Gabriel, So the purpose of this patch is to avoid overwriting the no_fbc_reason field during atomic_check in case there is no plane update so that it retains the actual failure message from previous atomic commit operation failure where it failed to enable fbc in intel_fbc_can_enable() during

[Intel-gfx] [PATCH] drm: i915: Preserve old FBC status if update with no new planes

If the atomic commit doesn't include any new plane, there is no need to choose a new CRTC for FBC, and the intel_fbc_choose_crtc() will bail out early. Although, if the FBC setup failed beforehand for whatever reason, we don't bail early, but we change the no_fbc_reason to "no suitable CRTC for