[Intel-gfx] [PATCH] load_cursor_argb is supposed to return a Bool, not void

2014-04-14 Thread Keith Packard
By mis-declaring this function, we ended up using software cursors because the value seen by the caller was 0. Signed-off-by: Keith Packard kei...@keithp.com --- src/sna/sna_display.c | 8 ++-- src/sna/sna_display_fake.c | 3 ++- src/uxa/intel_display.c| 7 +-- 3 files changed,

Re: [Intel-gfx] [PATCH] load_cursor_argb is supposed to return a Bool, not void

2014-04-14 Thread Julien Cristau
On Mon, Apr 14, 2014 at 11:22:03 -0700, Keith Packard wrote: By mis-declaring this function, we ended up using software cursors because the value seen by the caller was 0. Signed-off-by: Keith Packard kei...@keithp.com --- src/sna/sna_display.c | 8 ++--

Re: [Intel-gfx] [PATCH] load_cursor_argb is supposed to return a Bool, not void

2014-04-14 Thread Keith Packard
Julien Cristau jcris...@debian.org writes: Only since http://cgit.freedesktop.org/xorg/xserver/commit/?id=901fbfbbbd71c0d82080957f8ba09eebbc786f2b Which could probably have used a different name to avoid silent breakage. Yeah, that probably would have been a better change. --