Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 03:21:56PM +0100, Rafael J. Wysocki wrote: > On Wed, Dec 19, 2018 at 1:39 PM Daniel Vetter wrote: > > > > This is the much more correct fix for my earlier attempt at: > > > > https://lkml.org/lkml/2018/12/10/118 > > > > Short recap: > > > > - There's not actually a locking

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Greg Kroah-Hartman
On Wed, Dec 19, 2018 at 02:26:22PM +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 02:18:25PM +0100, Daniel Vetter wrote: > > On Wed, Dec 19, 2018 at 01:49:30PM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Dec 19, 2018 at 01:39:09PM +0100, Daniel Vetter wrote: > > > > ---

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Rafael J. Wysocki
On Wed, Dec 19, 2018 at 1:39 PM Daniel Vetter wrote: > > This is the much more correct fix for my earlier attempt at: > > https://lkml.org/lkml/2018/12/10/118 > > Short recap: > > - There's not actually a locking issue, it's just lockdep being a bit > too eager to complain about a possible

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 02:18:25PM +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 01:49:30PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Dec 19, 2018 at 01:39:09PM +0100, Daniel Vetter wrote: > > > --- a/include/linux/device.h > > > +++ b/include/linux/device.h > > > @@ -327,6 +327,7 @@

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 01:49:30PM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 19, 2018 at 01:39:09PM +0100, Daniel Vetter wrote: > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -327,6 +327,7 @@ struct driver_attribute { > > #define DRIVER_ATTR_WO(_name) \ > >

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Greg Kroah-Hartman
On Wed, Dec 19, 2018 at 01:39:09PM +0100, Daniel Vetter wrote: > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -327,6 +327,7 @@ struct driver_attribute { > #define DRIVER_ATTR_WO(_name) \ > struct driver_attribute driver_attr_##_name = __ATTR_WO(_name) > > + > extern

[Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Daniel Vetter
This is the much more correct fix for my earlier attempt at: https://lkml.org/lkml/2018/12/10/118 Short recap: - There's not actually a locking issue, it's just lockdep being a bit too eager to complain about a possible deadlock. - Contrary to what I claimed the real problem is recursion on

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Greg Kroah-Hartman
On Wed, Dec 19, 2018 at 10:24:51AM +0100, Rafael J. Wysocki wrote: > On Wed, Dec 19, 2018 at 8:01 AM Greg Kroah-Hartman > wrote: > > > > On Tue, Dec 18, 2018 at 09:14:43PM +0100, Daniel Vetter wrote: > > > This is the much more correct fix for my earlier attempt at: > > > > > >

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Rafael J. Wysocki
On Wed, Dec 19, 2018 at 10:24 AM Daniel Vetter wrote: > > On Wed, Dec 19, 2018 at 8:01 AM Greg Kroah-Hartman > wrote: > > > > On Tue, Dec 18, 2018 at 09:14:43PM +0100, Daniel Vetter wrote: > > > This is the much more correct fix for my earlier attempt at: > > > > > >

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Rafael J. Wysocki
On Wed, Dec 19, 2018 at 8:01 AM Greg Kroah-Hartman wrote: > > On Tue, Dec 18, 2018 at 09:14:43PM +0100, Daniel Vetter wrote: > > This is the much more correct fix for my earlier attempt at: > > > > https://lkml.org/lkml/2018/12/10/118 > > > > Short recap: > > > > - There's not actually a locking

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 8:01 AM Greg Kroah-Hartman wrote: > > On Tue, Dec 18, 2018 at 09:14:43PM +0100, Daniel Vetter wrote: > > This is the much more correct fix for my earlier attempt at: > > > > https://lkml.org/lkml/2018/12/10/118 > > > > Short recap: > > > > - There's not actually a locking

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-18 Thread Greg Kroah-Hartman
On Tue, Dec 18, 2018 at 09:14:43PM +0100, Daniel Vetter wrote: > This is the much more correct fix for my earlier attempt at: > > https://lkml.org/lkml/2018/12/10/118 > > Short recap: > > - There's not actually a locking issue, it's just lockdep being a bit > too eager to complain about a

Re: [Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-18 Thread Rafael J. Wysocki
On Tue, Dec 18, 2018 at 9:14 PM Daniel Vetter wrote: > > This is the much more correct fix for my earlier attempt at: > > https://lkml.org/lkml/2018/12/10/118 > > Short recap: > > - There's not actually a locking issue, it's just lockdep being a bit > too eager to complain about a possible

[Intel-gfx] [PATCH] sysfs: Disable lockdep for driver bind/unbind files

2018-12-18 Thread Daniel Vetter
This is the much more correct fix for my earlier attempt at: https://lkml.org/lkml/2018/12/10/118 Short recap: - There's not actually a locking issue, it's just lockdep being a bit too eager to complain about a possible deadlock. - Contrary to what I claimed the real problem is recursion on