Re: [Intel-gfx] [PATCH] x86/quirks: Fix logic to apply quirk once

2021-12-29 Thread Lucas De Marchi
On Wed, Dec 29, 2021 at 05:27:52PM -0600, Bjorn Helgaas wrote: On Fri, Dec 17, 2021 at 10:13:13PM -0800, Lucas De Marchi wrote: When using QFLAG_APPLY_ONCE we make sure the quirk is applied only once. Maybe "called" only once, since you're about to add a distinction between "called" and

Re: [Intel-gfx] [PATCH] x86/quirks: Fix logic to apply quirk once

2021-12-29 Thread Bjorn Helgaas
On Fri, Dec 17, 2021 at 10:13:13PM -0800, Lucas De Marchi wrote: > When using QFLAG_APPLY_ONCE we make sure the quirk is applied only once. Maybe "called" only once, since you're about to add a distinction between "called" and "applied"? I'm not really sure the concept of QFLAG_APPLY_ONCE,

[Intel-gfx] [PATCH] x86/quirks: Fix logic to apply quirk once

2021-12-17 Thread Lucas De Marchi
When using QFLAG_APPLY_ONCE we make sure the quirk is applied only once. This is useful when it's enough one device to trigger a certain condition or when the resource in each that applies is global to the system rather than local to the device. However we call the quirk handler based on vendor,