Re: [Intel-gfx] [PATCH 01/15] drm/i915: vlv: clean up GTLC wake control/status register macros

2014-04-16 Thread Rodrigo Vivi
Well, first of all I couldn't find the regs definitions. I decided to do this review during fly but I didn't had this regs definitions on VLV docs I have here with me. Could you please point me to the correct docs? Anyway this patch isn't really modifying any behaviour. So I would tend to let my

Re: [Intel-gfx] [PATCH 01/15] drm/i915: vlv: clean up GTLC wake control/status register macros

2014-04-16 Thread Imre Deak
On Wed, 2014-04-16 at 18:08 -0300, Rodrigo Vivi wrote: Well, first of all I couldn't find the regs definitions. I decided to do this review during fly but I didn't had this regs definitions on VLV docs I have here with me. Could you please point me to the correct docs? These regs are defined

[Intel-gfx] [PATCH 01/15] drm/i915: vlv: clean up GTLC wake control/status register macros

2014-04-08 Thread Imre Deak
These will be needed by the upcoming VLV RPM helpers. Signed-off-by: Imre Deak imre.d...@intel.com --- drivers/gpu/drm/i915/i915_gem.c | 5 +++-- drivers/gpu/drm/i915/i915_reg.h | 10 -- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c