Re: [Intel-gfx] [PATCH 01/15] drm/tegra: Map cmdbuf once for reloc processing

2019-11-25 Thread Thierry Reding
On Mon, Nov 18, 2019 at 11:35:22AM +0100, Daniel Vetter wrote: > A few reasons to drop kmap: > > - For native objects all we do is look at obj->vaddr anyway, so might > as well not call functions for every page. > > - Reloc-processing on dma-buf is ... questionable. > > - Plus most dma-buf tha

Re: [Intel-gfx] [PATCH 01/15] drm/tegra: Map cmdbuf once for reloc processing

2019-11-25 Thread Thierry Reding
On Mon, Nov 25, 2019 at 10:58:56AM +0100, Daniel Vetter wrote: > On Mon, Nov 18, 2019 at 11:35:22AM +0100, Daniel Vetter wrote: > > A few reasons to drop kmap: > > > > - For native objects all we do is look at obj->vaddr anyway, so might > > as well not call functions for every page. > > > > -

Re: [Intel-gfx] [PATCH 01/15] drm/tegra: Map cmdbuf once for reloc processing

2019-11-25 Thread Daniel Vetter
On Mon, Nov 18, 2019 at 11:35:22AM +0100, Daniel Vetter wrote: > A few reasons to drop kmap: > > - For native objects all we do is look at obj->vaddr anyway, so might > as well not call functions for every page. > > - Reloc-processing on dma-buf is ... questionable. > > - Plus most dma-buf tha

[Intel-gfx] [PATCH 01/15] drm/tegra: Map cmdbuf once for reloc processing

2019-11-18 Thread Daniel Vetter
A few reasons to drop kmap: - For native objects all we do is look at obj->vaddr anyway, so might as well not call functions for every page. - Reloc-processing on dma-buf is ... questionable. - Plus most dma-buf that bother kernel cpu mmaps give you at least vmap, much less kmaps. And all th