Re: [Intel-gfx] [PATCH 02/15] drm/i915: Don't pass *DP around to link training functions

2015-10-19 Thread Conselvan De Oliveira, Ander
On Mon, 2015-10-19 at 10:15 +0530, Thulasimani, Sivakumar wrote: > > On 10/5/2015 12:31 PM, Ander Conselvan de Oliveira wrote: > > It just makes the code more confusing, so just reference intel_dp_>DP > > directly. The old behavior of not updating the value in intel_dp if link > > training fail

Re: [Intel-gfx] [PATCH 02/15] drm/i915: Don't pass *DP around to link training functions

2015-10-19 Thread Ander Conselvan De Oliveira
On Mon, 2015-10-19 at 10:15 +0530, Thulasimani, Sivakumar wrote: > > On 10/5/2015 12:31 PM, Ander Conselvan de Oliveira wrote: > > It just makes the code more confusing, so just reference intel_dp_>DP > > directly. The old behavior of not updating the value in intel_dp if link > > training fail

Re: [Intel-gfx] [PATCH 02/15] drm/i915: Don't pass *DP around to link training functions

2015-10-19 Thread Thulasimani, Sivakumar
On 10/19/2015 2:26 PM, Ander Conselvan De Oliveira wrote: On Mon, 2015-10-19 at 10:15 +0530, Thulasimani, Sivakumar wrote: On 10/5/2015 12:31 PM, Ander Conselvan de Oliveira wrote: It just makes the code more confusing, so just reference intel_dp_>DP directly. The old behavior of not

Re: [Intel-gfx] [PATCH 02/15] drm/i915: Don't pass *DP around to link training functions

2015-10-18 Thread Thulasimani, Sivakumar
On 10/5/2015 12:31 PM, Ander Conselvan de Oliveira wrote: It just makes the code more confusing, so just reference intel_dp_>DP directly. The old behavior of not updating the value in intel_dp if link training fail is preserved by saving the previous value of DP in the stack and restoring the

[Intel-gfx] [PATCH 02/15] drm/i915: Don't pass *DP around to link training functions

2015-10-05 Thread Ander Conselvan de Oliveira
It just makes the code more confusing, so just reference intel_dp_>DP directly. The old behavior of not updating the value in intel_dp if link training fail is preserved by saving the previous value of DP in the stack and restoring the old value in case of failure. Signed-off-by: Ander Conselvan