Re: [Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-09-02 Thread Daniel Vetter
On Tue, Sep 01, 2015 at 02:03:34PM +0300, Ville Syrjälä wrote: > On Tue, Sep 01, 2015 at 12:07:01PM +0200, Daniel Vetter wrote: > > On Fri, Aug 28, 2015 at 11:50:08AM -0300, Paulo Zanoni wrote: > > > 2015-08-28 11:20 GMT-03:00 Ville Syrjälä : > > > > On Fri, Aug 14,

Re: [Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-09-01 Thread Daniel Vetter
On Fri, Aug 28, 2015 at 11:50:08AM -0300, Paulo Zanoni wrote: > 2015-08-28 11:20 GMT-03:00 Ville Syrjälä : > > On Fri, Aug 14, 2015 at 06:34:07PM -0300, Paulo Zanoni wrote: > >> Always update the currrent crtc, fb and vertical offset after calling > >> enable_fbc. We

Re: [Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-09-01 Thread Ville Syrjälä
On Tue, Sep 01, 2015 at 12:07:01PM +0200, Daniel Vetter wrote: > On Fri, Aug 28, 2015 at 11:50:08AM -0300, Paulo Zanoni wrote: > > 2015-08-28 11:20 GMT-03:00 Ville Syrjälä : > > > On Fri, Aug 14, 2015 at 06:34:07PM -0300, Paulo Zanoni wrote: > > >> Always update the

Re: [Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-08-28 Thread Ville Syrjälä
On Fri, Aug 28, 2015 at 11:50:08AM -0300, Paulo Zanoni wrote: 2015-08-28 11:20 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Fri, Aug 14, 2015 at 06:34:07PM -0300, Paulo Zanoni wrote: Always update the currrent crtc, fb and vertical offset after calling enable_fbc. We were

Re: [Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-08-28 Thread Ville Syrjälä
On Fri, Aug 14, 2015 at 06:34:07PM -0300, Paulo Zanoni wrote: Always update the currrent crtc, fb and vertical offset after calling enable_fbc. We were forgetting to do so along the failure paths when enabling fbc synchronously. Fix this with a new helper to enable_fbc() and update the state

Re: [Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-08-28 Thread Paulo Zanoni
2015-08-28 11:20 GMT-03:00 Ville Syrjälä ville.syrj...@linux.intel.com: On Fri, Aug 14, 2015 at 06:34:07PM -0300, Paulo Zanoni wrote: Always update the currrent crtc, fb and vertical offset after calling enable_fbc. We were forgetting to do so along the failure paths when enabling fbc

[Intel-gfx] [PATCH 02/16] drm/i915: fix the FBC work allocation failure path

2015-08-14 Thread Paulo Zanoni
Always update the currrent crtc, fb and vertical offset after calling enable_fbc. We were forgetting to do so along the failure paths when enabling fbc synchronously. Fix this with a new helper to enable_fbc() and update the state simultaneously. v2: Improve commit message (Chris).