Re: [Intel-gfx] [PATCH 02/19] drm/i915: fold in __intel_power_well_get/put functions

2014-02-24 Thread Imre Deak
On Mon, 2014-02-24 at 10:23 -0300, Paulo Zanoni wrote: > 2014-02-17 19:02 GMT-03:00 Imre Deak : > > These functions are used only by a single call site and are simple > > enough to just fold them in. > > > > No functional change. > > > > Signed-off-by: Imre Deak > > IMHO, this makes the code hard

Re: [Intel-gfx] [PATCH 02/19] drm/i915: fold in __intel_power_well_get/put functions

2014-02-24 Thread Paulo Zanoni
2014-02-17 19:02 GMT-03:00 Imre Deak : > These functions are used only by a single call site and are simple > enough to just fold them in. > > No functional change. > > Signed-off-by: Imre Deak IMHO, this makes the code harder to read. I would prefer to not have this change. > --- > drivers/gp

Re: [Intel-gfx] [PATCH 02/19] drm/i915: fold in __intel_power_well_get/put functions

2014-02-20 Thread Chris Wilson
On Thu, Feb 20, 2014 at 11:17:31AM -0800, Jesse Barnes wrote: > On Tue, 18 Feb 2014 00:02:03 +0200 > Imre Deak wrote: > > > These functions are used only by a single call site and are simple > > enough to just fold them in. > > > > No functional change. There should be a much better reason (or

Re: [Intel-gfx] [PATCH 02/19] drm/i915: fold in __intel_power_well_get/put functions

2014-02-20 Thread Jesse Barnes
On Tue, 18 Feb 2014 00:02:03 +0200 Imre Deak wrote: > These functions are used only by a single call site and are simple > enough to just fold them in. > > No functional change. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_pm.c | 37 + >

[Intel-gfx] [PATCH 02/19] drm/i915: fold in __intel_power_well_get/put functions

2014-02-17 Thread Imre Deak
These functions are used only by a single call site and are simple enough to just fold them in. No functional change. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_pm.c | 37 + 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/drivers/