Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-08 Thread Sam Ravnborg
Hi Daniel. On Wed, Apr 08, 2020 at 02:11:47PM +0200, Daniel Vetter wrote: > On Wed, Apr 08, 2020 at 08:57:14AM +0200, Sam Ravnborg wrote: > > Hi Daniel. > > > > Finally managed to dive into this.. > > > > Maybe I need more coffee, it is still morning here. > > But alas this patch triggered a few

Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-08 Thread Daniel Vetter
On Wed, Apr 08, 2020 at 08:57:14AM +0200, Sam Ravnborg wrote: > Hi Daniel. > > Finally managed to dive into this.. > > Maybe I need more coffee, it is still morning here. > But alas this patch triggered a few comments. > > Sam > > On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wr

Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-07 Thread Sam Ravnborg
Hi Daniel. Finally managed to dive into this.. Maybe I need more coffee, it is still morning here. But alas this patch triggered a few comments. Sam On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wrote: > The kerneldoc is only added for this new function. Existing kerneldoc > a

Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-06 Thread Daniel Vetter
On Mon, Apr 6, 2020 at 2:01 PM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wrote: > > The kerneldoc is only added for this new function. Existing kerneldoc > > and examples will be udated at the very end, since onc

Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-06 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Fri, Apr 03, 2020 at 03:57:46PM +0200, Daniel Vetter wrote: > The kerneldoc is only added for this new function. Existing kerneldoc > and examples will be udated at the very end, since once all drivers > are converted over to devm_drm_dev_alloc we can unexpo

Re: [Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-05 Thread Noralf Trønnes
Den 03.04.2020 15.57, skrev Daniel Vetter: > The kerneldoc is only added for this new function. Existing kerneldoc > and examples will be udated at the very end, since once all drivers > are converted over to devm_drm_dev_alloc we can unexport a lot of > interim functions and make the documentati

[Intel-gfx] [PATCH 02/44] drm: Add devm_drm_dev_alloc macro

2020-04-03 Thread Daniel Vetter
The kerneldoc is only added for this new function. Existing kerneldoc and examples will be udated at the very end, since once all drivers are converted over to devm_drm_dev_alloc we can unexport a lot of interim functions and make the documentation for driver authors a lot cleaner and less confusin